Skip to content

Commit 973fdc2

Browse files
committed
pdn: add warnings about ignored instances and cells
Signed-off-by: Peter Gadfort <[email protected]>
1 parent e8b9c74 commit 973fdc2

File tree

6 files changed

+14
-6
lines changed

6 files changed

+14
-6
lines changed

src/pdn/src/pdn.tcl

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1025,6 +1025,8 @@ proc define_pdn_grid_macro { args } {
10251025
}
10261026
foreach inst $sub_insts {
10271027
if { ![$inst isFixed] } {
1028+
utl::warn PDN 1050 \
1029+
"Ignoring non-fixed instance for grid (${keys(-name)}): [$inst getName]"
10281030
continue
10291031
}
10301032
lappend insts $inst
@@ -1059,6 +1061,9 @@ proc define_pdn_grid_macro { args } {
10591061
foreach cell $sub_cells {
10601062
# only add blocks
10611063
if { ![$cell isBlock] } {
1064+
if { !$default_grid } {
1065+
utl::warn PDN 1041 "Ignoring non-block cell for grid (${keys(-name)}): [$cell getName]"
1066+
}
10621067
continue
10631068
}
10641069
lappend cells $cell

src/pdn/test/asap7_failed_macro_grid.tcl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ add_pdn_connect -grid {top} -layers {M2 M5}
1818
add_pdn_connect -grid {top} -layers {M5 M6}
1919

2020
define_pdn_grid -name {CORE_macro_grid_1} -voltage_domains {CORE} -macro \
21-
-orient {R0 R180 MX MY} -cells {.*}
21+
-orient {R0 R180 MX MY} -cells {fake.*}
2222
add_pdn_connect -grid {CORE_macro_grid_1} -layers {M4 M5}
2323

2424
catch { pdngen } err

src/pdn/test/macros_cells_via_failure.tcl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ add_pdn_connect -grid {grid} -layers {metal4 metal7}
3434
# grid for: CORE_macro_grid_1
3535
####################################
3636
define_pdn_grid -name {CORE_macro_grid_1} -voltage_domains {CORE} -macro \
37-
-orient {R0 R180 MX MY} -halo {2.0 2.0 2.0 2.0} -cells {.*}
37+
-orient {R0 R180 MX MY} -halo {2.0 2.0 2.0 2.0} -cells {fake.*}
3838
add_pdn_stripe -grid {CORE_macro_grid_1} -layer {metal5} -width {0.93} -pitch {10.0} -offset {2}
3939
add_pdn_stripe -grid {CORE_macro_grid_1} -layer {metal6} -width {0.93} -pitch {10.0} -offset {2}
4040
add_pdn_connect -grid {CORE_macro_grid_1} -layers {metal4 metal5}
@@ -44,7 +44,7 @@ add_pdn_connect -grid {CORE_macro_grid_1} -layers {metal6 metal7}
4444
# grid for: CORE_macro_grid_2
4545
####################################
4646
define_pdn_grid -name {CORE_macro_grid_2} -voltage_domains {CORE} -macro \
47-
-orient {R90 R270 MXR90 MYR90} -halo {2.0 2.0 2.0 2.0} -cells {.*}
47+
-orient {R90 R270 MXR90 MYR90} -halo {2.0 2.0 2.0 2.0} -cells {fake.*}
4848
add_pdn_stripe -grid {CORE_macro_grid_2} -layer {metal6} -width {0.93} -pitch {40.0} -offset {2}
4949
add_pdn_connect -grid {CORE_macro_grid_2} -layers {metal4 metal6}
5050
add_pdn_connect -grid {CORE_macro_grid_2} -layers {metal6 metal7}

src/pdn/test/macros_grid_check.ok

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
[INFO ODB-0132] Created 2 special nets and 1094 connections.
77
[INFO ODB-0133] Created 269 nets and 0 connections.
88
[WARNING PDN-1031] Unable to find cells: fakeram45_64x55
9+
[WARNING PDN-1050] Ignoring non-fixed instance for grid (sram): dcache.data.data_arrays_0.data_arrays_0_ext.mem_10
910
Voltage domain: Core
1011
Power net: VDD
1112
Ground net: VSS

src/pdn/test/macros_grid_check.tcl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,9 @@ read_def nangate_macros/floorplan.def
88

99
# Create an instance with the same prefix as the macro
1010
odb::dbInst_create \
11-
[ord::get_db_block] \
12-
[[ord::get_db] findMaster FILLCELL_X1] \
13-
{dcache.data.data_arrays_0.data_arrays_0_ext.mem_10}
11+
[ord::get_db_block] \
12+
[[ord::get_db] findMaster FILLCELL_X1] \
13+
{dcache.data.data_arrays_0.data_arrays_0_ext.mem_10}
1414

1515
add_global_connection -net VDD -pin_pattern {^VDD$} -power
1616
add_global_connection -net VDD -pin_pattern {^VDDPE$}

src/pdn/test/names.ok

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,4 +14,6 @@
1414
PDN-0184
1515
[ERROR PDN-1043] Grid named "Core" already defined.
1616
PDN-1043
17+
[WARNING PDN-1050] Ignoring non-fixed instance for grid (Inst): cmp1
18+
[WARNING PDN-1050] Ignoring non-fixed instance for grid (Inst): cmp1
1719
PDN-1043

0 commit comments

Comments
 (0)