Merge pull request #8509 from gadfort/fix-gui-sta

gui: guard update button when sta is not available

Author: maliberty

src/gui/src/timingWidget.cpp

@@ -71,6 +71,7 @@ TimingWidget::TimingWidget(QWidget* parent)
   controls_layout->insertStretch(2);
   control_frame->setLayout(controls_layout);
   layout->addWidget(control_frame);
+  update_button_->setEnabled(false);
 
   // top half
   delay_widget_->addTab(setup_timing_table_view_, "Setup");
@@ -632,6 +633,8 @@ void TimingWidget::highlightPathStage(TimingPathDetailModel* model,
 
 void TimingWidget::populatePaths()
 {
+  update_button_->setEnabled(false);
+
   clearPathDetails();
 
   const auto from = settings_->getFromPins();
@@ -640,6 +643,8 @@ void TimingWidget::populatePaths()
   const sta::ClockSet* clks = settings_->getClocks();
 
   populateAndSortModels(from, thru, to, "" /* path group name */, clks);
+
+  update_button_->setEnabled(true);
 }
 
 void TimingWidget::populateAndSortModels(
@@ -649,10 +654,20 @@ void TimingWidget::populateAndSortModels(
     const std::string& path_group_name,
     const sta::ClockSet* clks)
 {
-  setup_timing_paths_model_->populateModel(
-      from, thru, to, path_group_name, clks);
-  hold_timing_paths_model_->populateModel(
-      from, thru, to, path_group_name, clks);
+  try {
+    setup_timing_paths_model_->populateModel(
+        from, thru, to, path_group_name, clks);
+    hold_timing_paths_model_->populateModel(
+        from, thru, to, path_group_name, clks);
+  } catch (const std::runtime_error& error) {
+    setup_timing_paths_model_->resetModel();
+    hold_timing_paths_model_->resetModel();
+
+    QApplication::restoreOverrideCursor();
+
+    QMessageBox::critical(this, error.what(), "Failed to populate timing.");
+    return;
+  }
 
   // honor selected sort
   auto setup_header = setup_timing_table_view_->horizontalHeader();
@@ -797,6 +812,7 @@ void TimingWidget::toggleRenderer(bool visible)
 void TimingWidget::setBlock(odb::dbBlock* block)
 {
   dbchange_listener_->addOwner(block);
+  update_button_->setEnabled(true);
 }
 
 void TimingWidget::showSettings()