gui: partial clang-tidy cleanup

Signed-off-by: Matt Liberty <[email protected]>

Author: maliberty

src/gui/src/pythonCmdInputWidget.cpp

@@ -39,8 +39,11 @@
 #include "pythonCmdInputWidget.h"
 
 #include <QCoreApplication>
+#include <cstddef>
+#include <functional>
 #include <map>
 #include <memory>
+#include <string>
 
 #include "gui/gui.h"
 #include "ord/OpenRoad.hh"
@@ -51,21 +54,21 @@ namespace gui {
 // https://stackoverflow.com/questions/4307187/how-to-catch-python-stdout-in-c-code/8335297#8335297
 namespace emb {
 
-typedef std::function<void(std::string)> stdout_write_type;
+using stdout_write_type = std::function<void(std::string)>;
 
 struct Stdout
 {
   PyObject_HEAD stdout_write_type write;
 };
 
-PyObject* Stdout_write(PyObject* self, PyObject* args)
+static PyObject* Stdout_write(PyObject* self, PyObject* args)
 {
   std::size_t written(0);
   Stdout* selfimpl = reinterpret_cast<Stdout*>(self);
   if (selfimpl->write) {
     char* data;
     if (!PyArg_ParseTuple(args, "s", &data)) {
-      return 0;
+      return nullptr;
     }
 
     std::string str(data);
@@ -75,56 +78,56 @@ PyObject* Stdout_write(PyObject* self, PyObject* args)
   return PyLong_FromSize_t(written);
 }
 
-PyObject* Stdout_flush(PyObject* self, PyObject* args)
+static PyObject* Stdout_flush(PyObject* self, PyObject* args)
 {
   // no-op
   return Py_BuildValue("");
 }
 
-PyMethodDef Stdout_methods[] = {
+static PyMethodDef Stdout_methods[] = {
     {"write", Stdout_write, METH_VARARGS, "sys.stdout.write"},
     {"flush", Stdout_flush, METH_VARARGS, "sys.stdout.flush"},
-    {0, 0, 0, 0}  // sentinel
+    {nullptr, nullptr, 0, nullptr}  // sentinel
 };
 
-PyTypeObject StdoutType = {
+static PyTypeObject StdoutType = {
     PyVarObject_HEAD_INIT(0, 0) "emb.StdoutType", /* tp_name */
     sizeof(Stdout),                               /* tp_basicsize */
     0,                                            /* tp_itemsize */
-    0,                                            /* tp_dealloc */
+    nullptr,                                      /* tp_dealloc */
     0,                                            /* tp_print */
-    0,                                            /* tp_getattr */
-    0,                                            /* tp_setattr */
-    0,                                            /* tp_reserved */
-    0,                                            /* tp_repr */
-    0,                                            /* tp_as_number */
-    0,                                            /* tp_as_sequence */
-    0,                                            /* tp_as_mapping */
-    0,                                            /* tp_hash  */
-    0,                                            /* tp_call */
-    0,                                            /* tp_str */
-    0,                                            /* tp_getattro */
-    0,                                            /* tp_setattro */
-    0,                                            /* tp_as_buffer */
+    nullptr,                                      /* tp_getattr */
+    nullptr,                                      /* tp_setattr */
+    nullptr,                                      /* tp_reserved */
+    nullptr,                                      /* tp_repr */
+    nullptr,                                      /* tp_as_number */
+    nullptr,                                      /* tp_as_sequence */
+    nullptr,                                      /* tp_as_mapping */
+    nullptr,                                      /* tp_hash  */
+    nullptr,                                      /* tp_call */
+    nullptr,                                      /* tp_str */
+    nullptr,                                      /* tp_getattro */
+    nullptr,                                      /* tp_setattro */
+    nullptr,                                      /* tp_as_buffer */
     Py_TPFLAGS_DEFAULT,                           /* tp_flags */
     "emb.Stdout objects",                         /* tp_doc */
-    0,                                            /* tp_traverse */
-    0,                                            /* tp_clear */
-    0,                                            /* tp_richcompare */
+    nullptr,                                      /* tp_traverse */
+    nullptr,                                      /* tp_clear */
+    nullptr,                                      /* tp_richcompare */
     0,                                            /* tp_weaklistoffset */
-    0,                                            /* tp_iter */
-    0,                                            /* tp_iternext */
+    nullptr,                                      /* tp_iter */
+    nullptr,                                      /* tp_iternext */
     Stdout_methods,                               /* tp_methods */
-    0,                                            /* tp_members */
-    0,                                            /* tp_getset */
-    0,                                            /* tp_base */
-    0,                                            /* tp_dict */
-    0,                                            /* tp_descr_get */
-    0,                                            /* tp_descr_set */
+    nullptr,                                      /* tp_members */
+    nullptr,                                      /* tp_getset */
+    nullptr,                                      /* tp_base */
+    nullptr,                                      /* tp_dict */
+    nullptr,                                      /* tp_descr_get */
+    nullptr,                                      /* tp_descr_set */
     0,                                            /* tp_dictoffset */
-    0,                                            /* tp_init */
-    0,                                            /* tp_alloc */
-    0,                                            /* tp_new */
+    nullptr,                                      /* tp_init */
+    nullptr,                                      /* tp_alloc */
+    nullptr,                                      /* tp_new */
 };
 
 PyModuleDef embmodule = {
@@ -146,8 +149,9 @@ std::map<std::string, StreamPair> streams;
 PyMODINIT_FUNC PyInit_emb(void)
 {
   StdoutType.tp_new = PyType_GenericNew;
-  if (PyType_Ready(&StdoutType) < 0)
+  if (PyType_Ready(&StdoutType) < 0) {
     return 0;
+  }
 
   PyObject* m = PyModule_Create(&embmodule);
   if (m) {