Merge branch 'master' into resizer_determinism

Author: maliberty

.bazelversion

@@ -1 +1 @@
-8.3.1
+8.5.0

.github/workflows/github-actions-clang-tidy.yml

@@ -21,7 +21,7 @@ jobs:
           build_dir: "./build"
           cmake_command: cmake . -B build
           config_file: ".clang-tidy"
-          exclude: "*/codeGenerator/templates/*,*/third-party/*"
+          exclude: "*/codeGenerator/templates/*,third-party/*,test/orfs/*"
           split_workflow: true
           apt_packages: libomp-15-dev,libfl-dev,libyaml-cpp-dev
       - uses: The-OpenROAD-Project/clang-tidy-review/upload@master

MODULE.bazel

@@ -18,24 +18,8 @@ git_override(
     remote = "https://github.com/bazelbuild/rules_scala",
 )
 
-bazel_dep(name = "rules_verilator", version = "5.034")
-single_version_override(
-    module_name = "rules_verilator",
-    registry = "https://raw.githubusercontent.com/Pinata-Consulting/ascenium-registry/683f93e670a04f8d3d47316c42d197d8ac095a00/",
-    version = "5.034",
-)
-
-single_version_override(
-    module_name = "verilator",
-    registry = "https://raw.githubusercontent.com/Pinata-Consulting/ascenium-registry/683f93e670a04f8d3d47316c42d197d8ac095a00/",
-    version = "5.034.ar.1",
-)
-
-single_version_override(
-    module_name = "systemc",
-    registry = "https://raw.githubusercontent.com/Pinata-Consulting/ascenium-registry/683f93e670a04f8d3d47316c42d197d8ac095a00/",
-    version = "3.0.1",
-)
+bazel_dep(name = "rules_verilator", version = "0.1.0")
+bazel_dep(name = "verilator", version = "5.036.bcr.3")
 
 # Not all boost libs are available at the latest version yet, so use a
 # slightly older one that has all we need.
@@ -162,7 +146,7 @@ bazel_dep(name = "bazel-orfs")
 # To bump version, run: bazelisk run @bazel-orfs//:bump
 git_override(
     module_name = "bazel-orfs",
-    commit = "06be7f48c85f3e66e4a79205a68ae2170be88273",
+    commit = "287262398210ecc368e8cee1fbefddb02ac2e2f3",
     remote = "https://github.com/The-OpenROAD-Project/bazel-orfs.git",
 )
 
@@ -171,10 +155,10 @@ orfs = use_extension("@bazel-orfs//:extension.bzl", "orfs_repositories")
 # To bump version, run: bazelisk run @bazel-orfs//:bump
 orfs.default(
     # Official image https://hub.docker.com/r/openroad/orfs/tags
-    image = "docker.io/openroad/orfs:v3.0-4230-g26b521c49",
+    image = "docker.io/openroad/orfs:v3.0-4350-g4e47ad013",
     # Use OpenROAD of this repo instead of from the docker image
     openroad = "//:openroad",
-    sha256 = "8fc7ac130828053d7f0a9ad93ae8e3a74e9b24be6e76f9900f809ff93a80d005",
+    sha256 = "2e09979b7ab7f8e797b50ad8baec1e26d66205ea5bd6ec1b4ddfc7b4e924eb2b",
 )
 use_repo(orfs, "com_github_nixos_patchelf_download")
 use_repo(orfs, "docker_orfs")

MODULE.bazel.lock

@@ -225,6 +225,7 @@ class OpenRoad
   void read3Dbv(const std::string& filename);
   void read3Dbx(const std::string& filename);
   void write3Dbv(const std::string& filename);
+  void write3Dbx(const std::string& filename);
   void read3DBloxBMap(const std::string& filename);
 
   void readDb(std::istream& stream);

include/ord/OpenRoad.hh

@@ -495,6 +495,7 @@ void OpenRoad::read3Dbx(const std::string& filename)
 {
   odb::ThreeDBlox parser(logger_, db_, sta_);
   parser.readDbx(filename);
+  parser.check();
 }
 
 void OpenRoad::read3DBloxBMap(const std::string& filename)
@@ -507,6 +508,11 @@ void OpenRoad::write3Dbv(const std::string& filename)
   odb::ThreeDBlox writer(logger_, db_, sta_);
   writer.writeDbv(filename, db_->getChip());
 }
+void OpenRoad::write3Dbx(const std::string& filename)
+{
+  odb::ThreeDBlox writer(logger_, db_, sta_);
+  writer.writeDbx(filename, db_->getChip());
+}
 void OpenRoad::readDb(const char* filename, bool hierarchy)
 {
   try {

src/OpenRoad.cc

@@ -383,6 +383,13 @@ write_3dbv_cmd(const char *filename)
   ord->write3Dbv(filename);
 }
 
+void
+write_3dbx_cmd(const char *filename)
+{
+  OpenRoad *ord = getOpenRoad();
+  ord->write3Dbx(filename);
+}
+
 void
 read_db_cmd(const char *filename, bool hierarchy)
 {

src/OpenRoad.i

@@ -191,6 +191,13 @@ proc write_3dbv { args } {
   ord::write_3dbv_cmd $filename
 }
 
+proc write_3dbx { args } {
+  sta::parse_key_args "write_3dbx" args keys {} flags {}
+  sta::check_argc_eq1 "write_3dbx" $args
+  set filename [file nativename [lindex $args 0]]
+  ord::write_3dbx_cmd $filename
+}
+
 sta::define_cmd_args "read_3dbx" {filename}
 
 proc read_3dbx { args } {
@@ -423,7 +430,7 @@ proc place_inst { args } {
   }
 
   if { [info exists keys(-name)] } {
-    set inst_name [lindex $keys(-name) 0]
+    set inst_name $keys(-name)
   } else {
     utl::error ORD 57 "-name is a required argument to the place_cell command."
   }

src/OpenRoad.tcl

@@ -13,6 +13,7 @@
 #include <vector>
 
 #include "odb/db.h"
+#include "odb/geom.h"
 
 namespace utl {
 class Logger;
@@ -39,7 +40,8 @@ class Pin;
 
 namespace stt {
 class SteinerTreeBuilder;
-}
+struct Tree;
+}  // namespace stt
 
 namespace cts {
 
@@ -125,6 +127,11 @@ class TritonCTS
   void incrementNumClocks() { ++numberOfClocks_; }
   void clearNumClocks() { numberOfClocks_ = 0; }
   unsigned getNumClocks() const { return numberOfClocks_; }
+  void cloneClockGaters(odb::dbNet* clkNet);
+  void findLongEdges(
+      stt::Tree& clkSteiner,
+      odb::Point driverPt,
+      std::map<odb::Point, std::vector<odb::dbITerm*>>& point2pin);
   void initOneClockTree(odb::dbNet* driverNet,
                         odb::dbNet* clkInputNet,
                         const std::string& sdcClockName,