odb/rcx: clang-tidy

maliberty · maliberty · commit a8dfc4acbd58 · 2025-11-30T08:21:14.000Z
Signed-off-by: Matt Liberty &lt;mliberty@precisioninno.com&gt;
diff --git a/src/odb/include/odb/dbSet.h b/src/odb/include/odb/dbSet.h
@@ -7,6 +7,7 @@
 #include <iterator>
 
 #include "odb/dbIterator.h"
+#include "odb/odb.h"
 
 namespace odb {
 
diff --git a/src/odb/src/codeGenerator/templates/itr.cpp b/src/odb/src/codeGenerator/templates/itr.cpp
@@ -6,6 +6,7 @@
 #include "{{itr.parentObject}}.h"
 #include "dbTable.h"
 #include "dbTable.hpp"
+#include "odb/odb.h"
 {% for include in itr.includes %}
   #include "{{include}}"
 {% endfor %}
diff --git a/src/odb/src/db/dbBlockItr.cpp b/src/odb/src/db/dbBlockItr.cpp
@@ -10,6 +10,7 @@
 #include "dbTable.h"
 #include "dbTable.hpp"
 #include "odb/dbObject.h"
+#include "odb/odb.h"
 
 namespace odb {
 
diff --git a/src/odb/src/db/dbChipBumpInstItr.cpp b/src/odb/src/db/dbChipBumpInstItr.cpp
@@ -8,6 +8,7 @@
 #include "dbChipRegionInst.h"
 #include "dbTable.h"
 #include "dbTable.hpp"
+#include "odb/odb.h"
 
 namespace odb {
 
diff --git a/src/odb/src/db/dbChipConnItr.cpp b/src/odb/src/db/dbChipConnItr.cpp
@@ -8,6 +8,7 @@
 #include "dbChipConn.h"
 #include "dbTable.h"
 #include "dbTable.hpp"
+#include "odb/odb.h"
 
 namespace odb {
 
diff --git a/src/odb/src/db/dbChipInstItr.cpp b/src/odb/src/db/dbChipInstItr.cpp
@@ -8,6 +8,7 @@
 #include "dbChipInst.h"
 #include "dbTable.h"
 #include "dbTable.hpp"
+#include "odb/odb.h"
 
 namespace odb {
 
diff --git a/src/odb/src/db/dbChipNetItr.cpp b/src/odb/src/db/dbChipNetItr.cpp
@@ -8,6 +8,7 @@
 #include "dbChipNet.h"
 #include "dbTable.h"
 #include "dbTable.hpp"
+#include "odb/odb.h"
 
 namespace odb {
 
diff --git a/src/odb/src/db/dbChipRegionInstItr.cpp b/src/odb/src/db/dbChipRegionInstItr.cpp
@@ -9,6 +9,7 @@
 #include "dbChipRegionInst.h"
 #include "dbTable.h"
 #include "dbTable.hpp"
+#include "odb/odb.h"
 
 namespace odb {
 
diff --git a/src/odb/src/db/dbGCellGrid.cpp b/src/odb/src/db/dbGCellGrid.cpp
@@ -16,6 +16,7 @@
 #include "odb/db.h"
 // User Code Begin Includes
 #include <algorithm>
+#include <cassert>
 
 #include "dbBlock.h"
 #include "dbTech.h"
diff --git a/src/odb/src/db/dbGroupGroundNetItr.cpp b/src/odb/src/db/dbGroupGroundNetItr.cpp
@@ -12,6 +12,7 @@
 #include "dbTable.h"
 #include "dbTable.hpp"
 #include "odb/dbObject.h"
+#include "odb/odb.h"
 
 namespace odb {
 
diff --git a/src/odb/src/db/dbGroupInstItr.cpp b/src/odb/src/db/dbGroupInstItr.cpp
@@ -8,6 +8,7 @@
 #include "dbInst.h"
 #include "dbTable.h"
 #include "dbTable.hpp"
+#include "odb/odb.h"
 
 namespace odb {
 
diff --git a/src/odb/src/db/dbGroupItr.cpp b/src/odb/src/db/dbGroupItr.cpp
@@ -7,6 +7,7 @@
 #include "dbGroup.h"
 #include "dbTable.h"
 #include "dbTable.hpp"
+#include "odb/odb.h"
 // User Code Begin Includes
 #include "dbModule.h"
 // User Code End Includes
diff --git a/src/odb/src/db/dbGroupModInstItr.cpp b/src/odb/src/db/dbGroupModInstItr.cpp
@@ -8,6 +8,7 @@
 #include "dbModInst.h"
 #include "dbTable.h"
 #include "dbTable.hpp"
+#include "odb/odb.h"
 
 namespace odb {
 
diff --git a/src/odb/src/db/dbGroupPowerNetItr.cpp b/src/odb/src/db/dbGroupPowerNetItr.cpp
@@ -11,6 +11,7 @@
 #include "dbNet.h"
 #include "dbTable.h"
 #include "odb/dbObject.h"
+#include "odb/odb.h"
 
 namespace odb {
 
diff --git a/src/odb/src/db/dbGuideItr.cpp b/src/odb/src/db/dbGuideItr.cpp
@@ -7,6 +7,7 @@
 #include "dbGuide.h"
 #include "dbTable.h"
 #include "dbTable.hpp"
+#include "odb/odb.h"
 // User Code Begin Includes
 #include "dbNet.h"
 // User Code End Includes
diff --git a/src/odb/src/db/dbModuleBusPortModBTermItr.cpp b/src/odb/src/db/dbModuleBusPortModBTermItr.cpp
@@ -9,6 +9,7 @@
 #include "dbModule.h"
 #include "dbTable.h"
 #include "dbTable.hpp"
+#include "odb/odb.h"
 
 namespace odb {
 
diff --git a/src/odb/src/db/dbModuleInstItr.cpp b/src/odb/src/db/dbModuleInstItr.cpp
@@ -8,6 +8,7 @@
 #include "dbModule.h"
 #include "dbTable.h"
 #include "dbTable.hpp"
+#include "odb/odb.h"
 
 namespace odb {
 
diff --git a/src/odb/src/db/dbModuleModBTermItr.cpp b/src/odb/src/db/dbModuleModBTermItr.cpp
@@ -9,6 +9,7 @@
 #include "dbModule.h"
 #include "dbTable.h"
 #include "dbTable.hpp"
+#include "odb/odb.h"
 
 namespace odb {
 
diff --git a/src/odb/src/db/dbModuleModInstItr.cpp b/src/odb/src/db/dbModuleModInstItr.cpp
@@ -8,6 +8,7 @@
 #include "dbModule.h"
 #include "dbTable.h"
 #include "dbTable.hpp"
+#include "odb/odb.h"
 
 namespace odb {
 
diff --git a/src/odb/src/db/dbModuleModInstModITermItr.cpp b/src/odb/src/db/dbModuleModInstModITermItr.cpp
@@ -9,6 +9,7 @@
 #include "dbModule.h"
 #include "dbTable.h"
 #include "dbTable.hpp"
+#include "odb/odb.h"
 
 namespace odb {
 
diff --git a/src/odb/src/db/dbModuleModNetBTermItr.cpp b/src/odb/src/db/dbModuleModNetBTermItr.cpp
@@ -9,6 +9,7 @@
 #include "dbModule.h"
 #include "dbTable.h"
 #include "dbTable.hpp"
+#include "odb/odb.h"
 
 namespace odb {
 
diff --git a/src/odb/src/db/dbModuleModNetITermItr.cpp b/src/odb/src/db/dbModuleModNetITermItr.cpp
@@ -9,6 +9,7 @@
 #include "dbModule.h"
 #include "dbTable.h"
 #include "dbTable.hpp"
+#include "odb/odb.h"
 
 namespace odb {
 
diff --git a/src/odb/src/db/dbModuleModNetItr.cpp b/src/odb/src/db/dbModuleModNetItr.cpp
@@ -8,6 +8,7 @@
 #include "dbModule.h"
 #include "dbTable.h"
 #include "dbTable.hpp"
+#include "odb/odb.h"
 
 namespace odb {
 
diff --git a/src/odb/src/db/dbModuleModNetModBTermItr.cpp b/src/odb/src/db/dbModuleModNetModBTermItr.cpp
@@ -9,6 +9,7 @@
 #include "dbModule.h"
 #include "dbTable.h"
 #include "dbTable.hpp"
+#include "odb/odb.h"
 
 namespace odb {
 
diff --git a/src/odb/src/db/dbModuleModNetModITermItr.cpp b/src/odb/src/db/dbModuleModNetModITermItr.cpp
@@ -9,6 +9,7 @@
 #include "dbModule.h"
 #include "dbTable.h"
 #include "dbTable.hpp"
+#include "odb/odb.h"
 
 namespace odb {
 
diff --git a/src/odb/src/db/dbModulePortItr.cpp b/src/odb/src/db/dbModulePortItr.cpp
@@ -10,6 +10,7 @@
 #include "dbModule.h"
 #include "dbTable.h"
 #include "dbTable.hpp"
+#include "odb/odb.h"
 
 namespace odb {
 
diff --git a/src/odb/src/db/dbNetTrackItr.cpp b/src/odb/src/db/dbNetTrackItr.cpp
@@ -7,6 +7,7 @@
 #include "dbNetTrack.h"
 #include "dbTable.h"
 #include "dbTable.hpp"
+#include "odb/odb.h"
 // User Code Begin Includes
 #include "dbNet.h"
 // User Code End Includes
diff --git a/src/odb/src/db/dbNullIterator.cpp b/src/odb/src/db/dbNullIterator.cpp
@@ -3,6 +3,8 @@
 
 #include "dbNullIterator.h"
 
+#include "odb/odb.h"
+
 namespace odb {
 
 dbNullIterator dbNullIterator::null_iterator;
diff --git a/src/odb/src/db/dbRegionGroupItr.cpp b/src/odb/src/db/dbRegionGroupItr.cpp
@@ -7,6 +7,7 @@
 #include "dbGroup.h"
 #include "dbTable.h"
 #include "dbTable.hpp"
+#include "odb/odb.h"
 // User Code Begin Includes
 #include "dbRegion.h"
 // User Code End Includes
diff --git a/src/odb/src/db/dbScanListScanInstItr.cpp b/src/odb/src/db/dbScanListScanInstItr.cpp
@@ -8,6 +8,7 @@
 #include "dbScanList.h"
 #include "dbTable.h"
 #include "dbTable.hpp"
+#include "odb/odb.h"
 
 namespace odb {
 
diff --git a/src/odb/src/db/dbTechLayerItr.cpp b/src/odb/src/db/dbTechLayerItr.cpp
@@ -7,6 +7,7 @@
 #include "dbTech.h"
 #include "dbTechLayer.h"
 #include "odb/dbObject.h"
+#include "odb/odb.h"
 
 namespace odb {
 
diff --git a/src/rcx/BUILD b/src/rcx/BUILD
@@ -83,7 +83,6 @@ cc_library(
         "include/rcx/ext_options.h",
         "include/rcx/extprocess.h",
         "include/rcx/grids.h",
-        "include/rcx/name.h",
         "include/rcx/rcx.h",
         "include/rcx/util.h",
     ],
diff --git a/src/rcx/include/rcx/grids.h b/src/rcx/include/rcx/grids.h
@@ -10,11 +10,11 @@
 
 #include "odb/db.h"
 #include "odb/geom.h"
-#include "odb/util.h"
 #include "rcx/array1.h"
 #include "rcx/box.h"
 #include "rcx/extRCap.h"
 #include "rcx/rcx.h"
+#include "rcx/util.h"
 
 namespace rcx {
 
diff --git a/src/rcx/include/rcx/name.h b/src/rcx/include/rcx/name.h
diff --git a/src/rcx/include/rcx/util.h b/src/rcx/include/rcx/util.h
@@ -5,6 +5,7 @@
 
 #include <string.h>
 
+#include <algorithm>
 #include <cassert>
 #include <cstdlib>
 #include <cstring>
@@ -20,9 +21,7 @@ class AthArray
  public:
   AthArray(int alloc_size = 128)
   {
-    if (alloc_size < 2) {
-      alloc_size = 2;
-    }
+    alloc_size = std::max(alloc_size, 2);
     m_alloc_size_ = alloc_size;
     m_num_mallocated_first_level_ = alloc_size;
     m_ptr_ = (T**) malloc(sizeof(T*) * m_num_mallocated_first_level_);
diff --git a/src/rcx/src/dbUtil.cpp b/src/rcx/src/dbUtil.cpp
@@ -16,7 +16,6 @@
 #include "odb/dbTypes.h"
 #include "odb/dbWireCodec.h"
 #include "odb/geom.h"
-#include "rcx/array1.h"
 #include "utl/Logger.h"
 
 using odb::dbBPin;
diff --git a/src/rcx/src/extBenchDB.cpp b/src/rcx/src/extBenchDB.cpp
@@ -13,13 +13,13 @@
 #include "odb/db.h"
 #include "odb/dbSet.h"
 #include "odb/dbTypes.h"
-#include "odb/util.h"
 #include "parse.h"
 #include "rcx/array1.h"
 #include "rcx/extRCap.h"
 #include "rcx/extSpef.h"
 #include "rcx/extViaModel.h"
 #include "rcx/extprocess.h"
+#include "rcx/util.h"
 #include "utl/Logger.h"
 
 using odb::dbBTerm;
diff --git a/src/rcx/src/extCC.cpp b/src/rcx/src/extCC.cpp
diff --git a/src/rcx/src/extFlow_v2.cpp b/src/rcx/src/extFlow_v2.cpp
diff --git a/src/rcx/src/extModelGen.cpp b/src/rcx/src/extModelGen.cpp
diff --git a/src/rcx/src/extRCmodel.cpp b/src/rcx/src/extRCmodel.cpp
diff --git a/src/rcx/src/extRCmodel_solver.cpp b/src/rcx/src/extRCmodel_solver.cpp
diff --git a/src/rcx/src/grids.cpp b/src/rcx/src/grids.cpp
diff --git a/src/rcx/src/gs.cpp b/src/rcx/src/gs.cpp
diff --git a/src/rcx/src/name.cpp b/src/rcx/src/name.cpp
diff --git a/src/rcx/src/name.h b/src/rcx/src/name.h
