fix modernize-use-default-member-init

maliberty · maliberty · commit a9e24ed6a809 · 2025-12-27T22:20:41.000Z
Signed-off-by: Matt Liberty &lt;mliberty@precisioninno.com&gt;
diff --git a/src/cts/src/LatencyBalancer.h b/src/cts/src/LatencyBalancer.h
@@ -67,8 +67,7 @@ class LatencyBalancer
         openSta_(sta),
         wireSegmentUnit_(scalingUnit),
         capPerDBU_(capPerDBU),
-        worseDelay_(std::numeric_limits<float>::min()),
-        delayBufIndex_(0)
+        worseDelay_(std::numeric_limits<float>::min())
   {
   }
 
@@ -120,9 +119,9 @@ class LatencyBalancer
   float bufferDelay_;
   double capPerDBU_;
   float worseDelay_;
-  int delayBufIndex_;
+  int delayBufIndex_{0};
   std::vector<GraphNode> graph_;
   std::map<std::string, TreeBuilder*> inst2builder_;
 };
 
-}  // namespace cts
+}  // namespace cts
diff --git a/src/drt/src/db/drObj/drShape.cpp b/src/drt/src/db/drObj/drShape.cpp
@@ -40,7 +40,7 @@ drPathSeg::drPathSeg(const frPathSeg& in) : layer_(in.getLayerNum())
 }
 
 drPatchWire::drPatchWire(const frPatchWire& in)
-    : layer_(in.getLayerNum()), owner_(nullptr)
+    : layer_(in.getLayerNum())
 {
   offsetBox_ = in.getOffsetBox();
   origin_ = in.getOrigin();
diff --git a/src/drt/src/db/tech/frConstraint.h b/src/drt/src/db/tech/frConstraint.h
@@ -2232,7 +2232,7 @@ class frLef58EnclosureConstraint : public frConstraint
 {
  public:
   frLef58EnclosureConstraint(odb::dbTechLayerCutEnclosureRule* ruleIn)
-      : db_rule_(ruleIn), cut_class_idx_(-1)
+      : db_rule_(ruleIn)
   {
   }
   void setCutClassIdx(int in) { cut_class_idx_ = in; }
@@ -2270,7 +2270,7 @@ class frLef58EnclosureConstraint : public frConstraint
 
  private:
   odb::dbTechLayerCutEnclosureRule* db_rule_;
-  int cut_class_idx_;
+  int cut_class_idx_{-1};
 };
 
 // LEF58_MAXSPACING rule
diff --git a/src/drt/src/distributed/RoutingCallBack.h b/src/drt/src/distributed/RoutingCallBack.h
@@ -44,7 +44,6 @@ class RoutingCallBack : public dst::JobCallBack
       : router_(router),
         dist_(dist),
         logger_(logger),
-        init_(true),
         pa_(router->getDesign(),
             logger,
             nullptr,
@@ -241,7 +240,7 @@ class RoutingCallBack : public dst::JobCallBack
   utl::Logger* logger_;
   std::string design_path_;
   std::string router_cfg_path_;
-  bool init_;
+  bool init_{true};
   FlexDRViaData via_data_;
   FlexPA pa_;
 };
diff --git a/src/drt/src/distributed/frArchive.h b/src/drt/src/distributed/frArchive.h
@@ -37,10 +37,7 @@ struct frOArchive : OutputArchive
 
 struct frIArchive : InputArchive
 {
-  frIArchive(std::istream& os, unsigned flags = 0)
-      : InputArchive(os, flags), design_(nullptr)
-  {
-  }
+  frIArchive(std::istream& os, unsigned flags = 0) : InputArchive(os, flags) {}
 
   // forward to base class
   template <class T>
@@ -52,7 +49,7 @@ struct frIArchive : InputArchive
   void setDesign(frDesign* in) { design_ = in; }
 
  private:
-  frDesign* design_;
+  frDesign* design_{nullptr};
 };
 }  // namespace drt
 
diff --git a/src/drt/src/gr/FlexGR.h b/src/drt/src/gr/FlexGR.h
@@ -39,10 +39,7 @@ class FlexGR
          utl::Logger* logger,
          stt::SteinerTreeBuilder* stt_builder,
          RouterConfiguration* router_cfg)
-      : db_(nullptr),
-        design_(designIn),
-        cmap_(nullptr),
-        cmap2D_(nullptr),
+      : design_(designIn),
         logger_(logger),
         stt_builder_(stt_builder),
         router_cfg_(router_cfg)
@@ -65,7 +62,7 @@ class FlexGR
   void main(odb::dbDatabase* db = nullptr);
 
  private:
-  odb::dbDatabase* db_;
+  odb::dbDatabase* db_{nullptr};
   frDesign* design_;
   std::unique_ptr<FlexGRCMap> cmap_;
   std::unique_ptr<FlexGRCMap> cmap2D_;
diff --git a/src/drt/src/ta/FlexTA.h b/src/drt/src/ta/FlexTA.h
@@ -116,12 +116,7 @@ class FlexTAWorker
         router_cfg_(router_cfg),
         save_updates_(save_updates),
         dir_(odb::dbTechLayerDir::NONE),
-        taIter_(0),
-        rq_(this),
-        numAssigned_(0),
-        totCost_(0),
-        maxRetry_(1),
-        hardIroutesMode_(false)
+        rq_(this)
   {
   }
   // setters
@@ -197,18 +192,18 @@ class FlexTAWorker
   odb::Rect routeBox_;
   odb::Rect extBox_;
   odb::dbTechLayerDir dir_;
-  int taIter_;
+  int taIter_{0};
   FlexTAWorkerRegionQuery rq_;
 
   std::vector<std::unique_ptr<taPin>> iroutes_;  // unsorted iroutes
   std::vector<std::unique_ptr<taPin>> extIroutes_;
   std::vector<std::vector<frCoord>> trackLocs_;
   std::set<taPin*, taPinComp>
       reassignIroutes_;  // iroutes to be assigned in sorted order
-  int numAssigned_;
-  int totCost_;
-  int maxRetry_;
-  bool hardIroutesMode_;
+  int numAssigned_{0};
+  int totCost_{0};
+  int maxRetry_{1};
+  bool hardIroutesMode_{false};
 
   //// others
   void init();
diff --git a/src/dst/include/dst/BalancerJobDescription.h b/src/dst/include/dst/BalancerJobDescription.h
@@ -14,15 +14,14 @@ namespace dst {
 class BalancerJobDescription : public JobDescription
 {
  public:
-  BalancerJobDescription() : worker_port_(0) {}
   void setWorkerIP(const std::string& ip) { worker_ip_ = ip; }
   void setWorkerPort(unsigned short port) { worker_port_ = port; }
   std::string getWorkerIP() const { return worker_ip_; }
   unsigned short getWorkerPort() const { return worker_port_; }
 
  private:
   std::string worker_ip_;
-  unsigned short worker_port_;
+  unsigned short worker_port_{0};
 
   template <class Archive>
   void serialize(Archive& ar, const unsigned int version)
diff --git a/src/dst/include/dst/BroadcastJobDescription.h b/src/dst/include/dst/BroadcastJobDescription.h
@@ -12,12 +12,11 @@ namespace dst {
 class BroadcastJobDescription : public JobDescription
 {
  public:
-  BroadcastJobDescription() : workers_count_(0) {}
   void setWorkersCount(unsigned short count) { workers_count_ = count; }
   unsigned short getWorkersCount() const { return workers_count_; }
 
  private:
-  unsigned short workers_count_;
+  unsigned short workers_count_{0};
 
   template <class Archive>
   void serialize(Archive& ar, const unsigned int version)
diff --git a/src/dst/test/cpp/stubs.cpp b/src/dst/test/cpp/stubs.cpp
@@ -33,33 +33,7 @@
 
 namespace ord {
 
-OpenRoad::OpenRoad()
-    : tcl_interp_(nullptr),
-      logger_(nullptr),
-      db_(nullptr),
-      verilog_network_(nullptr),
-      sta_(nullptr),
-      resizer_(nullptr),
-      ioPlacer_(nullptr),
-      opendp_(nullptr),
-      finale_(nullptr),
-      macro_placer_(nullptr),
-      global_router_(nullptr),
-      restructure_(nullptr),
-      tritonCts_(nullptr),
-      tapcell_(nullptr),
-      extractor_(nullptr),
-      detailed_router_(nullptr),
-      antenna_checker_(nullptr),
-      replace_(nullptr),
-      pdnsim_(nullptr),
-      partitionMgr_(nullptr),
-      pdngen_(nullptr),
-      distributer_(nullptr),
-      stt_builder_(nullptr),
-      threads_(0)
-{
-}
+OpenRoad::OpenRoad() = default;
 
 OpenRoad* OpenRoad::openRoad()
 {
diff --git a/src/grt/src/fastroute/include/DataType.h b/src/grt/src/fastroute/include/DataType.h
@@ -60,18 +60,15 @@ struct Segment  // A Segment is a 2-pin connection
         y1(y1),
         x2(x2),
         y2(y2),
-        Zpoint(-1),
-        cost(cost),
-        xFirst(false),
-        HVH(false)
+        cost(cost)
   {
   }
   const int netID;
   const int16_t x1, y1, x2, y2;  // coordinates of two endpoints (x1 <= x2)
-  int16_t Zpoint;     // The coordinates of Z point (x for HVH and y for VHV)
+  int16_t Zpoint{-1};     // The coordinates of Z point (x for HVH and y for VHV)
   const int8_t cost;  // the netID of the net this segment belonging to
-  bool xFirst : 1;    // route x-direction first (only for L route)
-  bool HVH : 1;       // TRUE = HVH or false = VHV (only for Z route)
+  bool xFirst : 1{false};    // route x-direction first (only for L route)
+  bool HVH : 1{false};       // TRUE = HVH or false = VHV (only for Z route)
 };
 
 struct FrNet  // A Net is a set of connected MazePoints
diff --git a/src/gui/src/staGui.h b/src/gui/src/staGui.h
@@ -277,10 +277,7 @@ class GuiDBChangeListener : public QObject, public odb::dbBlockCallBackObj
 {
   Q_OBJECT
  public:
-  GuiDBChangeListener(QObject* parent = nullptr)
-      : QObject(parent), is_modified_(false)
-  {
-  }
+  GuiDBChangeListener(QObject* parent = nullptr) : QObject(parent) {}
 
   void inDbInstCreate(odb::dbInst* /* inst */) override { callback(); }
   void inDbInstDestroy(odb::dbInst* /* inst */) override { callback(); }
@@ -327,7 +324,7 @@ class GuiDBChangeListener : public QObject, public odb::dbBlockCallBackObj
     }
   }
 
-  bool is_modified_;
+  bool is_modified_{false};
 };
 
 class PinSetWidget : public QWidget
diff --git a/src/gui/src/staGuiInterface.h b/src/gui/src/staGuiInterface.h
@@ -66,10 +66,8 @@ class TimingPathNode
         delay_(delay),
         slew_(slew),
         load_(load),
-        path_slack_(0.0),
         fanout_(fanout),
-        paired_nodes_({}),
-        instance_node_(nullptr)
+        paired_nodes_({})
   {
   }
 
@@ -136,11 +134,11 @@ class TimingPathNode
   float delay_;
   float slew_;
   float load_;
-  float path_slack_;
+  float path_slack_{0.0};
   int fanout_;
 
   std::set<const TimingPathNode*> paired_nodes_;
-  const TimingPathNode* instance_node_;
+  const TimingPathNode* instance_node_{nullptr};
 };
 
 class TimingPath
diff --git a/src/odb/src/lef/lef/lefiViaRule.cpp b/src/odb/src/lef/lef/lefiViaRule.cpp
@@ -43,22 +43,6 @@ BEGIN_LEF_PARSER_NAMESPACE
 // lefiViaRuleLayer
 // *****************************************************************************
 
-lefiViaRuleLayer::lefiViaRuleLayer()
-    : widthMin_(0.0),
-      widthMax_(0.0),
-      overhang_(0.0),
-      metalOverhang_(0.0),
-      resistance_(0.0),
-      spacingStepX_(0.0),
-      spacingStepY_(0.0),
-      xl_(0.0),
-      yl_(0.0),
-      xh_(0.0),
-      yh_(0.0)
-{
-  Init();
-}
-
 void lefiViaRuleLayer::Init()
 {
   name_ = nullptr;
diff --git a/src/odb/src/lef/lef/lefiViaRule.hpp b/src/odb/src/lef/lef/lefiViaRule.hpp
@@ -39,7 +39,6 @@ BEGIN_LEF_PARSER_NAMESPACE
 class lefiViaRuleLayer
 {
  public:
-  lefiViaRuleLayer();
   void Init();
 
   void Destroy();
@@ -89,8 +88,8 @@ class lefiViaRuleLayer
  protected:
   char* name_{nullptr};
   char direction_{0};
-  double overhang1_{0.0};  // 5.5
-  double overhang2_{0.0};  // 5.5
+  double overhang1_{-1};  // 5.5
+  double overhang2_{-1};  // 5.5
   int hasWidth_{0};
   int hasResistance_{0};
   int hasOverhang_{0};
diff --git a/src/rcx/include/rcx/extMeasureRC.h b/src/rcx/include/rcx/extMeasureRC.h
@@ -20,19 +20,10 @@ namespace rcx {
 struct CouplingState
 {
   // Processing counters
-  uint32_t wire_count;         // Total wires processed
-  uint32_t not_ordered_count;  // Count of non-ordered segments
-  uint32_t empty_table_count;  // Count of empty tables
-  uint32_t one_count_table;    // Count of single-entry tables
-
-  // Constructor initializes all counters to 0
-  CouplingState()
-      : wire_count(0),
-        not_ordered_count(0),
-        empty_table_count(0),
-        one_count_table(0)
-  {
-  }
+  uint32_t wire_count{0};         // Total wires processed
+  uint32_t not_ordered_count{0};  // Count of non-ordered segments
+  uint32_t empty_table_count{0};  // Count of empty tables
+  uint32_t one_count_table{0};    // Count of single-entry tables
 
   // Reset all counters
   void reset()
@@ -57,40 +48,33 @@ struct CouplingState
 struct CouplingConfig
 {
   // Metal layer settings
-  const int metal_level_count;     // Number of metal layers
-  const int metal_flag;            // Metal layer control flag
-  const uint32_t limit_track_num;  // Track limit for neighbor search
+  const int metal_level_count;         // Number of metal layers
+  const int metal_flag;                // Metal layer control flag
+  const uint32_t limit_track_num{10};  // Track limit for neighbor search
 
   // Length settings
   static constexpr int LENGTH_BOUND
-      = 7000;        // Threshold for length-based calculations
-  bool length_flag;  // Whether to use length-based calculations
+      = 7000;               // Threshold for length-based calculations
+  bool length_flag{false};  // Whether to use length-based calculations
 
   // Calculation modes
-  bool new_calc_flow;   // Use new calculation flow
-  bool vertical_cap;    // Enable vertical capacitance calculation
-  bool diag_cap;        // Enable diagonal capacitance calculation
-  bool diag_cap_power;  // Enable power net diagonal capacitance
+  bool new_calc_flow{true};   // Use new calculation flow
+  bool vertical_cap{true};    // Enable vertical capacitance calculation
+  bool diag_cap{true};        // Enable diagonal capacitance calculation
+  bool diag_cap_power{true};  // Enable power net diagonal capacitance
 
   // Debug settings
   const bool debug_enabled;          // Main debug flag
   bool debug_overlaps;               // Enable overlap debugging
-  FILE* debug_fp;                    // Debug file pointer
+  FILE* debug_fp{nullptr};           // Debug file pointer
   const uint32_t progress_interval;  // Progress update interval
 
   // Constructor to initialize all settings
   CouplingConfig(extMain* ext_main, uint32_t levelCnt)
       : metal_level_count(levelCnt),
         metal_flag(ext_main->_metal_flag_22),
-        limit_track_num(10),
-        length_flag(false),
-        new_calc_flow(true),
-        vertical_cap(true),
-        diag_cap(true),
-        diag_cap_power(true),
         debug_enabled(ext_main->_dbgOption > 1),
         debug_overlaps(debug_enabled),
-        debug_fp(nullptr),
         progress_interval(ext_main->_wire_extracted_progress_count)
   {
   }

Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ drPathSeg::drPathSeg(const frPathSeg& in) : layer_(in.getLayerNum())`
`40`	`40`	`}`
`41`	`41`
`42`	`42`	`drPatchWire::drPatchWire(const frPatchWire& in)`
`43`		`- : layer_(in.getLayerNum()), owner_(nullptr)`
	`43`	`+ : layer_(in.getLayerNum())`
`44`	`44`	`{`
`45`	`45`	`offsetBox_ = in.getOffsetBox();`
`46`	`46`	`origin_ = in.getOrigin();`
Original file line number	Diff line number	Diff line change
`@@ -2232,7 +2232,7 @@ class frLef58EnclosureConstraint : public frConstraint`
`2232`	`2232`	`{`
`2233`	`2233`	`public:`
`2234`	`2234`	`frLef58EnclosureConstraint(odb::dbTechLayerCutEnclosureRule* ruleIn)`
`2235`		`- : db_rule_(ruleIn), cut_class_idx_(-1)`
	`2235`	`+ : db_rule_(ruleIn)`
`2236`	`2236`	`{`
`2237`	`2237`	`}`
`2238`	`2238`	`void setCutClassIdx(int in) { cut_class_idx_ = in; }`
`@@ -2270,7 +2270,7 @@ class frLef58EnclosureConstraint : public frConstraint`
`2270`	`2270`
`2271`	`2271`	`private:`
`2272`	`2272`	`odb::dbTechLayerCutEnclosureRule* db_rule_;`
`2273`		`- int cut_class_idx_;`
	`2273`	`+ int cut_class_idx_{-1};`
`2274`	`2274`	`};`
`2275`	`2275`
`2276`	`2276`	`// LEF58_MAXSPACING rule`