Removed assert from stub's gui::Gui::get(). Check that the stub is not being

used before creating a gpl::GraphicsImpl object.

Signed-off-by: Ted Hong <[email protected]>

Author: hongted

src/gpl/src/MakeReplace.cpp

@@ -5,6 +5,8 @@
 
 #include "gpl/Replace.h"
 #include "graphicsImpl.h"
+#include "graphicsNone.h"
+#include "gui/gui.h"
 #include "tcl.h"
 #include "utl/Logger.h"
 #include "utl/decode.h"
@@ -25,7 +27,11 @@ void initReplace(Tcl_Interp* tcl_interp)
 
 void initReplaceGraphics(Replace* replace, utl::Logger* log)
 {
-  replace->setGraphicsInterface(gpl::GraphicsImpl(log));
+  if (gui::Gui::get() == nullptr) {
+    replace->setGraphicsInterface(gpl::GraphicsNone());
+  } else {
+    replace->setGraphicsInterface(gpl::GraphicsImpl(log));
+  }
 }
 
 }  // namespace gpl

src/gpl/src/graphicsImpl.cpp

@@ -27,9 +27,7 @@ namespace gpl {
 GraphicsImpl::GraphicsImpl(utl::Logger* logger)
     : HeatMapDataSource(logger, "gpl", "gpl"), logger_(logger), mode_(Mbff)
 {
-  if (gui::Gui::enabled()) {
-    gui::Gui::get()->registerRenderer(this);
-  }
+  gui::Gui::get()->registerRenderer(this);
 }
 
 GraphicsImpl::~GraphicsImpl() = default;

src/gui/BUILD

@@ -30,7 +30,6 @@ cc_library(
     deps = [
         "//src/odb",
         "@boost.multi_array",
-        "@com_google_absl//absl/log:check",
         "@tk_tcl//:tcl",
     ],
 )

src/gui/src/stub.cpp

@@ -12,7 +12,6 @@
 #include <typeinfo>
 #include <vector>
 
-#include "absl/log/check.h"
 #include "gui/gui.h"
 #include "odb/db.h"
 #include "odb/geom.h"
@@ -53,9 +52,6 @@ Gui::Gui() : continue_after_close_(false), logger_(nullptr), db_(nullptr)
 
 Gui* gui::Gui::get()
 {
-  CHECK(enabled())
-      << "Internal Error: gui::Gui::get() called when enabled() is false";
-
   return nullptr;
 }