Merge pull request #8561 from AcKoucher/mpl-unused-variable

mpl: remove unused argument/variable for pin access

Author: eder-matheus

src/mpl/README.md

@@ -41,7 +41,6 @@ rtl_macro_placer
     [-boundary_weight boundary_weight]
     [-notch_weight notch_weight]
     [-macro_blockage_weight macro_blockage_weight]
-    [-pin_access_th pin_access_th]
     [-target_util target_util]
     [-target_dead_space target_dead_space]
     [-min_ar min_ar]
@@ -62,7 +61,6 @@ rtl_macro_placer
 | `-signature_net_threshold` | Minimum number of connections between two clusters to be identified as connected. The default value is `50`, and the allowed values are integers `[0, MAX_INT]`. |
 | `-halo_width` | Horizontal/vertical halo around macros (microns). The allowed values are floats, and the default value is `0.0`. |
 | `-fence_lx`, `-fence_ly`, `-fence_ux`, `-fence_uy` | Defines the global fence bounding box coordinates. The default values are the core area coordinates). |
-| `-pin_access_th` | Specifies the pin access threshold value of macros. The default value is `0.0`, and the allowed values are floats [0,1]. |
 | `-target_util` | Specifies the target utilization of `MixedCluster` and has higher priority than target_dead_space. The allowed values are floats, and the default value is `0.25`. |
 | `-target_dead_space` | Specifies the target dead space percentage, which influences the utilization of `StandardCellCluster`. The allowed values are floats, and the default value is `0.05`. |
 | `-min_ar` | Specifies the minimum aspect ratio $a$, or the ratio of its width to height of a `StandardCellCluster` from $[a, \frac{1}{a}]$. The allowed values are floats, and the default value is `0.33`. |

src/mpl/include/mpl/rtl_mp.h

@@ -66,7 +66,6 @@ class MacroPlacer
              float boundary_weight,
              float notch_weight,
              float macro_blockage_weight,
-             float pin_access_th,
              float target_util,
              float target_dead_space,
              float min_ar,

src/mpl/src/hier_rtlmp.cpp

@@ -161,12 +161,6 @@ void HierRTLMP::setSignatureNetThreshold(int signature_net_threshold)
   tree_->min_net_count_for_connection = signature_net_threshold;
 }
 
-void HierRTLMP::setPinAccessThreshold(float pin_access_th)
-{
-  pin_access_th_ = pin_access_th;
-  pin_access_th_orig_ = pin_access_th;
-}
-
 void HierRTLMP::setTargetUtil(float target_util)
 {
   target_util_ = target_util;

src/mpl/src/hier_rtlmp.h

@@ -101,7 +101,6 @@ class HierRTLMP
   void setBoundaryWeight(float boundary_weight);
   void setNotchWeight(float notch_weight);
   void setMacroBlockageWeight(float macro_blockage_weight);
-  void setPinAccessThreshold(float pin_access_th);
   void setTargetUtil(float target_util);
   void setTargetDeadSpace(float target_dead_space);
   void setMinAR(float min_ar);
@@ -273,8 +272,6 @@ class HierRTLMP
   float min_ar_ = 0.3;  // the aspect ratio range for StdCellCluster (min_ar_, 1
                         // / min_ar_)
 
-  float pin_access_th_ = 0.1;  // each pin access is modeled as a SoftMacro
-  float pin_access_th_orig_ = 0.1;
   float notch_v_th_ = 10.0;
   float notch_h_th_ = 10.0;
 

src/mpl/src/mpl.i

@@ -49,7 +49,6 @@ bool rtl_macro_placer_cmd(const int max_num_macro,
                           const float boundary_weight,
                           const float notch_weight,
                           const float macro_blockage_weight,
-                          const float pin_access_th,
                           const float target_util,
                           const float target_dead_space,
                           const float min_ar,
@@ -81,7 +80,6 @@ bool rtl_macro_placer_cmd(const int max_num_macro,
                              boundary_weight,
                              notch_weight,
                              macro_blockage_weight,
-                             pin_access_th,
                              target_util,
                              target_dead_space,
                              min_ar,

src/mpl/src/mpl.tcl

@@ -24,7 +24,6 @@ sta::define_cmd_args "rtl_macro_placer" { -max_num_macro  max_num_macro \
                                           -boundary_weight boundary_weight \
                                           -notch_weight notch_weight \
                                           -macro_blockage_weight macro_blockage_weight \
-                                          -pin_access_th pin_access_th \
                                           -target_util   target_util \
                                           -target_dead_space target_dead_space \
                                           -min_ar  min_ar \
@@ -38,8 +37,8 @@ proc rtl_macro_placer { args } {
          -signature_net_threshold -halo_width -halo_height \
          -fence_lx   -fence_ly  -fence_ux   -fence_uy  \
          -area_weight  -outline_weight -wirelength_weight -guidance_weight -fence_weight \
-         -boundary_weight -notch_weight -macro_blockage_weight  \
-         -pin_access_th -target_util \
+         -boundary_weight -notch_weight \
+         -macro_blockage_weight -target_util \
          -target_dead_space -min_ar \
          -report_directory \
          -write_macro_placement } \
@@ -79,7 +78,6 @@ proc rtl_macro_placer { args } {
   set boundary_weight 50.0
   set notch_weight 10.0
   set macro_blockage_weight 10.0
-  set pin_access_th 0.00
   set target_util 0.25
   set target_dead_space 0.05
   set min_ar 0.33
@@ -162,9 +160,6 @@ proc rtl_macro_placer { args } {
   if { [info exists keys(-macro_blockage_weight)] } {
     set macro_blockage_weight $keys(-macro_blockage_weight)
   }
-  if { [info exists keys(-pin_access_th)] } {
-    set pin_access_th $keys(-pin_access_th)
-  }
   if { [info exists keys(-target_util)] } {
     set target_util $keys(-target_util)
   }
@@ -200,7 +195,6 @@ proc rtl_macro_placer { args } {
       $area_weight $outline_weight $wirelength_weight \
       $guidance_weight $fence_weight $boundary_weight \
       $notch_weight $macro_blockage_weight \
-      $pin_access_th \
       $target_util \
       $target_dead_space \
       $min_ar \

src/mpl/src/rtl_mp.cpp

@@ -56,7 +56,6 @@ bool MacroPlacer::place(const int num_threads,
                         const float boundary_weight,
                         const float notch_weight,
                         const float macro_blockage_weight,
-                        const float pin_access_th,
                         const float target_util,
                         const float target_dead_space,
                         const float min_ar,
@@ -80,7 +79,6 @@ bool MacroPlacer::place(const int num_threads,
   hier_rtlmp_->setBoundaryWeight(boundary_weight);
   hier_rtlmp_->setNotchWeight(notch_weight);
   hier_rtlmp_->setMacroBlockageWeight(macro_blockage_weight);
-  hier_rtlmp_->setPinAccessThreshold(pin_access_th);
   hier_rtlmp_->setTargetUtil(target_util);
   hier_rtlmp_->setTargetDeadSpace(target_dead_space);
   hier_rtlmp_->setMinAR(min_ar);