pad: apply clang-tidy suggestions

Signed-off-by: Peter Gadfort <[email protected]>

Author: gadfort

src/pad/src/RDLRoute.cpp

@@ -4,13 +4,18 @@
 #include "RDLRoute.h"
 
 #include <algorithm>
+#include <array>
 #include <map>
 #include <memory>
+#include <set>
 #include <tuple>
 #include <vector>
 
 #include "boost/geometry/geometry.hpp"
-#include "boost/polygon/polygon.hpp"
+#include "boost/polygon/polygon_90_set_data.hpp"
+#include "boost/polygon/polygon_90_with_holes_data.hpp"
+#include "boost/polygon/rectangle_concept.hpp"
+#include "boost/polygon/rectangle_data.hpp"
 #include "odb/db.h"
 #include "odb/geom.h"
 #include "odb/geom_boost.h"
@@ -230,7 +235,9 @@ bool RDLRoute::contains(const odb::Point& pt) const
 
 void RDLRoute::preprocess(odb::dbTechLayer* layer, utl::Logger* logger)
 {
-  using namespace boost::polygon::operators;
+  using boost::polygon::operators::operator+=;
+  using boost::polygon::operators::operator-=;
+
   using Rectangle = boost::polygon::rectangle_data<int>;
   using Polygon90 = boost::polygon::polygon_90_with_holes_data<int>;
   using Polygon90Set = boost::polygon::polygon_90_set_data<int>;
@@ -280,7 +287,7 @@ void RDLRoute::preprocess(odb::dbTechLayer* layer, utl::Logger* logger)
   for (const auto& [iterm, polys] : iterms_geoms) {
     Polygon90Set check = polys;
     check.interact(source_iterms);
-    if (check.size() > 0) {
+    if (!check.empty()) {
       // There is nothing to do
       locked_ = true;
       routed_ = true;
@@ -297,7 +304,7 @@ void RDLRoute::preprocess(odb::dbTechLayer* layer, utl::Logger* logger)
     Polygon90Set check = polys;
     check.bloat(min_dist, min_dist, min_dist, min_dist);
     check.interact(source_iterms);
-    if (check.size() > 0) {
+    if (!check.empty()) {
       Polygon90Set source_bloat = source_iterms;
       source_bloat.bloat(min_dist, min_dist, min_dist, min_dist);
       check += source_bloat;

src/pad/src/RDLRoute.h

@@ -5,6 +5,7 @@
 
 #include <map>
 #include <memory>
+#include <set>
 #include <vector>
 
 #include "RDLRouter.h"

src/pad/src/RDLRouter.cpp

@@ -1621,12 +1621,12 @@ void RDLRouter::writeToDb(odb::dbNet* net,
       shape.bloat(width_ / 2, shape);
       odb::dbSBox::Direction dir;
       if (s.x() == t.x()) {
-        shape.set_ylo(shape.yMin() + width_ / 2);
-        shape.set_yhi(shape.yMax() - width_ / 2);
+        shape.set_ylo(shape.yMin() + (width_ / 2));
+        shape.set_yhi(shape.yMax() - (width_ / 2));
         dir = odb::dbSBox::VERTICAL;
       } else if (s.y() == t.y()) {
-        shape.set_xlo(shape.xMin() + width_ / 2);
-        shape.set_xhi(shape.xMax() - width_ / 2);
+        shape.set_xlo(shape.xMin() + (width_ / 2));
+        shape.set_xhi(shape.xMax() - (width_ / 2));
         dir = odb::dbSBox::HORIZONTAL;
       } else {
         dir = odb::dbSBox::OCTILINEAR;