ord: Separate cmake openroad target into a binary and a library.

Signed-off-by: Ted Hong <[email protected]>

Author: hongted

CMakeLists.txt

@@ -139,17 +139,22 @@ add_subdirectory(src)
 add_subdirectory(test)
 
 # Not currently used but may become useful again with Kokkos
+target_compile_definitions(openroad_lib PRIVATE GPU)
 target_compile_definitions(openroad PRIVATE GPU)
 
 if(BUILD_PYTHON)
+  target_compile_definitions(openroad_lib PRIVATE BUILD_PYTHON=1)
   target_compile_definitions(openroad PRIVATE BUILD_PYTHON=1)
 else()
+  target_compile_definitions(openroad_lib PRIVATE BUILD_PYTHON=0)
   target_compile_definitions(openroad PRIVATE BUILD_PYTHON=0)
 endif()
 
 if(BUILD_GUI)
+  target_compile_definitions(openroad_lib PRIVATE BUILD_GUI=1)
   target_compile_definitions(openroad PRIVATE BUILD_GUI=1)
 else()
+  target_compile_definitions(openroad_lib PRIVATE BUILD_GUI=0)
   target_compile_definitions(openroad PRIVATE BUILD_GUI=0)
 endif()
 

src/CMakeLists.txt

@@ -28,13 +28,16 @@ set(DBSTA_HOME ${PROJECT_SOURCE_DIR}/src/dbSta)
 set(RESIZER_HOME ${PROJECT_SOURCE_DIR}/src/rsz)
 set(GUI_HOME ${PROJECT_SOURCE_DIR}/src/gui)
 
-set(OPENROAD_SOURCE
+set(OPENROAD_LIB_SOURCE
   Design.cc
   Timing.cc
   Tech.cc
   OpenRoad.cc
+)
+
+set(OPENROAD_SOURCE
   Main.cc
-  )
+)
 
 if(USE_SYSTEM_BOOST)
   set(Boost_USE_STATIC_LIBS OFF)
@@ -285,10 +288,18 @@ add_subdirectory(est)
 
 ################################################################
 
+add_library(openroad_lib
+  ${OPENROAD_LIB_SOURCE}
+)
 add_executable(openroad
   ${OPENROAD_SOURCE}
 )
 
+target_compile_options(openroad_lib
+  PRIVATE
+    -Wextra -pedantic -Wcast-qual
+)
+
 set_target_properties(openroad PROPERTIES
   RUNTIME_OUTPUT_DIRECTORY "${CMAKE_BINARY_DIR}/bin"
 )
@@ -298,26 +309,34 @@ target_compile_options(openroad
     -Wextra -pedantic -Wcast-qual
 )
 
+
 # Needed for boost stacktrace
 if(APPLE)
-  target_compile_definitions(openroad PUBLIC "-D_GNU_SOURCE")
+  target_compile_definitions(openroad_lib PUBLIC "-D_GNU_SOURCE")
 endif()
 
 
+set_target_properties(openroad_lib PROPERTIES
+  # Disable compiler specific extensions like gnu++11.
+  CXX_EXTENSIONS OFF
+  # Export symbols for stack trace printing
+  ENABLE_EXPORTS ON
+)
 set_target_properties(openroad PROPERTIES
   # Disable compiler specific extensions like gnu++11.
   CXX_EXTENSIONS OFF
   # Export symbols for stack trace printing
   ENABLE_EXPORTS ON
 )
-target_compile_features(openroad PUBLIC cxx_std_17)
+target_compile_features(openroad_lib PUBLIC cxx_std_17)
 
-target_include_directories(openroad
+target_include_directories(openroad_lib
   PUBLIC
     ../include
 )
 
-target_link_libraries(openroad
+target_link_libraries(openroad_lib
+  PUBLIC
   ifp
   pad
   ord
@@ -357,12 +376,20 @@ target_link_libraries(openroad
   ${Boost_LIBRARIES}
 )
 
+target_link_libraries(openroad
+  PRIVATE
+  openroad_lib
+  cts
+  ${TCL_LIBRARY}
+)
+
+target_compile_definitions(openroad_lib PRIVATE BUILD_TYPE="${CMAKE_BUILD_TYPE}")
 target_compile_definitions(openroad PRIVATE BUILD_TYPE="${CMAKE_BUILD_TYPE}")
 
 # tclReadline
 if (TCL_READLINE_LIBRARY AND TCL_READLINE_H)
   target_compile_definitions(openroad PRIVATE ENABLE_READLINE)
-  target_link_libraries(openroad ${TCL_READLINE_LIBRARY})
+  target_link_libraries(openroad PRIVATE ${TCL_READLINE_LIBRARY})
   target_include_directories(openroad PRIVATE ${TCL_READLINE_H})
   message(STATUS "TCL readline enabled")
 else()
@@ -371,24 +398,25 @@ endif()
 
 if (BUILD_TCLX AND TCLX_LIBRARY AND TCLX_H)
   target_compile_definitions(openroad PRIVATE ENABLE_TCLX)
-  target_link_libraries(openroad ${TCLX_LIBRARY})
+  target_link_libraries(openroad PRIVATE ${TCLX_LIBRARY})
   target_include_directories(openroad PRIVATE ${TCLX_H})
   message(STATUS "Tcl Extended enabled")
 else()
   message(STATUS "Tcl Extended disabled")
 endif()
 
 if (ZLIB_FOUND)
-  target_link_libraries(openroad ${ZLIB_LIBRARIES})
+  target_link_libraries(openroad_lib PUBLIC ${ZLIB_LIBRARIES})
 endif()
 
 # Optional CUDD library for OpenSTA
 if (CUDD_LIB)
-  target_link_libraries(openroad ${CUDD_LIB})
+  target_link_libraries(openroad_lib PUBLIC ${CUDD_LIB})
 endif()
 
 if (Python3_FOUND AND BUILD_PYTHON)
   message(STATUS "Python3 enabled")
+  target_compile_definitions(openroad_lib PUBLIC ENABLE_PYTHON3)
   target_compile_definitions(openroad PRIVATE ENABLE_PYTHON3)
 
   swig_lib(NAME      ord_py
@@ -404,8 +432,9 @@ if (Python3_FOUND AND BUILD_PYTHON)
       odb
       OpenSTA
       ifp
+      openroad_lib
   )
-  target_link_libraries(openroad
+  target_link_libraries(openroad PRIVATE
     ord_py
     odb_py
     ifp_py
@@ -434,6 +463,13 @@ else()
   message(STATUS "Python3 disabled")
 endif()
 
+messages(
+  TARGET openroad_lib
+  SOURCE_DIR .
+  OUTPUT_DIR ..
+  LOCAL
+)
+
 messages(
   TARGET openroad
   SOURCE_DIR .
@@ -447,7 +483,7 @@ messages(
 if (CMAKE_CXX_COMPILER_ID STREQUAL "GNU"
     AND CMAKE_SYSTEM_NAME STREQUAL "Linux")
   find_library(LIBRT rt)
-  target_link_libraries(openroad ${LIBRT})
+  target_link_libraries(openroad_lib PUBLIC ${LIBRT})
 endif()
 
 ################################################################
@@ -460,6 +496,7 @@ install(TARGETS openroad DESTINATION bin)
 ################################################################
 
 add_custom_target(openroad_tags etags -o TAGS
+  ${OPENROAD_LIB_SOURCE}
   ${OPENROAD_SOURCE}
   ${OPENROAD_HOME}/include/ord/*.hh
   ${OPENROAD_HOME}/src/dbSta/src/*.hh
@@ -468,5 +505,5 @@ add_custom_target(openroad_tags etags -o TAGS
   ${RESIZER_HOME}/src/*.hh
   ${RESIZER_HOME}/src/*.cc
   WORKING_DIRECTORY ${OPENROAD_HOME}/src
-  DEPENDS ${OPENROAD_SOURCE} ${OPENROAD_HEADERS} ${OPENROAD_TCL_FILES}
+  DEPENDS ${OPENROAD_LIB_SOURCE} ${OPENROAD_SOURCE} ${OPENROAD_HEADERS} ${OPENROAD_TCL_FILES}
 )

src/OpenRoad.cc

@@ -13,12 +13,6 @@
 #include <thread>
 #include <vector>
 
-#include "ord/Version.hh"
-#ifdef ENABLE_PYTHON3
-#define PY_SSIZE_T_CLEAN
-#include "Python.h"
-#endif
-
 #include "ant/MakeAntennaChecker.hh"
 #include "cgt/MakeClockGating.h"
 #include "cts/MakeTritoncts.h"
@@ -47,6 +41,7 @@
 #include "odb/lefin.h"
 #include "odb/lefout.h"
 #include "ord/InitOpenRoad.hh"
+#include "ord/Version.hh"
 #include "pad/MakeICeWall.h"
 #include "par/MakePartitionMgr.h"
 #include "pdn/MakePdnGen.hh"