Merge pull request #7989 from gadfort/gui-cov

gui: fix coverity issues

Author: maliberty

src/drt/src/dr/FlexDR_graphics.cpp

@@ -68,7 +68,7 @@ void GridGraphDescriptor::highlight(const std::any& object,
                                     gui::Painter& painter) const
 {
   odb::Rect bbox;
-  getBBox(std::move(object), bbox);
+  getBBox(object, bbox);
   auto x = bbox.xMin();
   auto y = bbox.yMin();
   bbox.init(x - 20, y - 20, x + 20, y + 20);
@@ -134,7 +134,7 @@ gui::Descriptor::Properties GridGraphDescriptor::getProperties(
     }
 
     if (!graph->hasEdge(x, y, z, dir)) {
-      props.push_back({name, "<none>"});
+      props.push_back({std::move(name), "<none>"});
       continue;
     }
 

src/gui/include/gui/gui.h

@@ -300,7 +300,7 @@ class Descriptor
   virtual std::string getName(const std::any& object) const = 0;
   virtual std::string getShortName(const std::any& object) const
   {
-    return getName(std::move(object));
+    return getName(object);
   }
   virtual std::string getTypeName() const = 0;
   virtual std::string getTypeName(const std::any& /* object */) const

src/gui/src/dbDescriptors.cpp

@@ -2616,7 +2616,7 @@ void DbBlockageDescriptor::highlight(const std::any& object,
                                      Painter& painter) const
 {
   odb::Rect rect;
-  getBBox(std::move(object), rect);
+  getBBox(object, rect);
   painter.drawRect(rect);
 }
 
@@ -2733,7 +2733,7 @@ void DbObstructionDescriptor::highlight(const std::any& object,
                                         Painter& painter) const
 {
   odb::Rect rect;
-  getBBox(std::move(object), rect);
+  getBBox(object, rect);
   painter.drawRect(rect);
 }
 

src/gui/src/gui.cpp

@@ -406,8 +406,7 @@ std::string Gui::addLabel(int x,
                           std::optional<Painter::Anchor> anchor,
                           const std::optional<std::string>& name)
 {
-  return main_window->addLabel(
-      x, y, text, color, size, anchor, std::move(name));
+  return main_window->addLabel(x, y, text, color, size, anchor, name);
 }
 
 void Gui::deleteLabel(const std::string& name)

src/gui/src/layoutViewer.cpp

@@ -2489,8 +2489,8 @@ LayoutScroll::LayoutScroll(
     const std::function<int()>& arrow_keys_scroll_step,
     QWidget* parent)
     : QScrollArea(parent),
-      default_mouse_wheel_zoom_(std::move(default_mouse_wheel_zoom)),
-      arrow_keys_scroll_step_(std::move(arrow_keys_scroll_step)),
+      default_mouse_wheel_zoom_(default_mouse_wheel_zoom),
+      arrow_keys_scroll_step_(arrow_keys_scroll_step),
       viewer_(viewer),
       scrolling_with_cursor_(false)
 {