Merge pull request #8841 from osamahammad21/drt-data-race

DRT: fix data race in pa

Author: osamahammad21

src/drt/src/pa/FlexPA.cpp

@@ -109,6 +109,8 @@ void FlexPA::addInst(frInst* inst)
     unique_insts_.initUniqueInstPinAccess(unique_class);
     initSkipInstTerm(unique_class);
     genInstAccessPoints(inst);
+    unique_inst_patterns_[unique_class]
+        = std::vector<std::unique_ptr<FlexPinAccessPattern>>();
     prepPatternInst(inst);
   }
   inst->setPinAccessIdx(unique_class->getPinAccessIdx());
@@ -208,8 +210,12 @@ void FlexPA::prepPattern()
 
   const auto& unique = unique_insts_.getUniqueClasses();
 
-  // revert access points to origin
+  // reserve space for unique_inst_patterns_
   unique_inst_patterns_.reserve(unique.size());
+  for (auto& unique_class : unique) {
+    unique_inst_patterns_[unique_class.get()]
+        = std::vector<std::unique_ptr<FlexPinAccessPattern>>();
+  }
 
   int cnt = 0;
 

src/drt/src/pa/FlexPA_acc_pattern.cpp

@@ -65,10 +65,6 @@ void FlexPA::buildInstsSet()
 
 void FlexPA::prepPatternInst(frInst* unique_inst)
 {
-  auto unique_class = unique_insts_.getUniqueClass(unique_inst);
-#pragma omp critical
-  unique_inst_patterns_[unique_class]
-      = std::vector<std::unique_ptr<FlexPinAccessPattern>>();
   int num_valid_pattern = prepPatternInstHelper(unique_inst, true);
 
   if (num_valid_pattern > 0) {
@@ -660,8 +656,8 @@ bool FlexPA::genPatternsCommit(
   if (target_obj != nullptr
       && genPatternsGC({target_obj}, objs, Commit, &owners)) {
     pin_access_pattern->updateCost();
-    unique_inst_patterns_[unique_insts_.getUniqueClass(unique_inst)].push_back(
-        std::move(pin_access_pattern));
+    unique_inst_patterns_.at(unique_insts_.getUniqueClass(unique_inst))
+        .push_back(std::move(pin_access_pattern));
     // genPatternsPrint(nodes, pins);
     is_valid = true;
   } else {

src/drt/src/pa/FlexPA_row_pattern.cpp

@@ -267,7 +267,7 @@ void FlexPA::genInstRowPatternInit(
   for (int inst_idx = 0; inst_idx < (int) insts.size(); inst_idx++) {
     auto& inst = insts[inst_idx];
     auto unique_class = unique_insts_.getUniqueClass(inst);
-    auto& inst_patterns = unique_inst_patterns_[unique_class];
+    auto& inst_patterns = unique_inst_patterns_.at(unique_class);
     nodes[inst_idx]
         = std::vector<std::unique_ptr<FlexDPNode>>(inst_patterns.size());
     for (int acc_pattern_idx = 0; acc_pattern_idx < (int) inst_patterns.size();
@@ -348,7 +348,7 @@ void FlexPA::genInstRowPatternCommit(
     int access_point_idx = 0;
     auto unique_class = unique_insts_.getUniqueClass(inst);
     auto access_pattern
-        = unique_inst_patterns_[unique_class][curr_acc_patterns_idx].get();
+        = unique_inst_patterns_.at(unique_class)[curr_acc_patterns_idx].get();
     auto& access_points = access_pattern->getPattern();
 
     // update inst_term ap
@@ -392,7 +392,7 @@ void FlexPA::genInstRowPatternPrint(
       int access_point_idx = 0;
       auto unique_class = unique_insts_.getUniqueClass(inst);
       auto access_pattern
-          = unique_inst_patterns_[unique_class][curr_acc_pattern_idx].get();
+          = unique_inst_patterns_.at(unique_class)[curr_acc_pattern_idx].get();
       auto& access_points = access_pattern->getPattern();
 
       for (auto& inst_term : inst->getInstTerms()) {
@@ -451,9 +451,9 @@ int FlexPA::getEdgeCost(FlexDPNode* prev_node,
   const auto curr_inst = insts[curr_inst_idx];
   const auto curr_unique_class = unique_insts_.getUniqueClass(curr_inst);
   const auto prev_pin_access_pattern
-      = unique_inst_patterns_[prev_unique_class][prev_acc_pattern_idx].get();
+      = unique_inst_patterns_.at(prev_unique_class)[prev_acc_pattern_idx].get();
   const auto curr_pin_access_pattern
-      = unique_inst_patterns_[curr_unique_class][curr_acc_pattern_idx].get();
+      = unique_inst_patterns_.at(curr_unique_class)[curr_acc_pattern_idx].get();
   addAccessPatternObj(
       prev_inst, prev_pin_access_pattern, objs, temp_vias, true);
   addAccessPatternObj(