Merge pull request #8538 from hzeller/feature-20251003-layering-check-tests

Enable layering_check in test BUILD files.

Author: maliberty

bazel/BUILD

@@ -1,6 +1,8 @@
 load("@openroad_rules_python//python:pip.bzl", "compile_pip_requirements")
 load("@rules_cc//cc:cc_library.bzl", "cc_library")
 
+package(features = ["layering_check"])
+
 compile_pip_requirements(
     name = "requirements",
     src = "requirements.in",

bazel/openmp/BUILD

@@ -14,6 +14,7 @@
 
 package(
     default_visibility = ["//visibility:private"],
+    features = ["layering_check"],
 )
 
 exports_files(

etc/BUILD

@@ -1,5 +1,7 @@
 load("@openroad_rules_python//python:defs.bzl", "py_binary")
 
+package(features = ["layering_check"])
+
 py_binary(
     name = "file_to_string",
     srcs = [

openroad/BUILD

@@ -4,6 +4,8 @@ load("@openroad_rules_python//python:defs.bzl", "py_library")
 # Copyright (c) 2025-2025, The OpenROAD Authors
 load("@openroad_rules_python//python:packaging.bzl", "py_package", "py_wheel")
 
+package(features = ["layering_check"])
+
 py_library(
     name = "openroadpy",
     srcs = [

src/ant/test/BUILD

@@ -1,5 +1,7 @@
 load("//test:regression.bzl", "regression_test")
 
+package(features = ["layering_check"])
+
 # From CMakeLists.txt or_integration_tests(TESTS
 COMPULSORY_TESTS = [
     "ant_check",

src/cgt/test/BUILD

@@ -2,6 +2,8 @@
 # Copyright (c) 2025, The OpenROAD Authors
 load("//test:regression.bzl", "regression_test")
 
+package(features = ["layering_check"])
+
 TESTS = [
     "aes_nangate45",
     "countdown_asap7",

src/cts/test/BUILD

@@ -4,6 +4,8 @@ load("@rules_cc//cc:cc_test.bzl", "cc_test")
 # Copyright (c) 2022-2025, The OpenROAD Authors
 load("//test:regression.bzl", "regression_test")
 
+package(features = ["layering_check"])
+
 # From CMakeLists.txt or_integration_tests(TESTS
 COMPULSORY_TESTS = [
     "array",
@@ -182,10 +184,10 @@ filegroup(
 cc_test(
     name = "cts_unittest",
     srcs = ["cts_unittest.cc"],
+    features = ["-layering_check"],  # TODO: accesses private headers
     linkstatic = True,  # TODO: remove once deps define all symbols
     deps = [
         "//src/cts",
-        "//src/grt",  # work around cyclic dependncy between rsz and grt
         "//src/utl",
         "@googletest//:gtest",
         "@googletest//:gtest_main",

src/cut/BUILD

@@ -5,6 +5,7 @@ load("@rules_cc//cc:cc_library.bzl", "cc_library")
 
 package(
     default_visibility = ["//:__subpackages__"],
+    features = ["layering_check"],
 )
 
 cc_library(
@@ -31,6 +32,7 @@ cc_library(
     includes = ["include"],
     deps = [
         "//src/dbSta",
+        "//src/dbSta:dbNetwork",
         "//src/odb",
         "//src/rsz",
         "//src/sta:opensta_lib",

src/cut/test/BUILD

@@ -3,6 +3,8 @@
 
 load("@rules_cc//cc:cc_test.bzl", "cc_test")
 
+package(features = ["layering_check"])
+
 cc_test(
     name = "cut_abc_test",
     srcs = ["cpp/TestAbc.cc"],
@@ -11,8 +13,13 @@ cc_test(
         "//src/cut",
         "//src/dbSta",
         "//src/dbSta:dbReadVerilog",
+        "//src/odb",
+        "//src/sta:opensta_lib",
         "//src/tst",
+        "//src/utl",
+        "@edu_berkeley_abc//:abc-lib",
         "@googletest//:gtest",
         "@googletest//:gtest_main",
+        "@tk_tcl//:tcl",
     ],
 )

src/cut/test/cpp/TestAbc.cc

@@ -4,7 +4,6 @@
 // license that can be found in the LICENSE file or at
 // https://developers.google.com/open-source/licenses/bsd
 
-#include <tcl.h>
 #include <unistd.h>
 
 #include <array>
@@ -42,6 +41,7 @@
 #include "sta/Sta.hh"
 #include "sta/Units.hh"
 #include "sta/VerilogReader.hh"
+#include "tcl.h"
 #include "tst/fixture.h"
 #include "utl/Logger.h"
 #include "utl/deleter.h"