Skip to content

Commit cc542cd

Browse files
committed
Fixed lint issue 2nd
Signed-off-by: Jaehyun Kim <[email protected]>
1 parent 8dd149b commit cc542cd

File tree

3 files changed

+30
-20
lines changed

3 files changed

+30
-20
lines changed

src/odb/src/db/dbModBTerm.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,8 @@
1616
#include "dbTable.hpp"
1717
#include "odb/db.h"
1818
// User Code Begin Includes
19+
#include <string>
20+
1921
#include "odb/dbBlockCallBackObj.h"
2022
// User Code End Includes
2123
namespace odb {

src/odb/src/db/dbModITerm.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@
1515
#include "dbTable.hpp"
1616
#include "odb/db.h"
1717
// User Code Begin Includes
18+
#include <string>
19+
1820
#include "odb/dbBlockCallBackObj.h"
1921
// User Code End Includes
2022
namespace odb {

src/odb/src/db/dbUtil.h

Lines changed: 26 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,13 @@
22
// Copyright (c) 2022-2025, The OpenROAD Authors
33
#pragma once
44

5+
#include <cstddef>
56
#include <string>
67
#include <vector>
78

89
#include "odb/db.h"
910
#include "odb/odb.h"
11+
#include "utl/Logger.h"
1012

1113
namespace odb {
1214

@@ -26,11 +28,11 @@ void findBTermDrivers(const NetType* net,
2628
|| bterm->getIoType() == dbIoType::INOUT) {
2729
dbBlock* block = bterm->getBlock();
2830
dbModule* parent_module = block->getTopModule();
29-
drvr_info_list.push_back(
30-
fmt::format("\n - bterm: '{}' (block: '{}', parent_module: '{}')",
31-
bterm->getName(),
32-
(block) ? block->getConstName() : "null",
33-
(parent_module) ? parent_module->getName() : "null"));
31+
drvr_info_list.push_back(fmt::format( // NOLINT(misc-include-cleaner)
32+
"\n - bterm: '{}' (block: '{}', parent_module: '{}')",
33+
bterm->getName(),
34+
(block) ? block->getConstName() : "null",
35+
(parent_module) ? parent_module->getName() : "null"));
3436
}
3537
}
3638
}
@@ -51,7 +53,7 @@ void findITermDrivers(const NetType* net,
5153
dbMaster* master = inst->getMaster();
5254
dbModule* parent_module = inst->getModule();
5355
dbBlock* block = inst->getBlock();
54-
drvr_info_list.push_back(fmt::format(
56+
drvr_info_list.push_back(fmt::format( // NOLINT(misc-include-cleaner)
5557
"\n - iterm: '{}' (block: '{}', parent_module: '{}', master: '{}')",
5658
iterm->getName(),
5759
(block) ? block->getConstName() : "null",
@@ -72,8 +74,9 @@ inline void findModBTermDrivers(const dbModNet* net,
7274

7375
if (modbterm->getIoType() == dbIoType::INPUT
7476
|| modbterm->getIoType() == dbIoType::INOUT) {
75-
drvr_info_list.push_back(
76-
fmt::format("\n - modbterm: '{}'", modbterm->getHierarchicalName()));
77+
drvr_info_list.push_back(fmt::format( // NOLINT(misc-include-cleaner)
78+
"\n - modbterm: '{}'",
79+
modbterm->getHierarchicalName()));
7780
}
7881
}
7982
}
@@ -90,8 +93,9 @@ inline void findModITermDrivers(const dbModNet* net,
9093

9194
if (child_bterm->getIoType() == dbIoType::OUTPUT
9295
|| child_bterm->getIoType() == dbIoType::INOUT) {
93-
drvr_info_list.push_back(fmt::format("\n - moditerm: '{}'",
94-
moditerm->getHierarchicalName()));
96+
drvr_info_list.push_back(fmt::format( // NOLINT(misc-include-cleaner)
97+
"\n - moditerm: '{}'",
98+
moditerm->getHierarchicalName()));
9599
}
96100
}
97101
}
@@ -109,17 +113,19 @@ void checkNetSanity(const NetType* net,
109113
//
110114
if (drvr_count > 1) {
111115
if constexpr (std::is_same_v<NetType, dbNet>) {
112-
logger->warn(utl::ODB,
113-
49,
114-
"SanityCheck: dbNet '{}' has multiple drivers: {}",
115-
net->getName(),
116-
fmt::join(drvr_info_list, ""));
116+
logger->warn(
117+
utl::ODB,
118+
49,
119+
"SanityCheck: dbNet '{}' has multiple drivers: {}",
120+
net->getName(),
121+
fmt::join(drvr_info_list, "")); // NOLINT(misc-include-cleaner)
117122
} else {
118-
logger->warn(utl::ODB,
119-
481, // Reusing error code from dbNet
120-
"SanityCheck: dbModNet '{}' has multiple drivers: {}",
121-
net->getHierarchicalName(),
122-
fmt::join(drvr_info_list, ""));
123+
logger->warn(
124+
utl::ODB,
125+
481, // Reusing error code from dbNet
126+
"SanityCheck: dbModNet '{}' has multiple drivers: {}",
127+
net->getHierarchicalName(),
128+
fmt::join(drvr_info_list, "")); // NOLINT(misc-include-cleaner)
123129
}
124130
}
125131

0 commit comments

Comments
 (0)