gui: address code reviews,

check for invalid objects,
rename function,
remove unecessary selectedCaptureRowChanged()

Signed-off-by: Augusto Berndt <[email protected]>

Author: gudeh

src/gui/include/gui/gui.h

@@ -773,7 +773,7 @@ class Gui
                           int width_px = 0,
                           int height_px = 0);
 
-  void showWorstPath(bool setup);
+  void showWorstTimingPath(bool setup);
 
   // modify display controls
   void setDisplayControlsVisible(const std::string& name, bool value);

src/gui/src/gui.cpp

@@ -864,11 +864,12 @@ void Gui::saveHistogramImage(const std::string& filename,
       filename, chart_mode, width, height);
 }
 
-void Gui::showWorstPath(bool setup)
+void Gui::showWorstTimingPath(bool setup)
 {
-  if (main_window->getTimingWidget()) {
-    main_window->getTimingWidget()->showWorstPath(setup);
+  if (!enabled()) {
+    return;
   }
+  main_window->getTimingWidget()->showWorstTimingPath(setup);
 }
 
 void Gui::selectClockviewerClock(const std::string& clock_name,

src/gui/src/gui.i

@@ -338,7 +338,7 @@ void show_worst_path(bool setup = true)
     return;
   }
   auto gui = gui::Gui::get();
-  gui->showWorstPath(setup);
+  gui->showWorstTimingPath(setup);
 }
 
 void clear_rulers()

src/gui/src/timingWidget.cpp

@@ -789,9 +789,18 @@ void TimingWidget::hideEvent(QHideEvent* event)
   toggleRenderer(false);
 }
 
-void TimingWidget::showWorstPath(bool setup)
+void TimingWidget::showWorstTimingPath(bool setup)
 {
-  populatePaths();
+  if (setup_timing_paths_model_ == nullptr
+      || hold_timing_paths_model_ == nullptr) {
+    return;
+  }
+
+  if (setup_timing_paths_model_->rowCount() == 0
+      && hold_timing_paths_model_->rowCount() == 0) {
+    populatePaths();
+  }
+
   QTableView* table_view
       = setup ? setup_timing_table_view_ : hold_timing_table_view_;
   QAbstractItemModel* model = table_view->model();
@@ -800,13 +809,8 @@ void TimingWidget::showWorstPath(bool setup)
     table_view->setCurrentIndex(index);
     // Ensure the selection signal is emitted even if the index was already
     // selected
-    if (setup) {
-      selectedRowChanged(table_view->selectionModel()->selection(),
-                         QItemSelection());
-    } else {
-      selectedCaptureRowChanged(table_view->selectionModel()->selection(),
-                                QItemSelection());
-    }
+    selectedRowChanged(table_view->selectionModel()->selection(),
+                       QItemSelection());
   }
 }
 

src/gui/src/timingWidget.h

@@ -71,7 +71,7 @@ class TimingWidget : public QDockWidget
   void updatePaths();
   void reportSlackHistogramPaths(const std::set<const sta::Pin*>& report_pins,
                                  const std::string& path_group_name);
-  void showWorstPath(bool setup);
+  void showWorstTimingPath(bool setup);
 
  signals:
   void highlightTimingPath(TimingPath* timing_path);