Merge pull request #8872 from The-OpenROAD-Project-staging/c++20

Upgrade to C++20

Author: maliberty

.bazelrc

@@ -12,7 +12,7 @@ test --test_timeout=300,1800,1800,9600
 # match, but bazel 8 will be strict. So start now.
 common --incompatible_disallow_empty_glob
 
-build --cxxopt "-std=c++17"        --host_cxxopt "-std=c++17"
+build --cxxopt "-std=c++20"        --host_cxxopt "-std=c++20"
 build --cxxopt "-xc++"             --host_cxxopt "-xc++"
 build --cxxopt "-DBAZEL_BUILD"     --host_cxxopt "-DBAZEL_BUILD"
 

CMakeLists.txt

@@ -59,7 +59,7 @@ set(OPENROAD_HOME ${PROJECT_SOURCE_DIR})
 set(OPENROAD_SHARE ${CMAKE_INSTALL_PREFIX}/share/openroad)
 
 # Default c++ standard used unless otherwise specified in target_compile_features.
-set(CMAKE_CXX_STANDARD 17 CACHE STRING "the C++ standard to use for this project")
+set(CMAKE_CXX_STANDARD 20 CACHE STRING "the C++ standard to use for this project")
 set(CMAKE_CXX_STANDARD_REQUIRED ON)
 # Disable compiler specific extensions like gnu++11.
 set(CMAKE_CXX_EXTENSIONS OFF)

src/dbSta/src/dbNetwork.cc

@@ -2313,7 +2313,7 @@ void dbNetwork::makeTopCell()
   for (dbBTerm* bterm : block_->getBTerms()) {
     makeTopPort(bterm);
   }
-  groupBusPorts(top_cell_, [=](const char* port_name) {
+  groupBusPorts(top_cell_, [=, this](const char* port_name) {
     return portMsbFirst(port_name, design_name);
   });
 

src/gui/src/chartsWidget.cpp

@@ -875,7 +875,7 @@ void HistogramView::emitEndPointsInBucket(const int bar_index)
     return;
   }
 
-  auto compare_slack = [=](const sta::Pin* a, const sta::Pin* b) {
+  auto compare_slack = [this](const sta::Pin* a, const sta::Pin* b) {
     return sta_->getPinSlack(a) < sta_->getPinSlack(b);
   };
   std::sort(end_points.begin(), end_points.end(), compare_slack);

src/gui/src/clockWidget.cpp

@@ -822,7 +822,7 @@ ClockTreeView::ClockTreeView(std::shared_ptr<ClockTree> tree,
           &ClockTreeScene::clearPath,
           this,
           &ClockTreeView::clearHighlightTo);
-  connect(scene_, &ClockTreeScene::save, [=] { save(); });
+  connect(scene_, &ClockTreeScene::save, [this] { save(); });
   connect(scene_,
           &ClockTreeScene::colorDepth,
           this,
@@ -1571,7 +1571,7 @@ ClockWidget::ClockWidget(QWidget* parent)
   container->setLayout(layout);
   setWidget(container);
 
-  connect(update_button_, &QPushButton::clicked, [=] { populate(); });
+  connect(update_button_, &QPushButton::clicked, [this] { populate(); });
   connect(fit_button_, &QPushButton::clicked, this, &ClockWidget::fit);
 
   update_button_->setEnabled(false);

src/gui/src/mainWindow.cpp

@@ -210,9 +210,9 @@ MainWindow::MainWindow(bool load_settings, QWidget* parent)
   connect(this, &MainWindow::rulersChanged, viewers_, &LayoutTabs::fullRepaint);
   connect(this, &MainWindow::labelsChanged, viewers_, &LayoutTabs::fullRepaint);
 
-  connect(controls_, &DisplayControls::selected, [=](const Selected& selected) {
-    setSelected(selected);
-  });
+  connect(controls_,
+          &DisplayControls::selected,
+          [this](const Selected& selected) { setSelected(selected); });
 
   connect(inspector_,
           &Inspector::selected,
@@ -250,12 +250,12 @@ MainWindow::MainWindow(bool load_settings, QWidget* parent)
           &Inspector::loadActions);
   connect(inspector_,
           &Inspector::removeHighlight,
-          [=](const QList<const Selected*>& selected) {
+          [this](const QList<const Selected*>& selected) {
             removeFromHighlighted(selected);
           });
   connect(inspector_,
           &Inspector::addHighlight,
-          [=](const SelectionSet& selected) { addHighlighted(selected); });
+          [this](const SelectionSet& selected) { addHighlighted(selected); });
   connect(
       inspector_, &Inspector::setCommand, script_, &ScriptWidget::setCommand);
   connect(script_,
@@ -269,14 +269,14 @@ MainWindow::MainWindow(bool load_settings, QWidget* parent)
 
   connect(hierarchy_widget_,
           &BrowserWidget::select,
-          [=](const SelectionSet& selected) { setSelected(selected); });
+          [this](const SelectionSet& selected) { setSelected(selected); });
   connect(hierarchy_widget_,
           &BrowserWidget::removeSelect,
           this,
           &MainWindow::removeSelected);
   connect(hierarchy_widget_,
           &BrowserWidget::highlight,
-          [=](const SelectionSet& selected) { addHighlighted(selected); });
+          [this](const SelectionSet& selected) { addHighlighted(selected); });
   connect(hierarchy_widget_,
           &BrowserWidget::removeHighlight,
           this,
@@ -337,13 +337,13 @@ MainWindow::MainWindow(bool load_settings, QWidget* parent)
 
   connect(selection_browser_,
           &SelectHighlightWindow::clearHighlightedItems,
-          [=](const QList<const Selected*>& selected) {
+          [this](const QList<const Selected*>& selected) {
             removeFromHighlighted(selected);
           });
 
   connect(selection_browser_,
           &SelectHighlightWindow::highlightSelectedItemsSig,
-          [=](const QList<const Selected*>& items) {
+          [this](const QList<const Selected*>& items) {
             updateHighlightedSet(items);
           });
 

src/gui/src/timingWidget.cpp

@@ -131,7 +131,7 @@ void TimingWidget::setColumnDisplayMenu()
     action->setCheckable(true);
     action->setChecked(true);
 
-    connect(action, &QAction::triggered, this, [=](bool checked) {
+    connect(action, &QAction::triggered, this, [=, this](bool checked) {
       hideColumn(column_index, checked);
     });
 

src/mpl/src/object.h

@@ -502,7 +502,7 @@ struct BundledNet
     this->weight = weight;
   }
 
-  bool operator==(const BundledNet& net)
+  bool operator==(const BundledNet& net) const
   {
     return (terminals.first == net.terminals.first)
            && (terminals.second == net.terminals.second);

src/rsz/src/BaseMove.cc

@@ -637,7 +637,7 @@ LibertyCell* BaseMove::upsizeCell(LibertyPort* in_port,
     const char* in_port_name = in_port->name();
     const char* drvr_port_name = drvr_port->name();
     sort(swappable_cells,
-         [=](const LibertyCell* cell1, const LibertyCell* cell2) {
+         [=, this](const LibertyCell* cell1, const LibertyCell* cell2) {
            LibertyPort* port1
                = cell1->findLibertyPort(drvr_port_name)->cornerPort(lib_ap);
            LibertyPort* port2

src/rsz/src/CloneMove.cc

@@ -142,8 +142,8 @@ bool CloneMove::doMove(const Path* drvr_path,
 
   sort(fanout_slacks.begin(),
        fanout_slacks.end(),
-       [=](const pair<Vertex*, Slack>& pair1,
-           const pair<Vertex*, Slack>& pair2) {
+       [this](const pair<Vertex*, Slack>& pair1,
+              const pair<Vertex*, Slack>& pair2) {
          return (pair1.second > pair2.second
                  || (pair1.second == pair2.second
                      && network_->pathNameLess(pair1.first->pin(),