gui: minor fix from code review feedback

Signed-off-by: LucasYuki <[email protected]>

Author: LucasYuki

src/gui/src/qComboCheckBoxes.cpp

@@ -7,20 +7,20 @@
 
 namespace gui {
 
-qComboCheckBoxes::qComboCheckBoxes(const char* name,
-                                   const char* all_text,
+qComboCheckBoxes::qComboCheckBoxes(const std::string& name,
+                                   const std::string& all_text,
                                    QWidget* parent)
     : QComboBox(parent),
-      name_item_(new QStandardItem(name)),
-      all_item_(new QStandardItem(all_text)),
+      name_item_(new QStandardItem(QString::fromStdString(name))),
+      all_item_(new QStandardItem(QString::fromStdString(all_text))),
       model_(new QStandardItemModel(this)),
       updating_check_boxes_(false)
 {
   setup();
 }
 
 qComboCheckBoxes::qComboCheckBoxes(const QString& name,
-                                   const char* all_text,
+                                   const QString& all_text,
                                    QWidget* parent)
     : QComboBox(parent),
       name_item_(new QStandardItem(name)),

src/gui/src/qComboCheckBoxes.h

@@ -20,20 +20,26 @@ class qComboCheckBoxes : public QComboBox
 {
   Q_OBJECT
  public:
-  qComboCheckBoxes(const char* name,
-                   const char* all_text = "All",
+  qComboCheckBoxes(const std::string& name,
+                   const std::string& all_text = "All",
                    QWidget* parent = nullptr);
   qComboCheckBoxes(const QString& name,
-                   const char* all_text = "All",
+                   const QString& all_text = "All",
                    QWidget* parent = nullptr);
   void clear();
 
-  void setName(const char* name) { name_item_->setText(QString(name)); };
+  void setName(const std::string& name)
+  {
+    name_item_->setText(QString::fromStdString(name));
+  };
   void setName(const QString& name) { name_item_->setText(name); };
   QString getName() { return name_item_->text(); };
   QStandardItem* getNameItem() { return name_item_; };
 
-  void setAllText(const char* text) { all_item_->setText(QString(text)); };
+  void setAllText(const std::string& text)
+  {
+    all_item_->setText(QString::fromStdString(text));
+  };
   void setAllText(const QString& text) { all_item_->setText(text); };
   QString getAllText() { return all_item_->text(); };
   QStandardItem* getAllItem() { return all_item_; };

src/gui/src/staGui.cpp

@@ -3,6 +3,7 @@
 
 #include "staGui.h"
 
+#include <qchar.h>
 #include <qglobal.h>
 
 #include <QAbstractItemView>
@@ -1111,7 +1112,9 @@ TimingControlsDialog::TimingControlsDialog(QWidget* parent)
       layout_(new QFormLayout),
       path_count_spin_box_(new QSpinBox(this)),
       corner_box_(new QComboBox(this)),
-      clock_box_(new qComboCheckBoxes("Select Clocks", "All Clocks", this)),
+      clock_box_(new qComboCheckBoxes(QString("Select Clocks"),
+                                      QString("All Clocks"),
+                                      this)),
       unconstrained_(new QCheckBox(this)),
       one_path_per_endpoint_(new QCheckBox(this)),
       expand_clk_(new QCheckBox(this)),
@@ -1250,8 +1253,8 @@ void TimingControlsDialog::populate()
   for (auto clk : *sta_->getClocks()) {
     QString clk_name = clk->name();
 
-    if (clks_.count(clk_name) != 1) {
-      clks_[clk_name] = clk;
+    if (qstring_to_clk_.count(clk_name) != 1) {
+      qstring_to_clk_[clk_name] = clk;
       QStandardItem* item = new QStandardItem(clk_name);
 
       item->setFlags(Qt::ItemIsUserCheckable | Qt::ItemIsEnabled);
@@ -1345,8 +1348,8 @@ std::vector<std::set<const sta::Pin*>> TimingControlsDialog::getThruPins() const
 
 void TimingControlsDialog::getClocks(sta::ClockSet* clock_set) const
 {
-  for (const auto& clk : clock_box_->selectedItems()) {
-    clock_set->insert(clks_[clk]);
+  for (const auto& clk_name : clock_box_->selectedItems()) {
+    clock_set->insert(qstring_to_clk_[clk_name]);
   }
 }
 

src/gui/src/staGui.h

@@ -12,9 +12,9 @@
 #include <QDialog>
 #include <QFormLayout>
 #include <QHBoxLayout>
+#include <QHash>
 #include <QListWidget>
 #include <QSpinBox>
-#include <QHash>
 #include <map>
 #include <memory>
 #include <set>
@@ -437,7 +437,7 @@ class TimingControlsDialog : public QDialog
   PinSetWidget* from_;
   std::vector<PinSetWidget*> thru_;
   PinSetWidget* to_;
-  QHash<QString, sta::Clock*> clks_;
+  QHash<QString, sta::Clock*> qstring_to_clk_;
 
   static constexpr int kThruStartRow = 4;
 

src/gui/src/staGuiInterface.cpp

@@ -1026,7 +1026,8 @@ std::unique_ptr<TimingPathNode> STAGuiInterface::getTimingNode(
 
 TimingPathList STAGuiInterface::getTimingPaths(const sta::Pin* thru) const
 {
-  return getTimingPaths({}, {{thru}}, {}, "" /* path group name */, nullptr);
+  return getTimingPaths(
+      {}, {{thru}}, {}, "" /* path group name */, nullptr /* clockset */);
 }
 
 TimingPathList STAGuiInterface::getTimingPaths(