Merge remote-tracking branch 'origin' into ant_use_pin_on_dsu_graph

Signed-off-by: luis201420 <[email protected]>

Author: luis201420

WORKSPACE

@@ -8,9 +8,9 @@ workspace(name = "openroad")
 
 load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
 
-rules_hdl_git_hash = "80266603b55778dd30531c9b286152a7b664fbb7"
+rules_hdl_git_hash = "56da46a87e8e5a4dbe84c0bbe5d00e92b936494f"
 
-rules_hdl_git_sha256 = "38f04d38cfbf46c52643325b496673d607ce5ea6fda99dc1dfa3997a520bb0c2"
+rules_hdl_git_sha256 = "dc184ad0fe92f315eb5600fb3293c94ce1fce3fc1d0fd79400107038ed917d70"
 
 http_archive(
     name = "rules_hdl",

src/Metrics.tcl

@@ -36,7 +36,6 @@ proc report_tns_metric { args } {
 
 define_cmd_args "report_worst_slack_metric" {[-setup]|[-hold]}
 proc report_worst_slack_metric { args } {
-  global sta_report_default_digits
   parse_key_args "report_worst_slack_metric" args keys {} flags {-setup -hold}
 
   set min_max "-max"
@@ -53,7 +52,6 @@ proc report_worst_slack_metric { args } {
 
 define_cmd_args "report_worst_negative_slack_metric" {[-setup]|[-hold]}
 proc report_worst_negative_slack_metric { args } {
-  global sta_report_default_digits
   parse_key_args "report_worst_negative_slack_metric" args keys {} flags {-setup -hold}
 
   set min_max "-max"
@@ -68,6 +66,51 @@ proc report_worst_negative_slack_metric { args } {
   utl::metric_float $metric_name [worst_negative_slack $min_max]
 }
 
+define_cmd_args "report_fmax_metric" {}
+proc report_fmax_metric { args } {
+  parse_key_args "report_fmax_metric" args keys {} flags {}
+
+  # Taken from: https://github.com/siliconcompiler/siliconcompiler/blob/e46c702df218c93483b951533fe00bcf01cf772d/siliconcompiler/tools/openroad/scripts/common/reports.tcl#L98
+  # Modeled on: https://github.com/The-OpenROAD-Project/OpenSTA/blob/f913c3ddbb3e7b4364ed4437c65ac78c4da9174b/tcl/Search.tcl#L1078
+  set fmax_metric 0
+  foreach clk [sta::sort_by_name [all_clocks]] {
+    set clk_name [get_name $clk]
+    set min_period [sta::find_clk_min_period $clk 1]
+    if { $min_period == 0.0 } {
+      continue
+    }
+    set fmax [expr { 1.0 / $min_period }]
+    utl::metric_float "timing__fmax__clock:${clk_name}" $fmax
+    puts "$clk_name fmax = [format %.2f [expr { $fmax / 1e6 }]] MHz"
+    set fmax_metric [expr { max($fmax_metric, $fmax) }]
+  }
+  if { $fmax_metric == 0 } {
+    # attempt to compute based on combinatorial path
+    set fmax_valid true
+    set max_path [find_timing_paths -unconstrained -path_delay max]
+    if { $max_path == "" } {
+      set fmax_valid false
+    } else {
+      set max_path_delay [$max_path data_arrival_time]
+    }
+    set min_path [find_timing_paths -unconstrained -path_delay min]
+    if { $min_path == "" } {
+      set fmax_valid false
+    } else {
+      set min_path_delay [$min_path data_arrival_time]
+    }
+    if { $fmax_valid } {
+      set path_delay [expr { $max_path_delay - min(0, $min_path_delay) }]
+      if { $path_delay > 0 } {
+        set fmax_metric [expr { 1.0 / $path_delay }]
+      }
+    }
+  }
+  if { $fmax_metric > 0 } {
+    utl::metric_float "timing__fmax" $fmax_metric
+  }
+}
+
 # From https://wiki.tcl-lang.org/page/Inf
 proc ::tcl::mathfunc::finite { x } {
   expr { [string is double -strict $x] && $x == $x && $x + 1 != $x }

src/gpl/src/placerBase.cpp

@@ -1015,10 +1015,24 @@ void PlacerBase::init()
       continue;
     }
 
-    if (inst->dbInst() && inst->dbInst()->getGroup() != group_) {
+    odb::dbInst* db_inst = inst->dbInst();
+    if (!db_inst) {
       continue;
     }
 
+    odb::dbGroup* db_inst_group = db_inst->getGroup();
+    if (group_ == nullptr) {
+      if (db_inst_group
+          && db_inst_group->getType() != odb::dbGroupType::VISUAL_DEBUG) {
+        continue;
+      }
+    } else {
+      if (!db_inst_group || db_inst_group != group_
+          || db_inst_group->getType() == odb::dbGroupType::VISUAL_DEBUG) {
+        continue;
+      }
+    }
+
     if (inst->isFixed()) {
       // Check whether fixed instance is
       // within the corearea
@@ -1196,9 +1210,23 @@ void PlacerBase::initInstsForUnusableSites()
     if (!inst->isFixed()) {
       continue;
     }
-    if (inst->dbInst() && inst->dbInst()->getGroup() != group_) {
+    odb::dbInst* db_inst = inst->dbInst();
+    if (!db_inst) {
       continue;
     }
+
+    odb::dbGroup* db_inst_group = db_inst->getGroup();
+    if (group_ == nullptr) {
+      if (db_inst_group
+          && db_inst_group->getType() != odb::dbGroupType::VISUAL_DEBUG) {
+        continue;
+      }
+    } else {
+      if (!db_inst_group || db_inst_group != group_
+          || db_inst_group->getType() == odb::dbGroupType::VISUAL_DEBUG) {
+        continue;
+      }
+    }
     std::pair<int, int> pairX = getMinMaxIdx(
         inst->lx(), inst->ux(), die_.coreLx(), siteSizeX_, 0, siteCountX);
     std::pair<int, int> pairY = getMinMaxIdx(

src/grt/src/fastroute/include/DataType.h

@@ -48,7 +48,7 @@ enum class EdgeDirection
 struct Segment  // A Segment is a 2-pin connection
 {
   Segment(int16_t x1, int16_t y1, int16_t x2, int16_t y2, int8_t cost)
-      : x1(x1), y1(y1), x2(x2), y2(y2), cost(cost)
+      : x1(x1), y1(y1), x2(x2), y2(y2), cost(cost), xFirst(false), HVH(false)
   {
   }
   const int16_t x1, y1, x2, y2;  // coordinates of two endpoints (x1 <= x2)

src/gui/src/gui.cpp

@@ -504,7 +504,6 @@ int Gui::select(const std::string& type,
           if (
 #if QT_VERSION >= QT_VERSION_CHECK(6, 0, 0)
               !reg_filter.match(QString::fromStdString(sel_name)).hasMatch()
-
 #else
               !reg_filter.exactMatch(QString::fromStdString(sel_name))
 #endif
@@ -516,7 +515,8 @@ int Gui::select(const std::string& type,
 
       if (!attribute.empty()) {
         bool is_valid_attribute = false;
-        Descriptor::Properties properties = descriptor->getProperties(sel);
+        Descriptor::Properties properties
+            = descriptor->getProperties(sel.getObject());
         if (filterSelectionProperties(
                 properties, attribute, value, is_valid_attribute)) {
           return;  // doesn't match the attribute filter