clang-tidy requested changes

Signed-off-by: osamahammad21 <[email protected]>

Author: osamahammad21

src/odb/include/odb/geom.h

@@ -110,7 +110,7 @@ class Cuboid
  public:
   Cuboid() = default;
   Cuboid(const Cuboid& other) = default;
-  Cuboid(Point3D p1, Point3D p2);
+  Cuboid(const Point3D& p1, const Point3D& p2);
   Cuboid(int x1, int y1, int z1, int x2, int y2, int z2);
 
   Cuboid& operator=(const Cuboid& b) = default;
@@ -182,7 +182,7 @@ class Cuboid
   bool inside(const Cuboid& b) const;
 
   // Return the point inside cuboid that is closest to pt.
-  Point3D closestPtInside(Point3D pt) const;
+  Point3D closestPtInside(const Point3D& pt) const;
 
   // Compute the union of this cuboid and a point.
   void merge(const Point3D& p, Cuboid& result);
@@ -1209,7 +1209,7 @@ inline Cuboid::Cuboid(const int x1,
   init(x1, y1, z1, x2, y2, z2);
 }
 
-inline Cuboid::Cuboid(const Point3D p1, const Point3D p2)
+inline Cuboid::Cuboid(const Point3D& p1, const Point3D& p2)
     : Cuboid(p1.x(), p1.y(), p1.z(), p2.x(), p2.y(), p2.z())
 {
 }
@@ -1267,10 +1267,10 @@ inline bool Cuboid::operator==(const Cuboid& b) const
          == std::tie(b.xlo_, b.ylo_, b.zlo_, b.xhi_, b.yhi_, b.zhi_);
 }
 
-inline bool Cuboid::operator<(const Cuboid& rhs) const
+inline bool Cuboid::operator<(const Cuboid& b) const
 {
   return std::tie(xlo_, ylo_, zlo_, xhi_, yhi_, zhi_)
-         < std::tie(rhs.xlo_, rhs.ylo_, rhs.zlo_, rhs.xhi_, rhs.yhi_, rhs.zhi_);
+         < std::tie(b.xlo_, b.ylo_, b.zlo_, b.xhi_, b.yhi_, b.zhi_);
 }
 
 inline void Cuboid::moveTo(int x, int y, int z)
@@ -1359,7 +1359,7 @@ inline bool Cuboid::inside(const Cuboid& b) const
          && (xhi_ > b.xhi_) && (yhi_ > b.yhi_) && (zhi_ > b.zhi_);
 }
 
-inline Point3D Cuboid::closestPtInside(const Point3D pt) const
+inline Point3D Cuboid::closestPtInside(const Point3D& pt) const
 {
   return Point3D(std::min(std::max(pt.x(), xMin()), xMax()),
                  std::min(std::max(pt.y(), yMin()), yMax()),

src/odb/src/3dblox/checker.cpp

@@ -1,5 +1,6 @@
 #include "checker.h"
 
+#include <cstddef>
 #include <functional>
 #include <map>
 #include <vector>

src/odb/src/db/dbChip.cpp

@@ -27,6 +27,8 @@
 #include "dbChipInstItr.h"
 #include "dbChipNet.h"
 #include "dbChipNetItr.h"
+#include "odb/dbObject.h"
+#include "odb/geom.h"
 // User Code End Includes
 namespace odb {
 template class dbTable<_dbChip>;

src/odb/src/db/dbChipInst.cpp

@@ -16,6 +16,7 @@
 #include "dbChipBumpInst.h"
 #include "dbChipRegionInst.h"
 #include "odb/dbTransform.h"
+#include "odb/geom.h"
 // User Code End Includes
 namespace odb {
 template class dbTable<_dbChipInst>;

src/odb/src/db/dbChipRegion.cpp

@@ -18,6 +18,7 @@
 #include "dbChipInst.h"
 #include "dbChipRegionInst.h"
 #include "dbTech.h"
+#include "odb/geom.h"
 #include "utl/Logger.h"
 // User Code End Includes
 namespace odb {

src/odb/src/db/dbChipRegionInst.cpp

@@ -15,6 +15,7 @@
 #include "dbChipBumpInstItr.h"
 #include "dbChipInst.h"
 #include "odb/dbTransform.h"
+#include "odb/geom.h"
 // User Code End Includes
 namespace odb {
 template class dbTable<_dbChipRegionInst>;

src/odb/src/db/dbMarker.cpp

@@ -23,6 +23,7 @@
 #include "dbVector.h"
 #include "odb/db.h"
 // User Code Begin Includes
+#include "dbCore.h"
 #include "odb/dbBlockCallBackObj.h"
 // User Code End Includes
 namespace odb {
@@ -770,10 +771,6 @@ std::set<dbObject*> dbMarker::getSources() const
         objs.insert(table->getObject(id));
       }
     }
-  } else {
-    for (const auto& [db_type, id] : marker->sources_) {
-      // owned by chip
-    }
   }
   return objs;
 }

src/odb/src/db/dbMarkerCategory.cpp

@@ -22,6 +22,7 @@
 #include "dbChip.h"
 #include "dbHashTable.hpp"
 #include "odb/dbBlockCallBackObj.h"
+#include "odb/dbObject.h"
 // User Code End Includes
 namespace odb {
 template class dbTable<_dbMarkerCategory>;
@@ -775,6 +776,13 @@ dbMarkerCategory* dbMarkerCategory::create(dbChip* chip, const char* name)
 
   parent->marker_categories_map_[name] = _category->getImpl()->getId();
 
+  _dbBlock* block = (_dbBlock*) chip->getBlock();
+  if (block) {
+    for (auto cb : block->_callbacks) {
+      cb->inDbMarkerCategoryCreate((dbMarkerCategory*) _category);
+    }
+  }
+
   return (dbMarkerCategory*) _category;
 }
 
@@ -807,43 +815,19 @@ dbMarkerCategory* dbMarkerCategory::createOrReplace(dbChip* chip,
 
 dbMarkerCategory* dbMarkerCategory::create(dbBlock* block, const char* name)
 {
-  dbChip* chip = block->getChip();
-  dbMarkerCategory* category = create(chip, name);
-  if (category == nullptr) {
-    return nullptr;
-  }
-  for (auto cb : ((_dbBlock*) block)->_callbacks) {
-    cb->inDbMarkerCategoryCreate(category);
-  }
-  return category;
+  return create(block->getChip(), name);
 }
 
 dbMarkerCategory* dbMarkerCategory::createOrGet(dbBlock* block,
                                                 const char* name)
 {
-  _dbChip* parent = (_dbChip*) block->getChip();
-
-  auto it = parent->marker_categories_map_.find(name);
-  if (it != parent->marker_categories_map_.end()) {
-    return (dbMarkerCategory*) parent->marker_categories_tbl_->getPtr(
-        it->second);
-  }
-
-  return create(block, name);
+  return createOrGet(block->getChip(), name);
 }
 
 dbMarkerCategory* dbMarkerCategory::createOrReplace(dbBlock* block,
                                                     const char* name)
 {
-  _dbChip* parent = (_dbChip*) block->getChip();
-
-  auto it = parent->marker_categories_map_.find(name);
-  if (it != parent->marker_categories_map_.end()) {
-    destroy(
-        (dbMarkerCategory*) parent->marker_categories_tbl_->getPtr(it->second));
-  }
-
-  return create(block, name);
+  return createOrReplace(block->getChip(), name);
 }
 
 dbMarkerCategory* dbMarkerCategory::create(dbMarkerCategory* category,
@@ -902,7 +886,7 @@ void dbMarkerCategory::destroy(dbMarkerCategory* category)
   if (_category->isTopCategory()) {
     _dbChip* _chip = (_dbChip*) _category->getOwner();
     if (_category->getBlock()) {
-      for (auto cb : ((_dbBlock*) _category->getBlock())->_callbacks) {
+      for (auto cb : _category->getBlock()->_callbacks) {
         cb->inDbMarkerCategoryDestroy(category);
       }
     }
@@ -913,8 +897,10 @@ void dbMarkerCategory::destroy(dbMarkerCategory* category)
     _dbMarkerCategory* parent = (_dbMarkerCategory*) _category->getOwner();
 
     _dbBlock* block = parent->getBlock();
-    for (auto cb : block->_callbacks) {
-      cb->inDbMarkerCategoryDestroy(category);
+    if (block) {
+      for (auto cb : block->_callbacks) {
+        cb->inDbMarkerCategoryDestroy(category);
+      }
     }
 
     parent->categories_hash_.remove(_category);

src/odb/src/db/dbUtil.h

@@ -2,8 +2,6 @@
 // Copyright (c) 2022-2025, The OpenROAD Authors
 #pragma once
 
-#include <fmt/ranges.h>
-
 #include <cstddef>
 #include <string>
 #include <vector>