ram: fixed clang-tidy and tclint comments

Signed-off-by: braydenl9988 <[email protected]>

Author: braydenlouie

src/ram/include/ram/ram.h

@@ -34,7 +34,7 @@ class RamGen
 {
  public:
   RamGen(sta::dbNetwork* network, odb::dbDatabase* db, Logger* logger);
-  ~RamGen();
+  ~RamGen() = default;
 
   void generate(int bytes_per_word,
                 int word_count,

src/ram/src/ram.cpp

@@ -12,8 +12,6 @@
 
 namespace ram {
 
-using odb::dbBlock;
-using odb::dbBPin;
 using odb::dbBTerm;
 using odb::dbInst;
 using odb::dbIoType;
@@ -33,8 +31,6 @@ RamGen::RamGen(sta::dbNetwork* network, odb::dbDatabase* db, Logger* logger)
 {
 }
 
-RamGen::~RamGen() = default;
-
 dbInst* RamGen::makeCellInst(
     Cell* cell,
     const std::string& prefix,
@@ -125,6 +121,7 @@ void RamGen::makeCellByte(Grid& ram_grid,
   for (int bit = first_byte; bit < first_byte + 8; ++bit) {
     auto name = fmt::format("{}.bit{}", prefix, bit);
     vector<dbNet*> outs;
+    outs.reserve(read_ports);
     for (int read_port = 0; read_port < read_ports; ++read_port) {
       outs.push_back(data_output[read_port][bit]->getNet());
     }
@@ -352,9 +349,7 @@ void RamGen::findMasters()
   // for input buffers
   if (!buffer_cell_) {
     buffer_cell_ = findMaster(
-        [](sta::LibertyPort* port) {
-          return port->libertyCell()->isBuffer();
-        },
+        [](sta::LibertyPort* port) { return port->libertyCell()->isBuffer(); },
         "buffer");
   }
 }
@@ -383,7 +378,7 @@ void RamGen::generate(const int bytes_per_word,
   auto chip = db_->getChip();
   if (!chip) {
     chip = odb::dbChip::create(
-        db_, db_->getTech(), ram_name.c_str(), odb::dbChip::ChipType::DIE);
+        db_, db_->getTech(), ram_name, odb::dbChip::ChipType::DIE);
   }
 
   block_ = chip->getBlock();
@@ -545,14 +540,14 @@ void RamGen::generate(const int bytes_per_word,
 
   int num_sites = ram_grid.getRowWidth() / db_sites->getWidth();
   for (int i = 0; i <= word_count; ++i) {  // extra for the layer of buffers
-    auto row_name = fmt::format("RAM_ROW{}", i).c_str();
+    auto row_name = fmt::format("RAM_ROW{}", i);
     auto y_coord = i * ram_grid.getHeight();
     auto row_orient = odb::dbOrientType::R0;
     if (i % 2 == 1) {
       row_orient = odb::dbOrientType::MX;
     }
     dbRow::create(block_,
-                  row_name,
+                  row_name.c_str(),
                   db_sites,
                   ram_origin.getX(),
                   y_coord,

src/ram/test/make_8x8.tcl

@@ -9,8 +9,8 @@ generate_ram_netlist \
     -bytes_per_word 1 \
     -word_count 8 \
     -read_ports 2 \
-    -storage_cell sky130_fd_sc_hd__dlxtp_1 
-#    -tristate_cell sky130_fd_sc_hd__ebufn_2 
+    -storage_cell sky130_fd_sc_hd__dlxtp_1
+#    -tristate_cell sky130_fd_sc_hd__ebufn_2
 #    -inv_cell sky130_fd_sc_hd__inv_1
 
 ord::design_created
@@ -19,8 +19,9 @@ ord::design_created
 # set_io_pin_constraint -direction output -region top:*
 # set_io_pin_constraint -pin_names {D[0] D[1]} -region top:*
 # place_pins -hor_layers met3 -ver_layers met2
-# 
-# filler_placement {sky130_fd_sc_hd__fill_1 sky130_fd_sc_hd__fill_2 sky130_fd_sc_hd__fill_4 sky130_fd_sc_hd__fill_8}
+#
+# filler_placement {sky130_fd_sc_hd__fill_1 sky130_fd_sc_hd__fill_2 \
+# 	sky130_fd_sc_hd__fill_4 sky130_fd_sc_hd__fill_8}
 
 set def_file [make_result_file make_8x8.def]
 write_def $def_file