Merge pull request #7737 from AcKoucher/gui-fix-charts

gadfort · web-flow · commit e9e1268f623f · 2025-07-07T13:06:36.000-04:00
gui: fix flipped negative buckets
diff --git a/src/gui/src/chartsWidget.cpp b/src/gui/src/chartsWidget.cpp
@@ -414,7 +414,7 @@ void HistogramView::populateBuckets(
   for (int bin = 0; bin < histogram_->getBinsCount(); bin++) {
     const auto& [bin_start, bin_end] = histogram_->getBinRange(bin);
     if ((bin_start + bin_end) / 2 < 0) {
-      buckets_.negative.push_front(pin_bins[bin]);
+      buckets_.negative.push_back(pin_bins[bin]);
     } else {
       buckets_.positive.push_back(pin_bins[bin]);
     }

Original file line number	Diff line number	Diff line change
`@@ -414,7 +414,7 @@ void HistogramView::populateBuckets(`
`414`	`414`	`for (int bin = 0; bin < histogram_->getBinsCount(); bin++) {`
`415`	`415`	`const auto& [bin_start, bin_end] = histogram_->getBinRange(bin);`
`416`	`416`	`if ((bin_start + bin_end) / 2 < 0) {`
`417`		`- buckets_.negative.push_front(pin_bins[bin]);`
	`417`	`+ buckets_.negative.push_back(pin_bins[bin]);`
`418`	`418`	`} else {`
`419`	`419`	`buckets_.positive.push_back(pin_bins[bin]);`
`420`	`420`	`}`