boost: include bind.hpp where needed; Use single-redirect geometry header.

Include header needed to use boost::bind where missing

Instead of `boost/geometry.hpp`, include `boost/geometry/geometry.hpp`.
The reason is that boost/geometry.hpp is a header that just
includes the boost/geometry/geometry.hpp header, which
in turn is a header that includes a bunch of the actual
implementation headers.

The misc-include-cleaner complains about symbols it doesn't
see, but that is because it is picky that it actualy wants the
direct header that defines a thing. With redirecting headers, there
is a way to add a `IWHY pragma: export` to tell that it forwards
includes (and I'll send a pull request upstream
to boost to make it happen), but that only works over one
level. So we need to include the header that actually has
all the forwarding includes (`"boost/geometry/geometry.hpp"`),
not the header that forwards to the forwarding header
(`"boost/geometry.hpp"`).

Until I have sent a fix boost-upstream to add the IWYU
pragmas, that won't do anything yet, but we're prepared.

Signed-off-by: Henner Zeller <[email protected]>

Author: hzeller

src/Main.cc

@@ -18,7 +18,7 @@
 #include <string>
 #include <system_error>
 
-#include "boost/stacktrace.hpp"
+#include "boost/stacktrace/stacktrace.hpp"
 #ifdef ENABLE_READLINE
 // If you get an error on this include be sure you have
 //   the package tcl-tclreadline-devel installed

src/dft/src/architect/Opt.cpp

@@ -12,8 +12,8 @@
 #include <vector>
 
 #include "ClockDomain.hh"
-#include "boost/geometry.hpp"
 #include "boost/geometry/geometries/register/point.hpp"
+#include "boost/geometry/geometry.hpp"
 #include "boost/geometry/index/rtree.hpp"
 
 namespace bg = boost::geometry;

src/dpl/include/dpl/Opendp.h

@@ -15,7 +15,7 @@
 #include <utility>  // pair
 #include <vector>
 
-#include "boost/geometry.hpp"
+#include "boost/geometry/geometry.hpp"
 #include "boost/geometry/index/rtree.hpp"
 #include "odb/db.h"
 

src/drt/src/gc/FlexGC_main.cpp

@@ -13,7 +13,7 @@
 #include <utility>
 #include <vector>
 
-#include "boost/geometry.hpp"
+#include "boost/geometry/geometry.hpp"
 #include "frProfileTask.h"
 #include "gc/FlexGC_impl.h"
 

src/dst/src/Distributed.cc

@@ -14,6 +14,7 @@
 #include "Worker.h"
 #include "boost/asio.hpp"
 #include "boost/asio/ip/tcp.hpp"
+#include "boost/bind/bind.hpp"
 #include "boost/system/system_error.hpp"
 #include "boost/thread/thread.hpp"
 #include "dst/JobCallBack.h"

src/dst/test/cpp/TestBalancer.cc

@@ -5,6 +5,7 @@
 #include "HelperCallBack.h"
 #include "LoadBalancer.h"
 #include "boost/asio.hpp"
+#include "boost/bind/bind.hpp"
 #include "boost/test/included/unit_test.hpp"
 #include "boost/thread/thread.hpp"
 #include "dst/BroadcastJobDescription.h"

src/dst/test/cpp/TestDistributed.cc

@@ -5,6 +5,7 @@
 
 #include "HelperCallBack.h"
 #include "boost/asio.hpp"
+#include "boost/bind/bind.hpp"
 #include "boost/test/included/unit_test.hpp"
 #include "boost/thread/thread.hpp"
 #include "dst/Distributed.h"

src/dst/test/cpp/TestWorker.cc

@@ -6,6 +6,7 @@
 #include "Worker.h"
 #include "boost/asio.hpp"
 #include "boost/asio/ip/tcp.hpp"
+#include "boost/bind/bind.hpp"
 #include "boost/system/system_error.hpp"
 #include "boost/test/included/unit_test.hpp"
 #include "boost/thread/thread.hpp"

src/grt/src/RepairAntennas.h

@@ -12,7 +12,7 @@
 #include <vector>
 
 #include "ant/AntennaChecker.hh"
-#include "boost/geometry.hpp"
+#include "boost/geometry/geometry.hpp"
 #include "boost/geometry/index/rtree.hpp"
 #include "boost/iterator/function_output_iterator.hpp"
 #include "dpl/Opendp.h"

src/gui/src/layoutViewer.cpp

@@ -36,7 +36,7 @@
 #include <utility>
 #include <vector>
 
-#include "boost/geometry.hpp"
+#include "boost/geometry/geometry.hpp"
 #include "dbDescriptors.h"
 #include "gui/gui.h"
 #include "gui_utils.h"