fix readability-container-contains

Signed-off-by: Matt Liberty <[email protected]>

Author: maliberty

src/cts/src/TritonCTS.cpp

@@ -249,7 +249,7 @@ void TritonCTS::checkCharacterization()
   techChar_->forEachWireSegment([&](unsigned idx, const WireSegment& wireSeg) {
     for (int buf = 0; buf < wireSeg.getNumBuffers(); ++buf) {
       const std::string& master = wireSeg.getBufferMaster(buf);
-      if (visitedMasters.count(master) == 0) {
+      if (!visitedMasters.contains(master)) {
         if (masterExists(master)) {
           visitedMasters.insert(master);
         } else {

src/dpl/src/Place.cpp

@@ -792,7 +792,7 @@ PixelPt Opendp::searchNearestSite(const Node* cell,
     for (GridPt offset : neighbors) {
       GridPt neighbor = {nearest.x + offset.x, nearest.y + offset.y};
       // Check if it was already put in the queue
-      if (visited.count(neighbor) > 0) {
+      if (visited.contains(neighbor)) {
         continue;
       }
       // Check limits

src/gui/src/bufferTreeDescriptor.cpp

@@ -235,7 +235,7 @@ Descriptor::Actions BufferTreeDescriptor::getActions(
   Descriptor::Actions actions;
   bool is_focus = true;
   for (auto* net : bnet.getNets()) {
-    is_focus &= focus_nets_.count(net) != 0;
+    is_focus &= focus_nets_.contains(net);
   }
   if (!is_focus) {
     actions.push_back(Descriptor::Action{"Focus", [this, gui, &bnet]() {
@@ -261,7 +261,7 @@ Descriptor::Actions BufferTreeDescriptor::getActions(
                                            bool guides_on = false;
                                            for (auto* net : bnet.getNets()) {
                                              guides_on
-                                                 |= guide_nets_.count(net) != 0;
+                                                 |= guide_nets_.contains(net);
                                            }
                                            for (auto* net : bnet.getNets()) {
                                              if (!guides_on) {
@@ -282,7 +282,7 @@ Descriptor::Actions BufferTreeDescriptor::getActions(
         Descriptor::Action{"Tracks", [this, gui, &bnet]() {
                              bool tracks_on = false;
                              for (auto* net : bnet.getNets()) {
-                               tracks_on |= tracks_nets_.count(net) != 0;
+                               tracks_on |= tracks_nets_.contains(net);
                              }
                              for (auto* net : bnet.getNets()) {
                                if (!tracks_on) {

src/gui/src/dbDescriptors.cpp

@@ -1923,7 +1923,7 @@ Descriptor::Actions DbNetDescriptor::getActions(const std::any& object) const
 
   auto* gui = Gui::get();
   Descriptor::Actions actions;
-  if (focus_nets_.count(net) == 0) {
+  if (!focus_nets_.contains(net)) {
     actions.push_back(Descriptor::Action{"Focus", [this, gui, net]() {
                                            gui->addFocusNet(net);
                                            return makeSelected(net);
@@ -1963,7 +1963,7 @@ Descriptor::Actions DbNetDescriptor::getActions(const std::any& object) const
                        }});
   }
   if (!net->getGuides().empty()) {
-    if (guide_nets_.count(net) == 0) {
+    if (!guide_nets_.contains(net)) {
       actions.push_back(
           Descriptor::Action{"Show Route Guides", [this, gui, net]() {
                                gui->addRouteGuides(net);
@@ -1978,7 +1978,7 @@ Descriptor::Actions DbNetDescriptor::getActions(const std::any& object) const
     }
   }
   if (!net->getTracks().empty()) {
-    if (tracks_nets_.count(net) == 0) {
+    if (!tracks_nets_.contains(net)) {
       actions.push_back(Descriptor::Action{"Show Tracks", [this, gui, net]() {
                                              gui->addNetTracks(net);
                                              return makeSelected(net);

src/gui/src/displayControls.cpp

@@ -1922,7 +1922,7 @@ QFont DisplayControls::ioPinMarkersFont() const
 
 void DisplayControls::registerRenderer(Renderer* renderer)
 {
-  if (custom_controls_.count(renderer) != 0) {
+  if (custom_controls_.contains(renderer)) {
     // already registered
     return;
   }
@@ -2023,7 +2023,7 @@ void DisplayControls::unregisterRenderer(Renderer* renderer)
 {
   saveRendererState(renderer);
 
-  if (custom_controls_.count(renderer) == 0) {
+  if (!custom_controls_.contains(renderer)) {
     return;
   }
 
@@ -2304,7 +2304,7 @@ void DisplayControls::setOnlyVisibleLayers(
   }
 
   for (auto* layer : layers) {
-    if (layer_controls_.count(layer) != 0) {
+    if (layer_controls_.contains(layer)) {
       layer_controls_[layer].visible->setCheckState(Qt::Checked);
     }
   }

src/gui/src/gui.cpp

@@ -242,7 +242,7 @@ void Gui::registerRenderer(Renderer* renderer)
 
 void Gui::unregisterRenderer(Renderer* renderer)
 {
-  if (renderers_.count(renderer) == 0) {
+  if (!renderers_.contains(renderer)) {
     return;
   }
 
@@ -944,7 +944,7 @@ void Gui::registerHeatMap(HeatMapDataSource* heatmap)
 
 void Gui::unregisterHeatMap(HeatMapDataSource* heatmap)
 {
-  if (heat_maps_.count(heatmap) == 0) {
+  if (!heat_maps_.contains(heatmap)) {
     return;
   }
 
@@ -994,7 +994,7 @@ void Gui::setHeatMapSetting(const std::string& name,
   } else {
     auto settings = source->getSettings();
 
-    if (settings.count(option) == 0) {
+    if (!settings.contains(option)) {
       QStringList options;
       options.append(QString::fromStdString(rebuild_map_option));
       for (const auto& [key, kv] : settings) {
@@ -1065,7 +1065,7 @@ Renderer::Setting Gui::getHeatMapSetting(const std::string& name,
 
   auto settings = source->getSettings();
 
-  if (settings.count(option) == 0) {
+  if (!settings.contains(option)) {
     QStringList options;
     for (const auto& [key, kv] : settings) {
       options.append(QString::fromStdString(key));

src/gui/src/layoutViewer.cpp

@@ -1080,7 +1080,7 @@ Selected LayoutViewer::selectAtPoint(const odb::Point& pt_dbu)
     std::vector<bool> is_selected;
     is_selected.reserve(selections.size());
     for (auto& sel : selections) {
-      is_selected.push_back(selected_.count(sel) != 0);
+      is_selected.push_back(selected_.contains(sel));
     }
     if (std::all_of(
             is_selected.begin(), is_selected.end(), [](bool b) { return b; })) {

src/gui/src/mainWindow.cpp

@@ -924,9 +924,9 @@ std::string MainWindow::addToolbarButton(const std::string& name,
       // default to "buttonX" naming
       key = "button" + std::to_string(key_idx);
       key_idx++;
-    } while (buttons_.count(key) != 0);
+    } while (buttons_.contains(key));
   } else {
-    if (buttons_.count(name) != 0) {
+    if (buttons_.contains(name)) {
       logger_->error(utl::GUI, 22, "Button {} already defined.", name);
     }
     key = name;
@@ -951,7 +951,7 @@ std::string MainWindow::addToolbarButton(const std::string& name,
 
 void MainWindow::removeToolbarButton(const std::string& name)
 {
-  if (buttons_.count(name) == 0) {
+  if (!buttons_.contains(name)b) {
     return;
   }
 
@@ -1020,9 +1020,9 @@ std::string MainWindow::addMenuItem(const std::string& name,
       // default to "actionX" naming
       key = "action" + std::to_string(key_idx);
       key_idx++;
-    } while (menu_actions_.count(key) != 0);
+    } while (menu_actions_.contains(key));
   } else {
-    if (menu_actions_.count(name) != 0) {
+    if (menu_actions_.contains(name)) {
       logger_->error(utl::GUI, 25, "Menu action {} already defined.", name);
     }
     key = name;
@@ -1081,7 +1081,7 @@ void MainWindow::removeMenu(QMenu* menu)
 
 void MainWindow::removeMenuItem(const std::string& name)
 {
-  if (menu_actions_.count(name) == 0) {
+  if (!menu_actions_.contains(name)) {
     return;
   }
 

src/gui/src/staGui.cpp

@@ -792,7 +792,7 @@ void TimingConeRenderer::drawObjects(gui::Painter& painter)
         odb::dbInst* inst = pin->getPinAsITerm()->getInst();
 
         if (inst != nullptr) {
-          if (instances.count(inst) == 0) {
+          if (!instances.contains(inst)) {
             instances[inst] = pin.get();
           } else {
             auto& worst_pin = instances[inst];
@@ -1377,4 +1377,4 @@ const sta::ClockSet* TimingControlsDialog::getClocks()
   return &selected_clocks_;
 }
 
-}  // namespace gui
+}  // namespace gui

src/gui/src/staGuiInterface.cpp

@@ -1348,7 +1348,7 @@ ConeDepthMap STAGuiInterface::buildConeConnectivity(
 
   for (const auto& [level, pin_list] : map) {
     int next_level = level + 1;
-    if (map.count(next_level) == 0) {
+    if (!map.contains(next_level)) {
       break;
     }