Skip to content

Commit ee2fa06

Browse files
hongtedhongted
committed
Tagged bazel tests that fail due to compiler/stdlib/build differences as manual.
Signed-off-by: Ted Hong <[email protected]>
1 parent b82c4dc commit ee2fa06

File tree

14 files changed

+139
-15
lines changed

14 files changed

+139
-15
lines changed

‎BUILD.bazel‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -231,7 +231,7 @@ genrule(
231231

232232
tcl_encode(
233233
name = "openroad_tcl",
234-
srcs = ["//src/sta:tcl_util"] +[
234+
srcs = ["//src/sta:tcl_util"] + [
235235
"src/Metrics.tcl",
236236
"src/OpenRoad.tcl",
237237
],

‎src/cts/test/BUILD‎

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,16 @@ MANUAL_TESTS = [
5353
"cts_readme_msgs_check",
5454
]
5555

56+
# TODO: Enable once difference between bazel and ctest is resolved.
57+
MANUAL_FOR_BAZEL_TESTS = [
58+
"array",
59+
"array_ins_delay",
60+
"array_no_blockages",
61+
"array_repair_clock_nets",
62+
"gated_clock4",
63+
"simple_test_hier",
64+
]
65+
5666
ALL_TESTS = COMPULSORY_TESTS + MANUAL_TESTS
5767

5868
filegroup(
@@ -175,7 +185,8 @@ filegroup(
175185
regression_test(
176186
name = test_name,
177187
data = [":" + test_name + "_resources"],
178-
tags = [] if test_name in COMPULSORY_TESTS else ["manual"],
188+
tags = ["manual"] if test_name in MANUAL_TESTS or
189+
test_name in MANUAL_FOR_BAZEL_TESTS else [],
179190
visibility = ["//visibility:public"],
180191
)
181192
for test_name in ALL_TESTS

‎src/dpl/test/BUILD‎

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,6 +93,16 @@ MANUAL_TESTS = [
9393
"dpl_readme_msgs_check",
9494
]
9595

96+
# TODO: Enable once difference between bazel and ctest is resolved.
97+
MANUAL_FOR_BAZEL_TESTS = [
98+
"aes",
99+
"cell_on_block2",
100+
"gcd",
101+
"ibex",
102+
"mirror1",
103+
"obstruction2",
104+
]
105+
96106
ALL_TESTS = COMPULSORY_TESTS + MANUAL_TESTS
97107

98108
filegroup(
@@ -249,7 +259,8 @@ filegroup(
249259
regression_test(
250260
name = test_name,
251261
data = [":" + test_name + "_resources"],
252-
tags = [] if test_name in COMPULSORY_TESTS else ["manual"],
262+
tags = ["manual"] if test_name in MANUAL_TESTS or
263+
test_name in MANUAL_FOR_BAZEL_TESTS else [],
253264
visibility = ["//visibility:public"],
254265
)
255266
for test_name in ALL_TESTS

‎src/drt/test/BUILD‎

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,18 @@ MANUAL_TESTS = [
2929
"drt_readme_msgs_check",
3030
]
3131

32+
# TODO: Enable once difference between bazel and ctest is resolved.
33+
MANUAL_FOR_BAZEL_TESTS = [
34+
"drc_test",
35+
"ispd18_sample",
36+
"ispd18_sample_incr",
37+
"ndr_vias1",
38+
"ndr_vias2",
39+
"ndr_vias3",
40+
"single_step",
41+
"top_level_term2",
42+
]
43+
3244
ALL_TESTS = COMPULSORY_TESTS + MANUAL_TESTS
3345

3446
filegroup(
@@ -102,7 +114,8 @@ filegroup(
102114
regression_test(
103115
name = test_name,
104116
data = [":" + test_name + "_resources"],
105-
tags = [] if test_name in COMPULSORY_TESTS else ["manual"],
117+
tags = ["manual"] if test_name in MANUAL_TESTS or
118+
test_name in MANUAL_FOR_BAZEL_TESTS else [],
106119
visibility = ["//visibility:public"],
107120
)
108121
for test_name in ALL_TESTS

‎src/gpl/test/BUILD‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -87,9 +87,15 @@ filegroup(
8787
),
8888
)
8989

90+
# TODO: Enable once difference between bazel and ctest is resolved.
91+
MANUAL_FOR_BAZEL_TESTS = [
92+
"incremental02",
93+
]
94+
9095
[regression_test(
9196
name = test_name,
9297
data = [":test_resources"],
98+
tags = ["manual"] if test_name in MANUAL_FOR_BAZEL_TESTS else [],
9399
) for test_name in TESTS]
94100

95101
PY_TESTS = [

‎src/grt/test/BUILD‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,16 @@ filegroup(
109109
),
110110
)
111111

112+
# TODO: Enable once difference between bazel and ctest is resolved.
113+
MANUAL_FOR_BAZEL_TESTS = [
114+
"cugr_adjustment1",
115+
"cugr_adjustment2",
116+
"cugr_adjustment3",
117+
"gcd_cugr",
118+
]
119+
112120
[regression_test(
113121
name = test_name,
114122
data = [":test_resources"],
123+
tags = ["manual"] if test_name in MANUAL_FOR_BAZEL_TESTS else [],
115124
) for test_name in TESTS]

‎src/odb/test/BUILD‎

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -222,6 +222,13 @@ MANUAL_TESTS = [
222222
"odb_readme_msgs_check",
223223
]
224224

225+
# TODO: Enable once difference between bazel and ctest is resolved.
226+
MANUAL_FOR_BAZEL_TESTS = [
227+
"dump_netlists",
228+
"dump_netlists_withfill",
229+
"replace_hier_mod1",
230+
]
231+
225232
ALL_TESTS = COMPULSORY_TESTS + MANUAL_TESTS + PASSFAIL_TESTS
226233

227234
filegroup(
@@ -362,10 +369,11 @@ filegroup(
362369
[
363370
regression_test(
364371
name = test_name,
365-
data = [":" + test_name + "_resources"],
366-
tags = [] if test_name in COMPULSORY_TESTS else ["manual"],
367-
check_passfail = True if test_name in PASSFAIL_TESTS else False,
368372
check_log = False if test_name in PASSFAIL_TESTS else True,
373+
check_passfail = True if test_name in PASSFAIL_TESTS else False,
374+
data = [":" + test_name + "_resources"],
375+
tags = ["manual"] if test_name in MANUAL_TESTS or
376+
test_name in MANUAL_FOR_BAZEL_TESTS else [],
369377
visibility = ["//visibility:public"],
370378
)
371379
for test_name in ALL_TESTS

‎src/pad/test/BUILD‎

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,11 @@ MANUAL_TESTS = [
5858
"pad_readme_msgs_check",
5959
]
6060

61+
# TODO: Enable once difference between bazel and ctest is resolved.
62+
MANUAL_FOR_BAZEL_TESTS = [
63+
"rdl_route_single_target",
64+
]
65+
6166
ALL_TESTS = COMPULSORY_TESTS + MANUAL_TESTS
6267

6368
filegroup(
@@ -202,7 +207,8 @@ filegroup(
202207
regression_test(
203208
name = test_name,
204209
data = [":" + test_name + "_resources"],
205-
tags = [] if test_name in COMPULSORY_TESTS else ["manual"],
210+
tags = ["manual"] if test_name in MANUAL_TESTS or
211+
test_name in MANUAL_FOR_BAZEL_TESTS else [],
206212
visibility = ["//visibility:public"],
207213
)
208214
for test_name in ALL_TESTS

‎src/par/test/BUILD‎

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,12 @@ MANUAL_TESTS = [
1717
"par_readme_msgs_check",
1818
]
1919

20+
# TODO: Enable once difference between bazel and ctest is resolved.
21+
MANUAL_FOR_BAZEL_TESTS = [
22+
"partition_gcd",
23+
"write_artnet",
24+
]
25+
2026
ALL_TESTS = COMPULSORY_TESTS + MANUAL_TESTS
2127

2228
filegroup(
@@ -80,7 +86,8 @@ filegroup(
8086
regression_test(
8187
name = test_name,
8288
data = [":" + test_name + "_resources"],
83-
tags = [] if test_name in COMPULSORY_TESTS else ["manual"],
89+
tags = ["manual"] if test_name in MANUAL_TESTS or
90+
test_name in MANUAL_FOR_BAZEL_TESTS else [],
8491
visibility = ["//visibility:public"],
8592
)
8693
for test_name in ALL_TESTS

‎src/pdn/test/BUILD‎

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -134,6 +134,15 @@ MANUAL_TESTS = [
134134
"pdn_readme_msgs_check",
135135
]
136136

137+
# TODO: Enable once difference between bazel and ctest is resolved.
138+
MANUAL_FOR_BAZEL_TESTS = [
139+
"pads_black_parrot",
140+
"pads_black_parrot_flipchip",
141+
"pads_black_parrot_flipchip_connect_bumps",
142+
"pads_black_parrot_flipchip_connect_overpads",
143+
"pads_black_parrot_offset",
144+
]
145+
137146
ALL_TESTS = COMPULSORY_TESTS + MANUAL_TESTS
138147

139148
filegroup(
@@ -287,7 +296,8 @@ filegroup(
287296
regression_test(
288297
name = test_name,
289298
data = [":" + test_name + "_resources"],
290-
tags = [] if test_name in COMPULSORY_TESTS else ["manual"],
299+
tags = ["manual"] if test_name in MANUAL_TESTS or
300+
test_name in MANUAL_FOR_BAZEL_TESTS else [],
291301
visibility = ["//visibility:public"],
292302
)
293303
for test_name in ALL_TESTS

0 commit comments

Comments
 (0)