Enable output log checking with bazel test.

Signed-off-by: Ted Hong <[email protected]>

Author: hongted

test/bazel_test.sh

@@ -5,8 +5,9 @@ set -ex
 export TEST_EXT=${TEST_FILE##*.}
 export TEST_NAME=$(basename "$TEST_FILE" .$TEST_EXT)
 export OPENROAD_EXE=$(realpath $OPENROAD_EXE)
-export LOG_FILE=/dev/stdout
+export RESULTS_DIR="${TEST_UNDECLARED_OUTPUTS_DIR}/results"
 export REGRESSION_TEST=$(realpath $REGRESSION_TEST)
 
 cd $(dirname $TEST_FILE)
+mkdir -p $RESULTS_DIR
 $REGRESSION_TEST

test/regression.bzl

@@ -18,13 +18,17 @@ export TEST_NAME_BAZEL={TEST_NAME_BAZEL}
 export TEST_FILE={TEST_FILE}
 export OPENROAD_EXE={OPENROAD_EXE}
 export REGRESSION_TEST={REGRESSION_TEST}
+export TEST_CHECK_LOG={TEST_CHECK_LOG}
+export TEST_CHECK_PASSFAIL={TEST_CHECK_PASSFAIL}
 exec "{bazel_test_sh}" "$@"
 """.format(
             bazel_test_sh = ctx.file.bazel_test_sh.short_path,
             TEST_NAME_BAZEL = ctx.attr.test_name,
             TEST_FILE = ctx.file.test_file.short_path,
             OPENROAD_EXE = ctx.executable.openroad.short_path,
             REGRESSION_TEST = ctx.file.regression_test.short_path,
+            TEST_CHECK_LOG = "True" if ctx.attr.check_log else "False",
+            TEST_CHECK_PASSFAIL = "True" if ctx.attr.check_passfail else "False",
         ),
         is_executable = True,
     )
@@ -55,6 +59,14 @@ regression_rule_test = rule(
             doc = "The Bazel test shell script.",
             allow_single_file = True,
         ),
+        "check_log": attr.bool(
+            doc = "Diff the output log against <test_name>.ok",
+            default = True,
+        ),
+        "check_passfail": attr.bool(
+            doc = "Check the output log contains pass or OK in the last line",
+            default = False,
+        ),
         "data": attr.label_list(
             doc = "Additional test files required for the test.",
             allow_files = True,

test/regression_test.sh

@@ -2,25 +2,27 @@
 
 set -e
 
-mkdir -p results
+RESULTS_DIR="${RESULTS_DIR:-results}"
+LOG_FILE="${RESULTS_DIR}/$TEST_NAME-$TEST_EXT.log"
 
-LOG_FILE=${LOG_FILE:-results/$TEST_NAME-$TEST_EXT.log}
+mkdir -p ${RESULTS_DIR}
 
 ORD_ARGS=""
 if [ "$TEST_TYPE" == "python" ]; then
     ORD_ARGS="-python"
 fi
 
 echo "Directory: ${PWD}"
-echo "Command:   $OPENROAD_EXE $ORD_ARGS -no_splash -no_init -exit  $TEST_NAME.$TEST_EXT &> $LOG_FILE"
+echo "Results Directory: ${RESULTS_DIR}"
+echo "Command:   $OPENROAD_EXE $ORD_ARGS -no_splash -no_init -exit  $TEST_NAME.$TEST_EXT |& tee $LOG_FILE"
 
-$OPENROAD_EXE $ORD_ARGS -no_splash -no_init -exit $TEST_NAME.$TEST_EXT &> $LOG_FILE
+$OPENROAD_EXE $ORD_ARGS -no_splash -no_init -exit $TEST_NAME.$TEST_EXT |& tee $LOG_FILE
 
 echo "Exitcode:  $?"
 
 if [ "$TEST_CHECK_LOG" == "True" ]; then
-    echo "Diff:      ${PWD}/results/$TEST_NAME-$TEST_EXT.diff"
-    diff $LOG_FILE $TEST_NAME.ok > results/$TEST_NAME-$TEST_EXT.diff
+    echo "Diff:      ${RESULTS_DIR}/$TEST_NAME-$TEST_EXT.diff"
+    diff $LOG_FILE $TEST_NAME.ok > ${RESULTS_DIR}/$TEST_NAME-$TEST_EXT.diff
 fi
 
 if [ "$TEST_CHECK_PASSFAIL" == "True" ]; then