Merge pull request #9134 from The-OpenROAD-Project-staging/mpl-intersect-coverage

mpl: fix coverage errors related to odb::intersect

Author: eder-matheus

src/mpl/src/SACoreSoftMacro.cpp

@@ -499,7 +499,8 @@ void SACoreSoftMacro::calMacroBlockagePenalty()
     for (const auto& macro_id : pos_seq_) {
       const SoftMacro& soft_macro = macros_[macro_id];
       if (soft_macro.getNumMacro() > 0) {
-        odb::Rect overlap = blockage.intersect(soft_macro.getBBox());
+        odb::Rect overlap;
+        blockage.intersection(soft_macro.getBBox(), overlap);
 
         // If any of the dimensions is negative, then there's no overlap.
         if (overlap.dx() < 0 || overlap.dy() < 0) {
@@ -542,7 +543,8 @@ void SACoreSoftMacro::calFixedMacrosPenalty()
         continue;
       }
 
-      odb::Rect overlap = fixed_macro.intersect(macro.getBBox());
+      odb::Rect overlap;
+      fixed_macro.intersection(macro.getBBox(), overlap);
 
       // If any of the dimensions is negative, then there's no overlap.
       if (overlap.dx() < 0 || overlap.dy() < 0) {

src/mpl/src/SimulatedAnnealingCore.cpp

@@ -418,7 +418,8 @@ void SimulatedAnnealingCore<T>::calGuidancePenalty()
   }
 
   for (const auto& [id, guide] : guides_) {
-    const odb::Rect overlap = macros_[id].getBBox().intersect(guide);
+    odb::Rect overlap;
+    macros_[id].getBBox().intersection(guide, overlap);
 
     // maximum overlap area
     int64_t penalty

src/mpl/src/hier_rtlmp.cpp

@@ -1424,15 +1424,15 @@ void HierRTLMP::placeChildren(Cluster* parent, bool ignore_std_cell_area)
       }
     }
 
-    fence = fence.intersect(outline);
-    guide = guide.intersect(outline);
+    fence.intersection(outline, fence);
+    guide.intersection(outline, guide);
 
-    if (!fence.isInverted()) {
+    if (fence.area() > 0) {
       // current macro id is macros.size() - 1
       fence.moveDelta(-outline.xMin(), -outline.yMin());
       fences[macros.size() - 1] = fence;
     }
-    if (!guide.isInverted()) {
+    if (guide.area() > 0) {
       // current macro id is macros.size() - 1
       guide.moveDelta(-outline.xMin(), -outline.yMin());
       guides[macros.size() - 1] = guide;
@@ -2293,12 +2293,12 @@ void HierRTLMP::computeFencesAndGuides(
 {
   for (int i = 0; i < hard_macros.size(); ++i) {
     if (fences_.find(hard_macros[i]->getName()) != fences_.end()) {
-      fences[i] = fences_[hard_macros[i]->getName()].intersect(outline);
+      fences_[hard_macros[i]->getName()].intersection(outline, fences[i]);
       fences[i].moveDelta(-outline.xMin(), -outline.yMin());
     }
     auto itr = guides_.find(hard_macros[i]->getInst());
     if (itr != guides_.end()) {
-      guides[i] = itr->second.intersect(outline);
+      itr->second.intersection(outline, guides[i]);
       guides[i].moveDelta(-outline.xMin(), -outline.yMin());
     }
   }

src/mpl/src/object.cpp

@@ -906,7 +906,7 @@ SoftMacro::SoftMacro(utl::Logger* logger,
   odb::Rect hard_macro_bbox = hard_macro->getBBox();
 
   if (outline) {
-    shape = hard_macro_bbox.intersect(*outline);
+    hard_macro_bbox.intersection(*outline, shape);
     shape.moveDelta(-outline->xMin(), -outline->yMin());
   } else {
     shape = hard_macro_bbox;