gpl: fix coverity USE_AFTER_MOVE

maliberty · maliberty · commit f5765ae9cb0a · 2025-11-26T21:54:27.000Z
367       gui_debug_images_path_ = std::move(images_path);
&gt;&gt;&gt;     CID 1643471:         Uninitialized variables  (USE_AFTER_MOVE)
&gt;&gt;&gt;     Returning while reference parameter "images_path" is in a moved state.

Signed-off-by: Matt Liberty &lt;mliberty@precisioninno.com&gt;
diff --git a/src/gpl/src/replace.cpp b/src/gpl/src/replace.cpp
@@ -364,7 +364,7 @@ void Replace::setDebug(const int pause_iterations,
   gui_debug_inst_ = inst;
   gui_debug_start_iter_ = start_iter;
   gui_debug_generate_images_ = generate_images;
-  gui_debug_images_path_ = std::move(images_path);
+  gui_debug_images_path_ = images_path;
 }
 
 void PlaceOptions::validate(utl::Logger* logger)

Original file line number	Diff line number	Diff line change
`@@ -364,7 +364,7 @@ void Replace::setDebug(const int pause_iterations,`
`364`	`364`	`gui_debug_inst_ = inst;`
`365`	`365`	`gui_debug_start_iter_ = start_iter;`
`366`	`366`	`gui_debug_generate_images_ = generate_images;`
`367`		`- gui_debug_images_path_ = std::move(images_path);`
	`367`	`+ gui_debug_images_path_ = images_path;`
`368`	`368`	`}`
`369`	`369`
`370`	`370`	`void PlaceOptions::validate(utl::Logger* logger)`