pdn: add layer checks to connect statements

Signed-off-by: Peter Gadfort <[email protected]>

Author: gadfort

src/pdn/include/pdn/PdnGen.hh

@@ -71,6 +71,10 @@ class PdnGen
                              odb::dbMTerm* switched_power,
                              odb::dbMTerm* alwayson_power,
                              odb::dbMTerm* ground);
+  const std::vector<std::unique_ptr<PowerCell>>& getSwitchedPowerCells() const
+  {
+    return switched_power_cells_;
+  }
 
   // Domains
   std::vector<VoltageDomain*> getDomains() const;

src/pdn/src/grid.cpp

@@ -647,6 +647,93 @@ void Grid::checkSetup() const
       }
     }
   }
+
+  // Check connectivity
+  std::set<odb::dbTechLayer*> check_layers;
+  for (const auto& ring : rings_) {
+    for (auto* layer : ring->getLayers()) {
+      check_layers.insert(layer);
+    }
+  }
+  for (const auto& strap : straps_) {
+    check_layers.insert(strap->getLayer());
+  }
+
+  // Check that pin layers actually exists in stack
+  for (auto* layer : pin_layers_) {
+    if (check_layers.find(layer) == check_layers.end()) {
+      getLogger()->error(utl::PDN,
+                         111,
+                         "Pin layer {} is not a valid shape in {}",
+                         layer->getName(),
+                         name_);
+    }
+  }
+
+  // add instance layers
+  const auto nets_vec = getNets();
+  const std::set<odb::dbNet*> nets(nets_vec.begin(), nets_vec.end());
+
+  for (auto* inst : getInstances()) {
+    if (!inst->isFixed()) {
+      continue;
+    }
+    for (auto* iterm : inst->getITerms()) {
+      if (nets.find(iterm->getNet()) != nets.end()) {
+        for (const auto& [layer, shape] : iterm->getGeometries()) {
+          check_layers.insert(layer);
+        }
+      }
+    }
+  }
+  if (domain_->hasSwitchedPower()) {
+    for (const auto& powercell :
+         domain_->getPDNGen()->getSwitchedPowerCells()) {
+      for (auto* mterm : powercell->getMaster()->getMTerms()) {
+        for (auto* mpin : mterm->getMPins()) {
+          for (auto* box : mpin->getGeometry()) {
+            auto* layer = box->getTechLayer();
+            if (layer) {
+              check_layers.insert(layer);
+            }
+          }
+        }
+      }
+    }
+  }
+
+  // add bterms
+  for (auto* net : nets) {
+    for (auto* bterm : net->getBTerms()) {
+      for (auto* bpin : bterm->getBPins()) {
+        if (!bpin->getPlacementStatus().isFixed()) {
+          continue;
+        }
+        for (auto* box : bpin->getBoxes()) {
+          auto* layer = box->getTechLayer();
+          if (layer) {
+            check_layers.insert(layer);
+          }
+        }
+      }
+    }
+  }
+
+  // Check that connect statement actually point to something
+  for (const auto& connect : connect_) {
+    if (check_layers.find(connect->getLowerLayer()) == check_layers.end()) {
+      getLogger()->error(utl::PDN,
+                         112,
+                         "Cannot find shapes to connect to on {}",
+                         connect->getLowerLayer()->getName());
+    }
+    if (check_layers.find(connect->getUpperLayer()) == check_layers.end()) {
+      getLogger()->error(utl::PDN,
+                         113,
+                         "Cannot find shapes to connect to on {}",
+                         connect->getLowerLayer()->getName());
+    }
+  }
 }
 
 void Grid::getObstructions(Shape::ObstructionTreeMap& obstructions) const

src/pdn/test/power_switch.ok

@@ -41,7 +41,6 @@ Straps:
     Snap to grid: false
 Connect:
   Connect layers met1 -> met4
-  Connect layers met2 -> met4
   Connect layers met4 -> met5
 Switched power cell: POWER_SWITCH
   Control net: nPWRUP

src/pdn/test/power_switch.tcl

@@ -23,7 +23,6 @@ add_pdn_stripe -layer met1 -width 0.48 -offset 0 -followpins
 add_pdn_stripe -layer met4 -width 1.600 -pitch 27.140 -offset 13.570
 add_pdn_stripe -layer met5 -width 1.600 -pitch 27.200 -offset 13.600
 add_pdn_connect -layers {met1 met4}
-add_pdn_connect -layers {met2 met4}
 add_pdn_connect -layers {met4 met5}
 
 pdngen -report_only

src/pdn/test/power_switch_cut_rows.tcl

@@ -23,7 +23,6 @@ add_pdn_stripe -layer met1 -width 0.48 -offset 0 -followpins
 add_pdn_stripe -layer met4 -width 1.600 -pitch 27.140 -offset 13.570
 add_pdn_stripe -layer met5 -width 1.600 -pitch 27.200 -offset 13.600
 add_pdn_connect -layers {met1 met4}
-add_pdn_connect -layers {met2 met4}
 add_pdn_connect -layers {met4 met5}
 
 pdngen

src/pdn/test/power_switch_daisy.tcl

@@ -24,7 +24,6 @@ add_pdn_stripe -layer met1 -width 0.48 -offset 0 -followpins
 add_pdn_stripe -layer met4 -width 1.600 -pitch 20.000 -offset 13.000
 add_pdn_stripe -layer met5 -width 1.600 -pitch 27.200 -offset 13.600
 add_pdn_connect -layers {met1 met4}
-add_pdn_connect -layers {met2 met4}
 add_pdn_connect -layers {met4 met5}
 
 pdngen

src/pdn/test/power_switch_star.tcl

@@ -24,7 +24,6 @@ add_pdn_stripe -layer met1 -width 0.48 -offset 0 -followpins
 add_pdn_stripe -layer met4 -width 1.600 -pitch 27.140 -offset 13.570
 add_pdn_stripe -layer met5 -width 1.600 -pitch 27.200 -offset 13.600
 add_pdn_connect -layers {met1 met4}
-add_pdn_connect -layers {met2 met4}
 add_pdn_connect -layers {met4 met5}
 
 pdngen

src/pdn/test/power_switch_upf_daisy.tcl

@@ -45,7 +45,6 @@ add_pdn_stripe -layer met1 -width 0.48 -offset 0 -followpins
 add_pdn_stripe -layer met4 -width 1.600 -pitch 27.140 -offset 13.570
 add_pdn_stripe -layer met5 -width 1.600 -pitch 27.200 -offset 13.600
 add_pdn_connect -layers {met1 met4}
-add_pdn_connect -layers {met2 met4}
 add_pdn_connect -layers {met4 met5}
 
 pdngen

src/pdn/test/power_switch_upf_star.tcl

@@ -45,7 +45,6 @@ add_pdn_stripe -layer met1 -width 0.48 -offset 0 -followpins
 add_pdn_stripe -layer met4 -width 1.600 -pitch 27.140 -offset 13.570
 add_pdn_stripe -layer met5 -width 1.600 -pitch 27.200 -offset 13.600
 add_pdn_connect -layers {met1 met4}
-add_pdn_connect -layers {met2 met4}
 add_pdn_connect -layers {met4 met5}
 
 pdngen