fix bugprone-empty-catch

Signed-off-by: Matt Liberty <[email protected]>

Author: maliberty

src/gui/include/gui/gui.h

@@ -615,6 +615,7 @@ class Renderer
     if (settings.count(key) == 1) {
       try {
         value = std::get<T>(settings.at(key));
+        // NOLINTNEXTLINE(bugprone-empty-catch)
       } catch (const std::bad_variant_access&) {
         // Stay with current value
       }

src/gui/src/dbDescriptors.cpp

@@ -2726,9 +2726,9 @@ Descriptor::Editors DbBlockageDescriptor::getEditors(
                blockage->setMaxDensity(density);
                return true;
              }
-           } catch (std::out_of_range&) {
+           } catch (std::out_of_range&) {  // NOLINT(bugprone-empty-catch)
              // catch poorly formatted string
-           } catch (std::logic_error&) {
+           } catch (std::logic_error&) {  // NOLINT(bugprone-empty-catch)
              // catch poorly formatted string
            }
          }

src/gui/src/drcWidget.cpp

@@ -370,7 +370,8 @@ void DRCWidget::loadReport(const QString& filename)
                      "Unable to determine type of {}",
                      filename.toStdString());
     }
-  } catch (std::runtime_error&) {
+  } catch (std::runtime_error& e) {
+    logger_->warn(utl::GUI, 110, "Failed to load: {}", e.what());
   }  // catch errors
 
   if (category != nullptr) {

src/gui/src/mainWindow.cpp

@@ -1937,7 +1937,9 @@ void MainWindow::saveDesign()
 
   try {
     ord::OpenRoad::openRoad()->writeDb(file.toStdString().c_str());
-  } catch (const std::exception&) {
+  } catch (const std::exception& e) {
+    QMessageBox::warning(
+        this, "Save Error", QString("Db save failed: %1").arg(e.what()));
   }
 }
 

src/utl/src/prometheus/metrics_server.cpp

@@ -67,8 +67,9 @@ PrometheusMetricsServer::~PrometheusMetricsServer()
       boost::asio::ip::tcp::socket socket(io_context);
       boost::asio::ip::tcp::endpoint endpoint(
           boost::asio::ip::make_address("127.0.0.1"), port_);
-      socket.connect(endpoint);         // This will unblock the accept().
-    } catch (const std::exception& e) { /*Do nothing, we're dying*/
+      socket.connect(endpoint);          // This will unblock the accept().
+    } catch (const std::exception& e) {  // NOLINT(bugprone-empty-catch)
+                                         /*Do nothing, we're dying*/
     }
   }
   worker_thread_.join();