Merge branch 'master' into my-branch

Author: cesar-011

.github/workflows/awesome_workflow.yml

@@ -1,6 +1,7 @@
 name: Awesome CI Workflow
 on: [push, pull_request]
 permissions:
+  pull-requests: write
   contents: write
 
 jobs:
@@ -13,10 +14,10 @@ jobs:
           fetch-depth: 0
       - uses: actions/setup-python@v4
       - name: requirements
-        run: | 
+        run: |
           sudo apt-get -qq update
           sudo apt-get -qq install clang-tidy clang-format
-        # checks are passing with less errors when used with this version. 
+        # checks are passing with less errors when used with this version.
         # The default installs v6.0 which did not work out well in my tests
       - name: Setup Git Specs
         run: |
@@ -33,8 +34,8 @@ jobs:
           git diff --diff-filter=dr --name-only origin/master > git_diff.txt
           echo "Files changed-- `cat git_diff.txt`"
       - name: Configure for static lint checks
-        # compiling first gives clang-tidy access to all the header files and settings used to compile the programs. 
-        # This will check for macros, if any, on linux and not for Windows. But the use of portability checks should 
+        # compiling first gives clang-tidy access to all the header files and settings used to compile the programs.
+        # This will check for macros, if any, on linux and not for Windows. But the use of portability checks should
         # be able to catch any errors for other platforms.
         run: cmake -B build -S . -DCMAKE_EXPORT_COMPILE_COMMANDS=ON
       - name: Lint modified files

CMakeLists.txt

@@ -27,30 +27,30 @@ if(USE_OPENMP)
     endif()
 endif()
 
-add_subdirectory(math)
-add_subdirectory(others)
-add_subdirectory(search)
-add_subdirectory(ciphers)
-add_subdirectory(hashing)
-add_subdirectory(strings)
-add_subdirectory(sorting)
-add_subdirectory(geometry)
-add_subdirectory(graphics)
-add_subdirectory(probability)
 add_subdirectory(backtracking)
 add_subdirectory(bit_manipulation)
+add_subdirectory(ciphers)
+add_subdirectory(cpu_scheduling_algorithms)
+add_subdirectory(data_structures)
+add_subdirectory(divide_and_conquer)
 add_subdirectory(dynamic_programming)
+add_subdirectory(games)
+add_subdirectory(geometry)
+add_subdirectory(graph)
+add_subdirectory(graphics)
 add_subdirectory(greedy_algorithms)
-add_subdirectory(range_queries)
-add_subdirectory(operations_on_datastructures)
-add_subdirectory(data_structures)
+add_subdirectory(hashing)
 add_subdirectory(machine_learning)
+add_subdirectory(math)
 add_subdirectory(numerical_methods)
-add_subdirectory(graph)
-add_subdirectory(divide_and_conquer)
-add_subdirectory(games)
-add_subdirectory(cpu_scheduling_algorithms)
+add_subdirectory(operations_on_datastructures)
+add_subdirectory(others)
 add_subdirectory(physics)
+add_subdirectory(probability)
+add_subdirectory(range_queries)
+add_subdirectory(search)
+add_subdirectory(sorting)
+add_subdirectory(strings)
 
 cmake_policy(SET CMP0054 NEW)
 cmake_policy(SET CMP0057 NEW)

CONTRIBUTING.md

@@ -204,11 +204,9 @@ static void test() {
 
 /**
  * @brief Main function
- * @param argc commandline argument count (ignored)
- * @param argv commandline array of arguments (ignored)
  * @returns 0 on exit
  */
-int main(int argc, char *argv[]) {
+int main() {
     test();  // run self-test implementations
     // code here
     return 0;

DIRECTORY.md

@@ -121,6 +121,7 @@
   * [Shortest Common Supersequence](https://github.com/TheAlgorithms/C-Plus-Plus/blob/HEAD/dynamic_programming/shortest_common_supersequence.cpp)
   * [Subset Sum Dynamic](https://github.com/TheAlgorithms/C-Plus-Plus/blob/HEAD/dynamic_programming/subset_sum_dynamic.cpp)
   * [Trapped Rainwater](https://github.com/TheAlgorithms/C-Plus-Plus/blob/HEAD/dynamic_programming/trapped_rainwater.cpp)
+  * [Trapped Rainwater2](https://github.com/TheAlgorithms/C-Plus-Plus/blob/HEAD/dynamic_programming/trapped_rainwater2.cpp)
   * [Tree Height](https://github.com/TheAlgorithms/C-Plus-Plus/blob/HEAD/dynamic_programming/tree_height.cpp)
   * [Unbounded 0 1 Knapsack](https://github.com/TheAlgorithms/C-Plus-Plus/blob/HEAD/dynamic_programming/unbounded_0_1_knapsack.cpp)
   * [Word Break](https://github.com/TheAlgorithms/C-Plus-Plus/blob/HEAD/dynamic_programming/word_break.cpp)

README.md

@@ -1,4 +1,5 @@
 # The Algorithms - C++ # {#mainpage}
+
 <!-- the suffix in the above line is required for doxygen to consider this as the index page of the generated documentation site -->
 
 [![Gitpod Ready-to-Code](https://img.shields.io/badge/Gitpod-Ready--to--Code-blue?logo=gitpod)](https://gitpod.io/#https://github.com/TheAlgorithms/C-Plus-Plus)
@@ -18,13 +19,13 @@ This repository is a collection of open-source implementation of a variety of al
 
 ## Features
 
-* The repository provides implementations of various algorithms in one of the most fundamental general purpose languages - [C++](https://en.wikipedia.org/wiki/C%2B%2B).
-* Well documented source code with detailed explanations provide a valuable resource for educators and students alike.
-* Each source code is atomic using [STL classes](https://en.wikipedia.org/wiki/Standard_Template_Library) and _no external libraries_ are required for their compilation and execution. Thus, the fundamentals of the algorithms can be studied in much depth.
-* Source codes are [compiled and tested](https://github.com/TheAlgorithms/C-Plus-Plus/actions?query=workflow%3A%22Awesome+CI+Workflow%22) for every commit on the latest versions of three major operating systems viz., Windows, MacOS, and Ubuntu (Linux) using MSVC 19 2022, AppleClang 14.0.0, and GNU 11.3.0 respectively. 
-* Strict adherence to [C++17](https://en.wikipedia.org/wiki/C%2B%2B17) standard ensures portability of code to embedded systems as well like [ESP32](https://docs.espressif.com/projects/esp-idf/en/stable/esp32/api-guides/cplusplus.html#c-language-standard), [ARM Cortex](https://developer.arm.com/documentation/101458/2404/Standards-support/Supported-C-C---standards-in-Arm-C-C---Compiler), etc. with little to no changes.
-* Self-checks within programs ensure correct implementations with confidence.
-* Modular implementations and OpenSource licensing enable the functions to be utilized conveniently in other applications.
+- The repository provides implementations of various algorithms in one of the most fundamental general purpose languages - [C++](https://en.wikipedia.org/wiki/C%2B%2B).
+- Well documented source code with detailed explanations provide a valuable resource for educators and students alike.
+- Each source code is atomic using [STL classes](https://en.wikipedia.org/wiki/Standard_Template_Library) and _no external libraries_ are required for their compilation and execution. Thus, the fundamentals of the algorithms can be studied in much depth.
+- Source codes are [compiled and tested](https://github.com/TheAlgorithms/C-Plus-Plus/actions?query=workflow%3A%22Awesome+CI+Workflow%22) for every commit on the latest versions of three major operating systems viz., Windows, MacOS, and Ubuntu (Linux) using MSVC 19 2022, AppleClang 15.0.15, and GNU 13.3.0 respectively.
+- Strict adherence to [C++17](https://en.wikipedia.org/wiki/C%2B%2B17) standard ensures portability of code to embedded systems as well like [ESP32](https://docs.espressif.com/projects/esp-idf/en/stable/esp32/api-guides/cplusplus.html#c-language-standard), [ARM Cortex](https://developer.arm.com/documentation/101458/2404/Standards-support/Supported-C-C---standards-in-Arm-C-C---Compiler), etc. with little to no changes.
+- Self-checks within programs ensure correct implementations with confidence.
+- Modular implementations and OpenSource licensing enable the functions to be utilized conveniently in other applications.
 
 ## Documentation
 

ciphers/base64_encoding.cpp

@@ -11,7 +11,6 @@
  * digits.
  * @author [Ashish Daulatabad](https://github.com/AshishYUO)
  */
-#include <array>     /// for `std::array`
 #include <cassert>   /// for `assert` operations
 #include <cstdint>
 #include <iostream>  /// for IO operations

ciphers/hill_cipher.cpp

@@ -379,7 +379,6 @@ class HillCipher {
         int mat_determinant = det_encrypt < 0 ? det_encrypt % L : det_encrypt;
 
         matrix<double> tmp_inverse = get_inverse(encrypt_key);
-        double d2 = determinant_lu(decrypt_key);
 
         // find co-prime factor for inversion
         int det_inv = -1;

ciphers/uint128_t.hpp

@@ -350,7 +350,7 @@ class uint128_t {
      * @brief operator -- (post-decrement)
      * @returns decremented value of this
      */
-    inline uint128_t operator--(int p) {
+    inline uint128_t operator--(int) {
         --*this;
         return *this;
     }

ciphers/uint256_t.hpp

@@ -72,7 +72,7 @@ class uint256_t {
      */
     template <typename T, typename = typename std::enable_if<
                               std::is_integral<T>::value, T>::type>
-    explicit uint256_t(T low) : s(low), f(0) {}
+    explicit uint256_t(T low) : f(0), s(low) {}
 
     /**
      * @brief Parameterized constructor
@@ -319,7 +319,7 @@ class uint256_t {
      * @brief operator -- (post-decrement)
      * @returns decremented value of this
      */
-    inline uint256_t operator--(int p) {
+    inline uint256_t operator--(int) {
         --*this;
         return *this;
     }

data_structures/cll/cll.h

@@ -1,5 +1,5 @@
 /*
- * Simple data structure CLL (Cicular Linear Linked List)
+ * Simple data structure CLL (Circular Linear Linked List)
  * */
 #include <cctype>
 #include <cstdlib>