Merge branch 'master' into add-prime-binary-string

Author: realstealthninja

CMakeLists.txt

@@ -27,30 +27,30 @@ if(USE_OPENMP)
     endif()
 endif()
 
-add_subdirectory(math)
-add_subdirectory(others)
-add_subdirectory(search)
-add_subdirectory(ciphers)
-add_subdirectory(hashing)
-add_subdirectory(strings)
-add_subdirectory(sorting)
-add_subdirectory(geometry)
-add_subdirectory(graphics)
-add_subdirectory(probability)
 add_subdirectory(backtracking)
 add_subdirectory(bit_manipulation)
+add_subdirectory(ciphers)
+add_subdirectory(cpu_scheduling_algorithms)
+add_subdirectory(data_structures)
+add_subdirectory(divide_and_conquer)
 add_subdirectory(dynamic_programming)
+add_subdirectory(games)
+add_subdirectory(geometry)
+add_subdirectory(graph)
+add_subdirectory(graphics)
 add_subdirectory(greedy_algorithms)
-add_subdirectory(range_queries)
-add_subdirectory(operations_on_datastructures)
-add_subdirectory(data_structures)
+add_subdirectory(hashing)
 add_subdirectory(machine_learning)
+add_subdirectory(math)
 add_subdirectory(numerical_methods)
-add_subdirectory(graph)
-add_subdirectory(divide_and_conquer)
-add_subdirectory(games)
-add_subdirectory(cpu_scheduling_algorithms)
+add_subdirectory(operations_on_datastructures)
+add_subdirectory(others)
 add_subdirectory(physics)
+add_subdirectory(probability)
+add_subdirectory(range_queries)
+add_subdirectory(search)
+add_subdirectory(sorting)
+add_subdirectory(strings)
 
 cmake_policy(SET CMP0054 NEW)
 cmake_policy(SET CMP0057 NEW)

CONTRIBUTING.md

@@ -204,11 +204,9 @@ static void test() {
 
 /**
  * @brief Main function
- * @param argc commandline argument count (ignored)
- * @param argv commandline array of arguments (ignored)
  * @returns 0 on exit
  */
-int main(int argc, char *argv[]) {
+int main() {
     test();  // run self-test implementations
     // code here
     return 0;

DIRECTORY.md

@@ -121,6 +121,7 @@
   * [Shortest Common Supersequence](https://github.com/TheAlgorithms/C-Plus-Plus/blob/HEAD/dynamic_programming/shortest_common_supersequence.cpp)
   * [Subset Sum Dynamic](https://github.com/TheAlgorithms/C-Plus-Plus/blob/HEAD/dynamic_programming/subset_sum_dynamic.cpp)
   * [Trapped Rainwater](https://github.com/TheAlgorithms/C-Plus-Plus/blob/HEAD/dynamic_programming/trapped_rainwater.cpp)
+  * [Trapped Rainwater2](https://github.com/TheAlgorithms/C-Plus-Plus/blob/HEAD/dynamic_programming/trapped_rainwater2.cpp)
   * [Tree Height](https://github.com/TheAlgorithms/C-Plus-Plus/blob/HEAD/dynamic_programming/tree_height.cpp)
   * [Unbounded 0 1 Knapsack](https://github.com/TheAlgorithms/C-Plus-Plus/blob/HEAD/dynamic_programming/unbounded_0_1_knapsack.cpp)
   * [Word Break](https://github.com/TheAlgorithms/C-Plus-Plus/blob/HEAD/dynamic_programming/word_break.cpp)

ciphers/base64_encoding.cpp

@@ -11,7 +11,6 @@
  * digits.
  * @author [Ashish Daulatabad](https://github.com/AshishYUO)
  */
-#include <array>     /// for `std::array`
 #include <cassert>   /// for `assert` operations
 #include <cstdint>
 #include <iostream>  /// for IO operations

ciphers/hill_cipher.cpp

@@ -379,7 +379,6 @@ class HillCipher {
         int mat_determinant = det_encrypt < 0 ? det_encrypt % L : det_encrypt;
 
         matrix<double> tmp_inverse = get_inverse(encrypt_key);
-        double d2 = determinant_lu(decrypt_key);
 
         // find co-prime factor for inversion
         int det_inv = -1;

ciphers/uint256_t.hpp

@@ -72,7 +72,7 @@ class uint256_t {
      */
     template <typename T, typename = typename std::enable_if<
                               std::is_integral<T>::value, T>::type>
-    explicit uint256_t(T low) : s(low), f(0) {}
+    explicit uint256_t(T low) : f(0), s(low) {}
 
     /**
      * @brief Parameterized constructor

data_structures/queue_using_array2.cpp

@@ -1,25 +1,24 @@
 #include <iostream>
-using namespace std;
 
 int queue[10];
 int front = 0;
 int rear = 0;
 
 void Enque(int x) {
     if (rear == 10) {
-        cout << "\nOverflow";
+        std::cout << "\nOverflow";
     } else {
         queue[rear++] = x;
     }
 }
 
 void Deque() {
     if (front == rear) {
-        cout << "\nUnderflow";
+        std::cout << "\nUnderflow";
     }
 
     else {
-        cout << "\n" << queue[front++] << " deleted";
+        std::cout << "\n" << queue[front++] << " deleted";
         for (int i = front; i < rear; i++) {
             queue[i - front] = queue[i];
         }
@@ -30,21 +29,21 @@ void Deque() {
 
 void show() {
     for (int i = front; i < rear; i++) {
-        cout << queue[i] << "\t";
+        std::cout << queue[i] << "\t";
     }
 }
 
 int main() {
     int ch, x;
     do {
-        cout << "\n1. Enque";
-        cout << "\n2. Deque";
-        cout << "\n3. Print";
-        cout << "\nEnter Your Choice : ";
-        cin >> ch;
+        std::cout << "\n1. Enque";
+        std::cout << "\n2. Deque";
+        std::cout << "\n3. Print";
+        std::cout << "\nEnter Your Choice : ";
+        std::cin >> ch;
         if (ch == 1) {
-            cout << "\nInsert : ";
-            cin >> x;
+            std::cout << "\nInsert : ";
+            std::cin >> x;
             Enque(x);
         } else if (ch == 2) {
             Deque();

data_structures/rb_tree.cpp

@@ -33,7 +33,7 @@ class RBtree
 };
 void RBtree::insert()
 {
-	int z, i = 0;
+	int z;
 	cout << "\nEnter key of the node to be inserted: ";
 	cin >> z;
 	node *p, *q;

data_structures/sparse_table.cpp

@@ -155,11 +155,9 @@ static void test() {
 
 /**
  * @brief Main function
- * @param argc commandline argument count (ignored)
- * @param argv commandline array of arguments (ignored)
  * @returns 0 on exit
  */
-int main(int argc, char *argv[]) {
+int main() {
     test();  // run self-test implementations
     return 0;
 }

data_structures/stack_using_array.cpp

@@ -25,7 +25,7 @@ class Stack {
      *
      * @param size Maximum size of the stack
      */
-    Stack(int size) : stackSize(size), stackIndex(-1), stack(new T[size]) {}
+    Stack(int size) : stack(new T[size]), stackSize(size), stackIndex(-1) {}
 
     /**
      * @brief Checks if the stack is full