replaced console outputs with exception

Author: mohit-gogitter

DataStructures.Tests/LinkedList/CircularLinkedListTests.cs

@@ -1,6 +1,5 @@
 using System;
 using DataStructures.LinkedList.CircularLinkedList;
-using Microsoft.VisualStudio.TestPlatform.Utilities;
 using NUnit.Framework;
 
 namespace DataStructures.Tests.LinkedList;
@@ -22,10 +21,10 @@ public static void TestDisplay()
     [Test]
     public static void TestDisplayEmptyList()
     {
-        var cll = new CircularLinkedList<int>();
-        cll.Display();
+        var cll = new CircularLinkedList<int>();       
+        var ex = Assert.Throws<InvalidOperationException>(() => cll.Display());
 
-        Assert.That("List is empty.", Is.EqualTo(GetDisplayOutput(cll).Trim()));
+        Assert.That(ex!.Message, Is.EqualTo("List is empty."));
     }
 
     [Test]
@@ -57,8 +56,8 @@ public static void TestInsertAfter()
         cll.InsertAtEnd(10);
         cll.InsertAtEnd(20);
         cll.InsertAtEnd(30);
-
         cll.InsertAfter(20, 25);
+
         Assert.That("10 20 25 30", Is.EqualTo(GetDisplayOutput(cll).Trim()));
     }
 
@@ -67,6 +66,7 @@ public static void TestInsertAtBeginningInEmptyList()
     {
         var cll = new CircularLinkedList<int>();
         cll.InsertAtBeginning(10);
+
         Assert.That("10", Is.EqualTo(GetDisplayOutput(cll).Trim()));
     }
 
@@ -83,22 +83,20 @@ public static void TestInsertAtEndInEmptyList()
     public static void TestInsertAfterInEmptyList()
     {
         var cll = new CircularLinkedList<int>();
-        cll.InsertAfter(10, 20);
+        var ex = Assert.Throws<InvalidOperationException>(() => cll.InsertAfter(10, 20));
 
-        Assert.That("List is empty.", Is.EqualTo(GetDisplayOutput(cll).Trim()));
+        Assert.That(ex!.Message, Is.EqualTo("List is empty."));       
     }
 
-
-
     [Test]
     public static void TestInsertAfterSpecificNode()
     {
         var cll = new CircularLinkedList<int>();
         cll.InsertAtEnd(10);
         cll.InsertAtEnd(20);
         cll.InsertAtEnd(30);
-
         cll.InsertAfter(20, 25); // Insert after node with value 20
+
         Assert.That("10 20 25 30", Is.EqualTo(GetDisplayOutput(cll).Trim()));
     }
 
@@ -108,6 +106,7 @@ public static void TestInsertAfterOnNonExistingValue()
         var cll = new CircularLinkedList<int>();
         cll.InsertAtEnd(10);
         cll.InsertAfter(99, 25); // 99 does not exist
+
         Assert.That("10", Is.EqualTo(GetDisplayOutput(cll).Trim()));
     }
 
@@ -118,8 +117,8 @@ public static void TestDeleteNode()
         cll.InsertAtEnd(10);
         cll.InsertAtEnd(20);
         cll.InsertAtEnd(30);
-
         cll.DeleteNode(20);
+
         Assert.That("10 30", Is.EqualTo(GetDisplayOutput(cll).Trim()));
     }
 
@@ -129,6 +128,7 @@ public static void TestDeleteOnlyNode()
         var cll = new CircularLinkedList<int>();
         cll.InsertAtBeginning(10);
         cll.DeleteNode(10);
+
         Assert.That(cll.IsEmpty(), Is.EqualTo(true));
     }
 
@@ -140,6 +140,7 @@ public static void TestDeleteHeadNode()
         cll.InsertAtEnd(20);
         cll.InsertAtEnd(30);
         cll.DeleteNode(10);
+
         Assert.That("20 30", Is.EqualTo(GetDisplayOutput(cll).Trim()));
     }
 
@@ -151,15 +152,17 @@ public static void TestDeleteTailNode()
         cll.InsertAtEnd(20);
         cll.InsertAtEnd(30);
         cll.DeleteNode(30);
+
         Assert.That("10 20", Is.EqualTo(GetDisplayOutput(cll).Trim()));
     }
 
     [Test]
     public static void TestDeleteFromEmptyList()
     {
         var cll = new CircularLinkedList<int>();
-        cll.DeleteNode(10);
-        Assert.That(cll.IsEmpty(), Is.EqualTo(true));
+        var ex = Assert.Throws<InvalidOperationException>(() => cll.DeleteNode(10));
+
+        Assert.That(ex!.Message, Is.EqualTo("List is empty."));
     }
 
     [Test]
@@ -169,8 +172,8 @@ public static void TestDeleteNonExistentNode()
         cll.InsertAtEnd(10);
         cll.InsertAtEnd(20);
         cll.InsertAtEnd(30);
-
         cll.DeleteNode(40); // Attempting to delete a node that doesn't exist
+
         Assert.That("10 20 30", Is.EqualTo(GetDisplayOutput(cll).Trim()));
     }
 

DataStructures/LinkedList/CircularLinkedList/CircularLinkedList.cs

@@ -79,8 +79,7 @@ public void InsertAfter(T value, T data)
         {
             if (IsEmpty())
             {
-                Console.WriteLine("List is empty.");
-                return;
+                throw new InvalidOperationException("List is empty.");
             }
 
             var current = tail!.Next;
@@ -103,8 +102,6 @@ public void InsertAfter(T value, T data)
                 current = current.Next;
             }
             while (current != tail.Next);
-
-            Console.WriteLine($"Node with value {value} not found.");
         }
 
         /// <summary>
@@ -115,8 +112,7 @@ public void DeleteNode(T value)
         {
             if (IsEmpty())
             {
-                Console.WriteLine("List is empty.");
-                return;
+                throw new InvalidOperationException("List is empty.");
             }
 
             var current = tail!.Next;
@@ -144,16 +140,13 @@ public void DeleteNode(T value)
                         previous!.Next = current.Next;
                     }
 
-                    Console.WriteLine($"Node with value {value} deleted.");
                     return;
                 }
 
                 previous = current;
                 current = current.Next;
             }
             while (current != tail!.Next);
-
-            Console.WriteLine($"Node with value {value} not found.");
         }
 
         /// <summary>
@@ -163,8 +156,7 @@ public void Display()
         {
             if (IsEmpty())
             {
-                Console.WriteLine("List is empty.");
-                return;
+                throw new InvalidOperationException("List is empty.");
             }
 
             CircularLinkedListNode<T>? current = tail!.Next;