Skip to content

Commit 0f541b2

Browse files
committed
use fabs and explicitly mark variables as floating point
1 parent 956e87f commit 0f541b2

File tree

1 file changed

+9
-7
lines changed

1 file changed

+9
-7
lines changed

geometry/vectors_3d.c

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -158,8 +158,10 @@ vec_3d unit_vec(const vec_3d *a)
158158
vec_3d n = {0};
159159

160160
float norm = vector_norm(a);
161-
if (fabsf(norm) < EPSILON) // detect possible divide by 0
161+
if (fabsf(norm) < EPSILON)
162+
{ // detect possible divide by 0
162163
return n;
164+
}
163165

164166
if (norm != 1.F) // perform division only if needed
165167
{
@@ -206,21 +208,21 @@ static void test()
206208

207209
d = vector_norm(&a);
208210
// printf("|a| = %.4g\n", d);
209-
assert(fabs(d - 3.742) < 0.01);
211+
assert(fabsf(d - 3.742f) < 0.01);
210212
d = vector_norm(&b);
211213
// printf("|b| = %.4g\n", d);
212-
assert(fabs(d - 1.732) < 0.01);
214+
assert(fabsf(d - 1.732f) < 0.01);
213215

214216
d = dot_prod(&a, &b);
215217
// printf("Dot product: %f\n", d);
216-
assert(fabs(d - 6.f) < 0.01);
218+
assert(fabsf(d - 6.f) < 0.01);
217219

218220
vec_3d c = vector_prod(&a, &b);
219221
// printf("Vector product ");
220222
// printf("%s", print_vector(&c, "c"));
221-
assert(fabs(c.x - (-1)) < 0.01);
222-
assert(fabs(c.y - (2)) < 0.01);
223-
assert(fabs(c.z - (-1)) < 0.01);
223+
assert(fabsf(c.x - (-1.f)) < 0.01);
224+
assert(fabsf(c.y - (2.f)) < 0.01);
225+
assert(fabsf(c.z - (-1.f)) < 0.01);
224226
}
225227

226228
/**

0 commit comments

Comments
 (0)