Upgrade golangci/golangci-lint-action@v2 (#222)

* Upgrade golangci/golangci-lint-action@v2

* actions/setup-go@v2

* Update golangci-lint.yml

* Update golangci-lint.yml

* Update golangci-lint.yml

* Update golangci-lint.yml

* Update golangci-lint.yml

* gosimple change

* gosimple change

* Update golangci-lint.yml

Author: cclauss

.github/workflows/golangci-lint.yml

@@ -8,21 +8,20 @@ jobs:
       fail-fast: false
     steps:
       - uses: actions/checkout@v2
-      - name: golangci-lint
-        uses: golangci/golangci-lint-action@v1
+      - uses: actions/setup-go@v2
+      - uses: golangci/golangci-lint-action@v2
         with:
           # Required: the version of golangci-lint is required and must be specified without patch version: we always use the latest patch version.
-          version: v1.27
-          working-directory: sorts
+          version: v1.31
           args: --issues-exit-code=0  # Hopefully someday we can remove this...
-          # Only show new issues if this is a pull request...
-          # only-new-issues: true
-      - run: echo "::set-env name=PATH::/home/runner/golangci-lint-1.27.0-linux-amd64:$PATH"
+          working-directory: sorts    # Hopefully someday we can remove this... and enable only-new-issues
+          # only-new-issues: true  # Let's focus on this PR first
+      - run: echo "/home/runner/golangci-lint-1.31.0-linux-amd64" >> $GITHUB_PATH
       - run: go version ; golangci-lint --version  # Fix the following and remove || true
-      - run: golangci-lint run --no-config ciphers                            || true
+      - run: golangci-lint run --no-config ciphers
       - run: golangci-lint run --no-config data-structures/binary-tree        || true
       - run: golangci-lint run --no-config data-structures/dynamic-array      || true
-      - run: golangci-lint run --no-config data-structures/hash-map           || true
+      - run: golangci-lint run --no-config data-structures/hash-map
       - run: golangci-lint run --no-config data-structures/linked-list        || true
       - run: golangci-lint run --no-config data-structures/trie               || true
       - run: golangci-lint run --no-config dynamic-programming                || true

data-structures/hash-map/hash_map.go

@@ -47,12 +47,7 @@ func (hm *HashMap) Put(key interface{}, value interface{}) interface{} {
 // Contains checks if given key is stored in hashmap
 func (hm *HashMap) Contains(key interface{}) bool {
 	node := hm.getNodeByHash(hm.hash(key))
-
-	if node != nil {
-		return true
-	}
-
-	return false
+	return node != nil
 }
 
 func (hm *HashMap) putValue(hash uint64, key interface{}, value interface{}) interface{} {

math/sieve/Sieve.go

@@ -42,7 +42,7 @@ func nextF(f int, r chan int, nums []bool) {
 	for {
 		<-r
 		for i, v := range nums[f:] {
-			if v == true {
+			if v {
 				r <- i + f
 			}
 		}