Minor updates

Fixed a bug I had introduced in NaiveStringSearch.go,  cleaned up the unnecessary comments in diffieHellmanKeyExchange.go...

Author: 0xbrayo

ciphers/diffieHellmanKeyExchange.go

@@ -12,8 +12,7 @@ func main(){
 	p should ideally be a large prime number but any integer works
 	g should be a small integer, 2,3 works fine
 
-	PS: Note that the secret keys are never send over
-	the network
+	PS: Note that the secret keys are never send over the network
 	*/
 
 	p:=2+rand.Intn(1<<bit)
@@ -37,8 +36,7 @@ func main(){
 	fmt.Printf("Bob sends to Alice: %v\n",BobSends)
 
 	//Both parties calculate the shared secret key from the value send
-	//(value_sent^secret_key)%p
-	//Both calculations end up with same value despite the different inputs
+
 	AliceComputes :=modularExponentiation(BobSends,AliceSecret,p)
 	BobComputes := modularExponentiation(AliceSends,BobSecret,p)
 
@@ -50,11 +48,8 @@ func main(){
 		sharedKey:=AliceComputes
 		fmt.Println("Voila, shared key is ",sharedKey)
 	}
-
-
-
-
 }
+
 func modularExponentiation(b int, e int, mod int)int{
 	//runs in O(log(n)) where n = e
 	//uses exponentiation by squaring to speed up the process

ciphers/xorCipher.go

@@ -37,6 +37,7 @@ func main(){
 	temp:= []rune(str)
 	message:=toASCII(temp)
 	encrypted:=encrypt(key,message)
+	//ciphertext:=decodeToString(key,message)
 	decrypted:=decrypt(key,encrypted)
 	plaintext:=decodeToString(decrypted)
 	fmt.Println(plaintext)

sorts/sorts_case_test.go

@@ -13,7 +13,7 @@ type sortTest struct {
 	name     string
 }
 
-var arr []int = makeRandArray(500_000)
+var arr []= makeRandArray(500_000)
 
 
 var sortTests = []sortTest{

strings/naiveStringSearch.go

@@ -17,13 +17,12 @@ import (
 func naivePatternSearch(text string, pattern string) []int { 
     var positions []int 
     for i := 0; i < len(text)-len(pattern); i++ {
-        var match bool = true
+        var match = true
         j := i +(len(pattern))
-        if text[i+j] != pattern[j] {
+        if text[i:j] != pattern {
                 match = false
-                break
-            }
-        
+                continue
+            }        
         if match {
             positions = append(positions, i)
         }
@@ -34,11 +33,12 @@ func naivePatternSearch(text string, pattern string) []int {
 func main() {  
     text := "ABAAABCDBBABCDDEBCABC"
     pattern := "ABC"
-    var positions []int = naivePatternSearch(text, pattern)
+    positions := naivePatternSearch(text, pattern)
     if len(positions) == 0 {
-        fmt.Printf("Pattern not found in given text!")
+        fmt.Println("Pattern not found in given text!")
     } else {
-        fmt.Printf("Pattern found in following position:\n")
-        fmt.Printf("%v", positions)
+        fmt.Println("Pattern found in following position(s):")
+        fmt.Printf("%v \n", positions)
+        fmt.Println("Note that position is zero indexed :)")
     }
 }