Update ChebyshevIterationTest.java

Author: Keykyrios

src/test/java/com/thealgorithms/maths/ChebyshevIterationTest.java

@@ -7,101 +7,47 @@
 
 class ChebyshevIterationTest {
 
-    // --- Constants for testSolveSimple2x2System ---
-    private static final double M1_A11 = 4.0;
-    private static final double M1_A12 = 1.0;
-    private static final double M1_A21 = 1.0;
-    private static final double M1_A22 = 3.0;
-    private static final double[][] M1_A = {{M1_A11, M1_A12}, {M1_A21, M1_A22}};
-
-    private static final double M1_B1 = 1.0;
-    private static final double M1_B2 = 2.0;
-    private static final double[] M1_B = {M1_B1, M1_B2};
-    private static final double[] M1_X0 = {0.0, 0.0};
-
-    // Eigenvalues are (7 +/- sqrt(5)) / 2
+    private static final double[][] M1_A = { { 4.0, 1.0 }, { 1.0, 3.0 } };
+    private static final double[] M1_B = { 1.0, 2.0 };
+    private static final double[] M1_X0 = { 0.0, 0.0 };
     private static final double M1_LAMBDA_MIN = (7.0 - Math.sqrt(5.0)) / 2.0;
     private static final double M1_LAMBDA_MAX = (7.0 + Math.sqrt(5.0)) / 2.0;
-    private static final double M1_EXPECTED_X1 = 1.0 / 11.0;
-    private static final double M1_EXPECTED_X2 = 7.0 / 11.0;
-    private static final double[] M1_EXPECTED = {M1_EXPECTED_X1, M1_EXPECTED_X2};
+    private static final double[] M1_EXPECTED = { 1.0 / 11.0, 7.0 / 11.0 };
 
-    // --- Constants for testSolve3x3System ---
-    private static final double M2_A11 = 5.0;
-    private static final double M2_A22 = 2.0;
-    private static final double M2_A33 = 8.0;
-    private static final double[][] M2_A = {{M2_A11, 0.0, 0.0}, {0.0, M2_A22, 0.0}, {0.0, 0.0, M2_A33}};
-    private static final double M2_B1 = 10.0;
-    private static final double M2_B2 = -4.0;
-    private static final double M2_B3 = 24.0;
-    private static final double[] M2_B = {M1_B1, M2_B2, M2_B3};
-    private static final double[] M2_X0 = {0.0, 0.0, 0.0};
-    private static final double M2_E1 = 2.0;
-    private static final double M2_E2 = -2.0;
-    private static final double M2_E3 = 3.0;
-    private static final double[] M2_EXPECTED = {M2_E1, M2_E2, M2_E3};
+    private static final double[][] M2_A = { { 5.0, 0.0, 0.0 }, { 0.0, 2.0, 0.0 }, { 0.0, 0.0, 8.0 } };
+    private static final double[] M2_B = { 10.0, -4.0, 24.0 };
+    private static final double[] M2_X0 = { 0.0, 0.0, 0.0 };
+    private static final double[] M2_EXPECTED = { 2.0, -2.0, 3.0 };
     private static final double M2_LAMBDA_MIN = 2.0;
     private static final double M2_LAMBDA_MAX = 8.0;
 
-    // --- Constants for testAlreadyConverged ---
-    private static final double M3_LAMBDA_MIN = 2.38;
-    private static final double M3_LAMBDA_MAX = 4.62;
-
-    // --- Constants for Invalid/Dimension Tests ---
-    private static final double VAL_0_0 = 0.0;
-    private static final double VAL_0_5 = 0.5;
-    private static final double VAL_1_0 = 1.0;
-    private static final double VAL_1_5 = 1.5;
-    private static final double VAL_2_0 = 2.0;
-    private static final double[][] M4_A = {{VAL_1_0, VAL_0_0}, {VAL_0_0, VAL_1_0}};
-    private static final double[] M4_B = {VAL_1_0, VAL_1_0};
-    private static final double[] M4_X0 = {VAL_0_0, VAL_0_0};
-    private static final double[] M5_B = {VAL_1_0, VAL_1_0, VAL_1_0};
-    private static final double[][] M6_A = {{VAL_1_0, VAL_0_0, VAL_0_0}, {VAL_0_0, VAL_1_0, VAL_0_0}};
-    private static final double[] M6_B = {VAL_1_0, VAL_1_0};
-    private static final double[] M6_X0 = {VAL_0_0, VAL_0_0};
-
-    // --- General Constants ---
-    private static final int MAX_ITERATIONS = 100;
+    private static final double MAX_ITERATIONS = 100;
     private static final double TOLERANCE = 1e-10;
     private static final double ASSERT_TOLERANCE = 1e-9;
-    private static final int TEST_ITERATIONS = 10;
-    private static final double TEST_TOLERANCE = 1e-5;
 
     @Test
     void testSolveSimple2x2System() {
-        double[] solution = ChebyshevIteration.solve(M1_A, M1_B, M1_X0, M1_LAMBDA_MIN, M1_LAMBDA_MAX, MAX_ITERATIONS, TOLERANCE);
+        double[] solution = ChebyshevIteration.solve(M1_A, M1_B, M1_X0, M1_LAMBDA_MIN, M1_LAMBDA_MAX, 100, TOLERANCE);
         assertArrayEquals(M1_EXPECTED, solution, ASSERT_TOLERANCE);
     }
 
     @Test
     void testSolve3x3System() {
-        double[] solution = ChebyshevIteration.solve(M2_A, M2_B, M2_X0, M2_LAMBDA_MIN, M2_LAMBDA_MAX, MAX_ITERATIONS, TOLERANCE);
+        double[] solution = ChebyshevIteration.solve(M2_A, M2_B, M2_X0, M2_LAMBDA_MIN, M2_LAMBDA_MAX, 100, TOLERANCE);
         assertArrayEquals(M2_EXPECTED, solution, ASSERT_TOLERANCE);
     }
 
     @Test
     void testAlreadyConverged() {
-        // Test case where the initial guess is already the solution
-        double[] solution = ChebyshevIteration.solve(M1_A, M1_B, M1_EXPECTED, M3_LAMBDA_MIN, M3_LAMBDA_MAX, MAX_ITERATIONS, TOLERANCE);
+        double[] solution = ChebyshevIteration.solve(M1_A, M1_B, M1_EXPECTED, M1_LAMBDA_MIN, M1_LAMBDA_MAX, 100, TOLERANCE);
         assertArrayEquals(M1_EXPECTED, solution, ASSERT_TOLERANCE);
     }
 
     @Test
     void testInvalidEigenvalues() {
-        // lambdaMin >= lambdaMax
-        assertThrows(IllegalArgumentException.class, () -> { ChebyshevIteration.solve(M4_A, M4_B, M4_X0, VAL_2_0, VAL_1_0, TEST_ITERATIONS, TEST_TOLERANCE); });
-        // lambdaMin <= 0
-        assertThrows(IllegalArgumentException.class, () -> { ChebyshevIteration.solve(M4_A, M4_B, M4_X0, VAL_0_0, VAL_2_0, TEST_ITERATIONS, TEST_TOLERANCE); });
-    }
-
-    @Test
-    void testMismatchedDimensions() {
-        assertThrows(IllegalArgumentException.class, () -> { ChebyshevIteration.solve(M4_A, M5_B, M4_X0, VAL_0_5, VAL_1_5, TEST_ITERATIONS, TEST_TOLERANCE); });
-    }
-
-    @Test
-    void testNonSquareMatrix() {
-        assertThrows(IllegalArgumentException.class, () -> { ChebyshevIteration.solve(M6_A, M6_B, M6_X0, VAL_0_5, VAL_1_5, TEST_ITERATIONS, TEST_TOLERANCE); });
+        assertThrows(IllegalArgumentException.class,
+                () -> ChebyshevIteration.solve(M1_A, M1_B, M1_X0, 2.0, 1.0, 10, 1e-5));
+        assertThrows(IllegalArgumentException.class,
+                () -> ChebyshevIteration.solve(M1_A, M1_B, M1_X0, 0.0, 2.0, 10, 1e-5));
     }
 }