[FEATURE REQUEST] BitSwap.java

[shashanknr172-beep]

What would you like to Propose?

you have a neat implementation for bit swapping , but following improvements can be made

Add Method Overloads
Support swapping bits in a long (64-bit).
Support short or byte for completeness.

For example
/**

• Example:
• int data = 29; // 11101 (binary)
• int result = BitSwap.bitSwap(data, 0, 3);
• // result = 21 (10101 in binary)
  */

Performance Micro-Optimization
Instead of calling SingleBitOperations.getBit(...) twice, use bitwise directly.

For example

boolean bitA = ((data >> posA) & 1) != 0;
boolean bitB = ((data >> posB) & 1) != 0;
if (bitA != bitB) {
data ^= (1 << posA) | (1 << posB);
}

Count Set Bits

For example
public static int countSetBits(int data) {
int count = 0;
while (data != 0) {
data &= (data - 1);
count++;
}
return count;
}

Issue details

--

Additional Information

I Think these changes can be made but the first code for implementing bit swapping is absolutely correct .
what will be your opinion on these sir/madam .

[kunwarbhattal]

Yes your suggestions improve usability and performance:

1. Method overloading can make the code more versatile.
2. Using direct bitwise operations instead of calling SingleBitOperations.getBit(...) twice is cleaner and slightly faster.
3. Including a countSetBits method is a handy addition for common bit manipulation tasks.

Overall, I think the suggestions are useful enhancements, but the original implementation is correct and functional.
PS your example has a bug,
/**
Example:
int data = 29; // 11101 (binary)
int result = BitSwap.bitSwap(data, 0, 3);
// result = 21 (10101 in binary)
*/
here the result will be 29 only, as 0th and 3rd bit in 11101 are same.

[shashanknr172-beep]

Thankyou for the reply and i am sorry for the bug , surely the original implementation is correct .

[Amitesh-exp]

Please assign me this