From 95209f1150b04c3dbf8892d8f5f2825bdcde6bd3 Mon Sep 17 00:00:00 2001 From: saahil-mahato Date: Sun, 13 Oct 2024 18:15:15 +0545 Subject: [PATCH 1/2] refactor: clean long division code --- src/main/java/com/thealgorithms/maths/LongDivision.java | 9 +-------- .../java/com/thealgorithms/maths/LongDivisionTest.java | 2 +- 2 files changed, 2 insertions(+), 9 deletions(-) diff --git a/src/main/java/com/thealgorithms/maths/LongDivision.java b/src/main/java/com/thealgorithms/maths/LongDivision.java index 45e97b1c14c3..c2fcb5f25f68 100644 --- a/src/main/java/com/thealgorithms/maths/LongDivision.java +++ b/src/main/java/com/thealgorithms/maths/LongDivision.java @@ -46,19 +46,12 @@ public static int divide(int dividend, int divisor) { quotient++; } answer.append(quotient); - } else if (part1 == newDivisor1) { - int quotient = 0; - while (part1 >= newDivisor1) { - part1 = part1 - newDivisor1; - quotient++; - } - answer.append(quotient); } else if (part1 == 0) { answer.append(0); } else if (part1 < newDivisor1) { answer.append(0); } - if (!(part1 == 0)) { + if (part1 != 0) { remainder = String.valueOf(part1); } else { remainder = ""; diff --git a/src/test/java/com/thealgorithms/maths/LongDivisionTest.java b/src/test/java/com/thealgorithms/maths/LongDivisionTest.java index 24f757f8f3ad..b86a13311513 100644 --- a/src/test/java/com/thealgorithms/maths/LongDivisionTest.java +++ b/src/test/java/com/thealgorithms/maths/LongDivisionTest.java @@ -4,7 +4,7 @@ import org.junit.jupiter.api.Test; -public class LongDivisionTest { +class LongDivisionTest { // Requirement: Dividend (positive) is greater than divisor (positive), returns correct integer // after division From 4769e6ee03d7aadecf6bff41cd47ca9975140e93 Mon Sep 17 00:00:00 2001 From: saahil-mahato Date: Sun, 13 Oct 2024 18:18:46 +0545 Subject: [PATCH 2/2] fix: combine operators --- src/main/java/com/thealgorithms/maths/LongDivision.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/com/thealgorithms/maths/LongDivision.java b/src/main/java/com/thealgorithms/maths/LongDivision.java index c2fcb5f25f68..be87af5584f6 100644 --- a/src/main/java/com/thealgorithms/maths/LongDivision.java +++ b/src/main/java/com/thealgorithms/maths/LongDivision.java @@ -39,7 +39,7 @@ public static int divide(int dividend, int divisor) { for (int i = 0; i < dividendString.length(); i++) { String partV1 = remainder + "" + dividendString.substring(lastIndex, i + 1); long part1 = Long.parseLong(partV1); - if (part1 > newDivisor1) { + if (part1 >= newDivisor1) { int quotient = 0; while (part1 >= newDivisor1) { part1 = part1 - newDivisor1;