Skip to content

Fixed Type conversion error in BloomFilter.java Added RemoveStars and ComplexNumberMultiplication #6678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Fixed Type conversion error in BloomFilter.java Added RemoveStars and ComplexNumberMultiplication #6678

wants to merge 10 commits into from
+169 −1

Conversation

SwarritSrivastava
Copy link

@SwarritSrivastava SwarritSrivastava commented Oct 6, 2025 •
edited
Loading

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

What does this PR do?

Adds two new string algorithms:

  1. RemoveStars

    • Removes each '*' and its closest non-star character to the left.
    • Example: "abbc**def*g" → "abdeg"

  2. ComplexNumberMultiplication

    • Multiplies two complex numbers represented as strings.
    • Example: "1+1i" * "1+1i" → "0+2i"

Checklist

  • Added Javadoc comments
  • Added JUnit tests
  • Code passes Checkstyle, PMD, and SpotBugs
  • Verified locally with mvn clean verify

This is my contribution for Hacktoberfest 2025

@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 62.79070% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.77%. Comparing base (3eb521b) to head (c495f3d).

Files with missing lines Patch % Lines
...rithms/datastructures/bloomfilter/BloomFilter.java 20.00% 8 Missing and 8 partials ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #6678      +/-   ##
============================================
- Coverage     75.80%   75.77%   -0.03%     
- Complexity     5804     5810       +6     
============================================
  Files           705      707       +2     
  Lines         19846    19888      +42     
  Branches       3851     3862      +11     
============================================
+ Hits          15045    15071      +26     
- Misses         4218     4226       +8     
- Partials        583      591       +8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@SwarritSrivastava SwarritSrivastava marked this pull request as ready for review October 6, 2025 12:43
@SwarritSrivastava SwarritSrivastava marked this pull request as draft October 7, 2025 07:38
@SwarritSrivastava SwarritSrivastava changed the title Added RemoveStars and ComplexNumberMultiplication Added RemoveStars and ComplexNumberMultiplication Label:enhancement Oct 7, 2025
@SwarritSrivastava SwarritSrivastava changed the title Added RemoveStars and ComplexNumberMultiplication Label:enhancement Fixed Type conversion error in BloomFilter.java Added RemoveStars and ComplexNumberMultiplication Oct 7, 2025
@SwarritSrivastava SwarritSrivastava marked this pull request as ready for review October 7, 2025 07:41
@SwarritSrivastava SwarritSrivastava marked this pull request as draft October 7, 2025 07:44
@SwarritSrivastava SwarritSrivastava marked this pull request as ready for review October 7, 2025 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DenizAltunkapan DenizAltunkapan Awaiting requested review from DenizAltunkapan DenizAltunkapan is a code owner

@yanglbme yanglbme Awaiting requested review from yanglbme yanglbme is a code owner

@alxkm alxkm Awaiting requested review from alxkm alxkm is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SwarritSrivastava @codecov-commenter