Skip to content

Update merge_sort.py with new implementation #Fixes 8098 #11558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Update merge_sort.py with new implementation #Fixes 8098 #11558

wants to merge 5 commits into from

Conversation

csana004
Copy link

Describe your change:

Added a merge sort implementation in sorts/merge_sort.py. The implementation includes insertion, recursive and iterative approaches with proper doctests.

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes Concatenate/consolidate all algorithms with different implementations #8098".

@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Sep 10, 2024
@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Sep 10, 2024
imSanko
imSanko suggested changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@imSanko imSanko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to fix this:

ruff check --output-format=github .
  shell: /usr/bin/bash -e {0}

@Pajriboy1
Copy link

Hi

@cclauss
Copy link
Member

cclauss commented Sep 30, 2024

Closing tests_are_failing PRs to prepare for Hacktoberfest 2024

@cclauss cclauss closed this Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@imSanko imSanko imSanko requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Concatenate/consolidate all algorithms with different implementations

4 participants

@csana004 @Pajriboy1 @cclauss @imSanko