Skip to content

Conversation

@vil02
Copy link
Member

@vil02 vil02 commented Jan 17, 2025

Pull Request Template

Description

This PR removes redundant_else from the list of from the list of suppressed lints.

Continuation of #743.

Checklist:

  • I ran bellow commands using the latest version of rust nightly.
  • I ran cargo clippy --all -- -D warnings just before my last commit and fixed any issue that was found.
  • I ran cargo fmt just before my last commit.
  • I ran cargo test just before my last commit and all tests passed.
  • I added my algorithm to the corresponding mod.rs file within its own folder, and in any parent folder(s).
  • I added my algorithm to DIRECTORY.md with the correct link.
  • I checked COUNTRIBUTING.md and my code follows its guidelines.

@vil02 vil02 requested a review from siriak January 17, 2025 20:26
@vil02 vil02 marked this pull request as ready for review January 17, 2025 20:28
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.49%. Comparing base (a11736a) to head (d906aae).

Files with missing lines Patch % Lines
src/general/kmeans.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #860   +/-   ##
=======================================
  Coverage   95.48%   95.49%           
=======================================
  Files         316      316           
  Lines       22925    22922    -3     
=======================================
- Hits        21891    21889    -2     
+ Misses       1034     1033    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vil02 vil02 requested a review from imp2002 as a code owner January 17, 2025 20:28
@siriak siriak merged commit d4c3126 into TheAlgorithms:master Jan 17, 2025
4 checks passed
@vil02 vil02 deleted the include_redundant_else branch January 17, 2025 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants