⚡ improve performance on user list page

TheAlphamerc · TheAlphamerc · commit aff6527c1778 · 2020-04-03T08:58:12.000+05:30
1.:bug:(fix) Restrict composing empty Tweet from imageview page.
2. USer list is now fething from search page on userlist page.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,11 +1,11 @@
-## [1.0.3] - UPCOMMING
+## [1.0.4] - UPCOMMING
 
 * User sort feature added on user search page.
 * Added pull to refresh on search page.
 * Newest Tweet will show first in Tweet list.
 * Newest comment tweet will show first in comment Tweet list.
 
-## [1.0.2] - 31 Mar 2020
+## [1.0.3] - 31 Mar 2020
 
 * Google login failed bug fix
 * Email login at first time bug fix.
diff --git a/lib/page/common/usersListPage.dart b/lib/page/common/usersListPage.dart
@@ -1,7 +1,9 @@
 import 'package:flutter/material.dart';
 import 'package:flutter_twitter_clone/helper/theme.dart';
+import 'package:flutter_twitter_clone/model/user.dart';
 import 'package:flutter_twitter_clone/page/common/widget/userListWidget.dart';
 import 'package:flutter_twitter_clone/state/authState.dart';
+import 'package:flutter_twitter_clone/state/searchState.dart';
 import 'package:flutter_twitter_clone/widgets/customAppBar.dart';
 import 'package:flutter_twitter_clone/widgets/customWidgets.dart';
 import 'package:provider/provider.dart';
@@ -12,16 +14,17 @@ class UsersListPage extends StatelessWidget {
     this.pageTitle = "",
     this.appBarIcon,
     this.emptyScreenText,
-    this.emptyScreenSubTileText, 
-    this.userList,
+    this.emptyScreenSubTileText,
+    this.userIdsList,
   }) : super(key: key);
 
   final String pageTitle;
   final String emptyScreenText;
   final String emptyScreenSubTileText;
   final int appBarIcon;
-  final List<String> userList;
+  final List<String> userIdsList;
 
+  List<User> userList;
   @override
   Widget build(BuildContext context) {
     return Scaffold(
@@ -30,13 +33,18 @@ class UsersListPage extends StatelessWidget {
           isBackButton: true,
           title: customTitleText(pageTitle),
           icon: appBarIcon),
-      body: Consumer<AuthState>(
+      body: Consumer<SearchState>(
         builder: (context, state, child) {
-          return UserListWidget(
-            list: userList,
-            emptyScreenText: emptyScreenText,
-            emptyScreenSubTileText: emptyScreenSubTileText,
-          );
+          if (userIdsList != null) {
+            userList = state.getuserDetail(userIdsList);
+          }
+          return userList == null
+              ? LinearProgressIndicator()
+              : UserListWidget(
+                  list: userList,
+                  emptyScreenText: emptyScreenText,
+                  emptyScreenSubTileText: emptyScreenSubTileText,
+                );
         },
       ),
     );
diff --git a/lib/page/common/widget/userListWidget.dart b/lib/page/common/widget/userListWidget.dart
@@ -5,14 +5,15 @@ import 'package:flutter_twitter_clone/model/user.dart';
 import 'package:flutter_twitter_clone/state/authState.dart';
 import 'package:flutter_twitter_clone/state/feedState.dart';
 import 'package:flutter_twitter_clone/state/notificationState.dart';
+import 'package:flutter_twitter_clone/state/searchState.dart';
 import 'package:flutter_twitter_clone/widgets/customWidgets.dart';
 import 'package:flutter_twitter_clone/widgets/newWidget/customUrlText.dart';
 import 'package:flutter_twitter_clone/widgets/newWidget/emptyList.dart';
 import 'package:flutter_twitter_clone/widgets/newWidget/rippleButton.dart';
 import 'package:provider/provider.dart';
 
 class UserListWidget extends StatelessWidget {
-  final List<String> list;
+  final List<User> list;
   final String emptyScreenText;
   final String emptyScreenSubTileText;
   UserListWidget({
@@ -26,49 +27,21 @@ class UserListWidget extends StatelessWidget {
   Widget build(BuildContext context) {
     var state = Provider.of<AuthState>(context, listen: false);
     String myId = state.userModel.key;
-    return list != null && list.isNotEmpty
-        ? ListView.separated(
-            itemBuilder: (context, index) {
-              return FutureBuilder(
-                future: state.getuserDetail(list[index]),
-                builder: (context, AsyncSnapshot<User> snapshot) {
-                  if (snapshot.hasData) {
-                    return UserTile(
-                      user: snapshot.data,
-                      myId: myId,
-                    );
-                  } else if (index == 0) {
-                    return Container(
-                        child: SizedBox(
-                      height: 3,
-                      child: LinearProgressIndicator(),
-                    ));
-                  } else {
-                    return SizedBox.shrink();
-                  }
-                },
-              );
-            },
-            separatorBuilder: (context, index) {
-              return Divider(
-                height: 0,
-              );
-            },
-            itemCount: list.length,
-          )
-        : state.isbusy
-            ? SizedBox(
-                height: 3,
-                child: LinearProgressIndicator(),
-              )
-            : Container(
-                width: fullWidth(context),
-                padding: EdgeInsets.only(top: 0, left: 30, right: 30),
-                child: NotifyText(
-                  title: emptyScreenText,
-                  subTitle: emptyScreenSubTileText,
-                ),
-              );
+    return ListView.separated(
+      itemBuilder: (context, index) {
+        return UserTile(
+          user: list[index],
+          myId: myId,
+        );
+      },
+      separatorBuilder: (context, index) {
+        return Divider(
+          height: 0,
+        );
+      },
+      itemCount: list.length,
+    );
+    // : LinearProgressIndicator();
   }
 }
 
diff --git a/lib/page/feed/imageViewPage.dart b/lib/page/feed/imageViewPage.dart
@@ -157,6 +157,12 @@ class _ImageViewPgeState extends State<ImageViewPge> {
   }
 
   void _submitButton() {
+    if(_textEditingController.text == null || _textEditingController.text.isEmpty){
+      return;
+    }
+    if(_textEditingController.text.length > 280){
+      return ;
+    }
     var state = Provider.of<FeedState>(context);
     var authState = Provider.of<AuthState>(context);
     var user = authState.userModel;
diff --git a/lib/page/profile/follow/followerListPage.dart b/lib/page/profile/follow/followerListPage.dart
@@ -10,11 +10,13 @@ class FollowerListPage extends StatelessWidget {
   Widget build(BuildContext context) {
     var state = Provider.of<AuthState>(context);
     return UsersListPage(
-    pageTitle: 'Followers',
-    userList: state.profileUserModel?.followersList,
-    appBarIcon:AppIcon.follow,
-    emptyScreenText: '${state?.profileUserModel?.userName ?? state.userModel.userName} doesn\'t have any followers',
-    emptyScreenSubTileText: 'When someone follow them, they\'ll be listed here.',
+      pageTitle: 'Followers',
+      userIdsList: state.profileUserModel?.followersList,
+      appBarIcon: AppIcon.follow,
+      emptyScreenText:
+          '${state?.profileUserModel?.userName ?? state.userModel.userName} doesn\'t have any followers',
+      emptyScreenSubTileText:
+          'When someone follow them, they\'ll be listed here.',
     );
   }
 }
diff --git a/lib/page/profile/follow/followingListPage.dart b/lib/page/profile/follow/followingListPage.dart
@@ -10,7 +10,7 @@ class FollowingListPage extends StatelessWidget {
     var state = Provider.of<AuthState>(context);
     return UsersListPage(
         pageTitle: 'Following',
-        userList: state.profileUserModel.followingList,
+        userIdsList: state.profileUserModel.followingList,
         appBarIcon: AppIcon.follow,
         emptyScreenText:
             '${state?.profileUserModel?.userName ?? state.userModel.userName} isn\'t follow anyone',
diff --git a/lib/state/authState.dart b/lib/state/authState.dart
@@ -314,7 +314,8 @@ class AuthState extends AppState {
       cprint(error, errorIn: 'updateUserProfile');
     }
   }
-
+ 
+  
   /// `Fetch` user `detail` whoose userId is passed
   Future<User> getuserDetail(String userId) async {
     User user;
diff --git a/lib/state/searchState.dart b/lib/state/searchState.dart
@@ -125,4 +125,19 @@ class SearchState extends AppState {
         return "Unknown";
     }
   }
+  /// Return user list relative to provided `userIds` 
+  /// Method is used on 
+  List<User> userList = [];
+   List<User> getuserDetail(List<String> userIds){
+     final list = _userlist.where((x) {
+       if(userIds.contains(x.key)){
+         return true;
+       }
+       else{
+         return false;
+       }
+     
+     }).toList();
+    return list;
+  }
 }
diff --git a/lib/widgets/tweet/widgets/tweetIconsRow.dart b/lib/widgets/tweet/widgets/tweetIconsRow.dart
@@ -235,7 +235,7 @@ class TweetIconsRow extends StatelessWidget {
       CustomRoute<bool>(
         builder: (BuildContext context) => UsersListPage(
           pageTitle: "Liked by",
-          userList: model.likeList.map((x) => x.userId).toList(),
+          userIdsList: model.likeList.map((x) => x.userId).toList(),
         ),
       ),
     );

Original file line number	Diff line number	Diff line change
`@@ -314,7 +314,8 @@ class AuthState extends AppState {`
`314`	`314`	`cprint(error, errorIn: 'updateUserProfile');`
`315`	`315`	`}`
`316`	`316`	`}`
`317`		`-`
	`317`	`+`
	`318`	`+`
`318`	`319`	/// `Fetch` user `detail` whoose userId is passed
`319`	`320`	`Future<User> getuserDetail(String userId) async {`
`320`	`321`	`User user;`