Fix npm test issues

Author: danthonywalker

package-lock.json

@@ -30,7 +30,7 @@
     "eslint-plugin-sonarjs": "0.23.0",
     "eslint-plugin-unicorn": "50.0.1",
     "pino-pretty": "10.3.1",
-    "prettier": "3.1.1",
+    "prettier": "3.7.4",
     "shx": "0.3.4",
     "typescript": "5.3.3"
   },

package.json

@@ -29,7 +29,7 @@ export default session;
 
 export const compareCarsUi = async (
   context: Context,
-  interaction: Interaction
+  interaction: Interaction,
 ) => {
   // "perspective" was wrongly spelled "prospective" initially
   // Use new spelling while supporting older sessions

src/commands/carsized/context.ts

@@ -6,6 +6,7 @@ import assert from "node:assert";
 import { SupportedChannelTypes } from "../../creators";
 import discord, { registerCommand } from "../../shared/discord";
 import Environment from "../../shared/environment";
+import * as observability from "../../shared/observability";
 import onCreators, { Subcommand as CreatorsSubcommand } from "./creators";
 import { Option as ChannelMentionRoleOption } from "./creators/channel-mention-role";
 import * as database from "./database";
@@ -83,13 +84,19 @@ registerCommand(json, onCommand);
 // endregion
 
 // region Initialize Guilds
-discord.on(Events.ClientReady, async ({ guilds: guildManager }) => {
+const logger = observability.logger(module);
+
+discord.on(Events.ClientReady, ({ guilds: guildManager }) => {
   const guilds = guildManager.valueOf();
   const guildIds = [...guilds.keys()];
-  await database.initializeGuilds(guildIds);
+  database.initializeGuilds(guildIds).catch((error) => {
+    logger.error(error, "SETTINGS_CLIENT_READY_ERROR");
+  });
 });
 
-discord.on(Events.GuildCreate, async ({ id: guildId }) => {
-  await database.initializeGuilds([guildId]);
+discord.on(Events.GuildCreate, ({ id: guildId }) => {
+  database.initializeGuilds([guildId]).catch((error) => {
+    logger.error(error, "SETTINGS_GUILD_CREATE_ERROR");
+  });
 });
 // endregion

src/commands/settings/index.ts

@@ -105,7 +105,7 @@ export const getAnswersPng = async (context: Context) => {
 export const resultsUi = async (
   context: Context,
   interaction: Interaction,
-  files: BaseMessageOptions["files"] = []
+  files: BaseMessageOptions["files"] = [],
 ) => {
   const { survey } = context;
   const { message } = interaction;

src/commands/surveys/ui/results/context.ts

@@ -96,7 +96,6 @@ export const subscribe = async ({
 
         webhookId = webhook.id;
         webhookToken = webhook.token;
-        assert(webhookToken !== null);
       } else {
         webhookId = creatorChannel.webhookId;
         webhookToken = creatorChannel.webhookToken;
@@ -108,7 +107,6 @@ export const subscribe = async ({
 
       webhookId = webhook.id;
       webhookToken = webhook.token;
-      assert(webhookToken !== null);
     }
 
     creatorChannel = {

src/creators/subscribe/index.ts

@@ -125,7 +125,7 @@ const commands = new Map<string, Command>();
 export const registerCommand = (
   json: CommandJson,
   onCommand: OnCommand,
-  onAutocomplete?: OnAutocomplete
+  onAutocomplete?: OnAutocomplete,
 ) =>
   void commands.set(json.name, {
     json,

src/shared/discord.ts

@@ -91,12 +91,12 @@ declare module "ioredis" {
       lockKey: string, // KEYS[1]
       lockToken: string, // ARGV[1]
       expireInMilliseconds: number, // ARGV[2]
-      callback?: Callback<string>
+      callback?: Callback<string>,
     ): Result<number, Context>;
     unlock(
       lockKey: string, // KEYS[1]
       lockToken: string, // ARGV[1]
-      callback?: Callback<string>
+      callback?: Callback<string>,
     ): Result<number, Context>;
   }
 }
@@ -114,7 +114,7 @@ const tryLock = async (lockKey: string, expireInMilliseconds: number) => {
       "PX",
       expireInMilliseconds,
       "NX",
-      "GET"
+      "GET",
     );
   } catch (error) {
     logger.error(error, "TRY_LOCK_ERROR");
@@ -150,7 +150,7 @@ const lock = async (key: string, expireInMilliseconds: number) => {
 
 const extendLock = async (
   { key, token }: Lock,
-  expireInMilliseconds: number
+  expireInMilliseconds: number,
 ) => {
   try {
     await redis.extendLock(key, token, expireInMilliseconds);
@@ -170,7 +170,7 @@ const unlock = async ({ key, token }: Lock) => {
 const useLock = async <T>(
   key: string,
   callback: (lock: Lock) => NonNullable<T> | Promise<NonNullable<T>>,
-  expireInMilliseconds = 1000
+  expireInMilliseconds = 1000,
 ) => {
   const lockObject = await lock(key, expireInMilliseconds);
 
@@ -232,7 +232,7 @@ declare module "ioredis" {
       lockToken: string, // ARGV[1]
       value: string, // ARGV[2]
       expireInMilliseconds: number, // ARGV[3]
-      callback?: Callback<string>
+      callback?: Callback<string>,
     ): Result<null | string, Context>;
   }
 }
@@ -241,15 +241,15 @@ const atomicSet = async (
   lock: Lock,
   key: string,
   value: string,
-  expireInMilliseconds: number
+  expireInMilliseconds: number,
 ) => {
   try {
     await redis.atomicSet(
       lock.key,
       key,
       lock.token,
       value,
-      expireInMilliseconds
+      expireInMilliseconds,
     );
   } catch (error) {
     logger.error(error, "ATOMIC_SET_ERROR");
@@ -273,7 +273,7 @@ export const computeIfAbsent = async <T>(
   key: string,
   callback: () => Promise<NonNullable<T>>,
   cacheExpirationInMilliseconds = Number.MAX_VALUE,
-  lockExpirationInMilliseconds = 1000
+  lockExpirationInMilliseconds = 1000,
 ) => {
   let value = await get<NonNullable<T>>(key);
 
@@ -291,7 +291,7 @@ export const computeIfAbsent = async <T>(
 
         return value;
       },
-      lockExpirationInMilliseconds
+      lockExpirationInMilliseconds,
     );
   }