Linter: Support Bevy 0.15 (#191)

This updates the linter to support Bevy 0.15. As #138 has not yet been
implemented, Bevy 0.14 support is being dropped.[^0]

Overall, it was surprisingly simple. I bumped the version of Bevy we use
in testing, then fixed any errors. The UI tests are so rigid that even
the slightest quiver could cause them to fail, which in this case is a
good thing!

The one thing of note is that I'm keeping support for
`World::many_entities()` and `many_entities_mut()` in
`bevy::panicking_world_methods` even though they are deprecated. Since
`panicking_methods` is likely a lint that would be denied in projects, I
don't want panicking methods to slip by just because someone added
`#[allow(deprecated)]` while migration their project. Once these methods
are completely removed from Bevy, we'll remove them from the linter.

[^0]: I hope this won't be permanent, though. If all goes to plan,
support for 0.14 will be re-added before the next release of
`bevy_lint`!

Author: BD103

Cargo.lock

@@ -41,7 +41,7 @@ toml_edit = { version = "0.22.22", default-features = false, features = [
 
 [dev-dependencies]
 # Used when running UI tests.
-bevy = { version = "0.14.2", default-features = false }
+bevy = { version = "0.15.0", default-features = false }
 
 # Used to deserialize `--message-format=json` messages from Cargo.
 serde = { version = "1.0.210", features = ["derive"] }

bevy_lint/Cargo.toml

@@ -154,7 +154,7 @@ There are several other ways to toggle lints, but they have varying levels of su
 
 |`bevy_lint` Version|Rust Version|Rustup Toolchain|Bevy Version|
 |-|-|-|-|
-|0.2.0-dev|1.84.0|`nightly-2024-11-28`|0.14|
+|0.2.0-dev|1.84.0|`nightly-2024-11-28`|0.15|
 |0.1.0|1.84.0|`nightly-2024-11-14`|0.14|
 
 The Rust version in the above table specifies what [version of the Rust language](https://github.com/rust-lang/rust/releases) can be compiled with `bevy_lint`. Code written for a later version of Rust may not compile. (This is not usually an issue, though, because `bevy_lint`'s Rust version is kept 1 to 2 releases ahead of stable Rust.)

bevy_lint/README.md

@@ -13,9 +13,8 @@ pub const DEFERRED: [&str; 4] = ["bevy_ecs", "system", "system_param", "Deferred
 pub const DEFERRED_WORLD: [&str; 4] = ["bevy_ecs", "world", "deferred_world", "DeferredWorld"];
 pub const ENTITY_COMMANDS: [&str; 4] = ["bevy_ecs", "system", "commands", "EntityCommands"];
 pub const ENTITY_MUT: [&str; 4] = ["bevy_ecs", "world", "entity_ref", "EntityMut"];
-// Note that this moves to `bevy_ecs::event::base::Event` in 0.15.
-pub const EVENT: [&str; 3] = ["bevy_ecs", "event", "Event"];
-pub const EVENTS: [&str; 3] = ["bevy_ecs", "event", "Events"];
+pub const EVENT: [&str; 4] = ["bevy_ecs", "event", "base", "Event"];
+pub const EVENTS: [&str; 4] = ["bevy_ecs", "event", "collections", "Events"];
 pub const FILTERED_ENTITY_MUT: [&str; 4] = ["bevy_ecs", "world", "entity_ref", "FilteredEntityMut"];
 pub const MUT: [&str; 3] = ["bevy_ecs", "change_detection", "Mut"];
 pub const MUT_UNTYPED: [&str; 3] = ["bevy_ecs", "change_detection", "MutUntyped"];

bevy_lint/src/paths.rs

@@ -2,7 +2,7 @@ error: parameter takes `&mut EntityCommands` instead of a re-borrowed `EntityCom
   --> tests/ui/borrowed_reborrowable/entity_commands.rs:17:22
    |
 17 | fn mutable_reference(_param: &mut EntityCommands) {
-   |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `EntityCommands` instead: `mut _param: bevy::bevy_ecs::system::EntityCommands<'_>`
+   |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `EntityCommands` instead: `mut _param: bevy::prelude::EntityCommands<'_>`
    |
 note: the lint level is defined here
   --> tests/ui/borrowed_reborrowable/entity_commands.rs:5:9
@@ -14,7 +14,7 @@ error: parameter takes `&mut EntityCommands` instead of a re-borrowed `EntityCom
   --> tests/ui/borrowed_reborrowable/entity_commands.rs:23:33
    |
 23 | fn mutable_reference_return<'a>(_param: &'a mut EntityCommands) -> usize {
-   |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `EntityCommands` instead: `mut _param: bevy::bevy_ecs::system::EntityCommands<'_>`
+   |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `EntityCommands` instead: `mut _param: bevy::prelude::EntityCommands<'_>`
 
 error: aborting due to 2 previous errors
 

bevy_lint/tests/ui/borrowed_reborrowable/entity_commands.stderr

@@ -37,4 +37,6 @@ impl Component for MyEvent {
 }
 
 //~v NOTE: `Event` implemented here
-impl Event for MyEvent {}
+impl Event for MyEvent {
+    type Traversal = ();
+}

bevy_lint/tests/ui/missing_reflect/impl.rs

@@ -7,8 +7,10 @@ error: defined an event without a `Reflect` implementation
 note: `Event` implemented here
   --> tests/ui/missing_reflect/impl.rs:40:1
    |
-40 | impl Event for MyEvent {}
-   | ^^^^^^^^^^^^^^^^^^^^^^^^^
+40 | / impl Event for MyEvent {
+41 | |     type Traversal = ();
+42 | | }
+   | |_^
 note: the lint level is defined here
   --> tests/ui/missing_reflect/impl.rs:8:9
    |

bevy_lint/tests/ui/missing_reflect/impl.stderr

@@ -42,4 +42,6 @@ impl Component for &'static &'static &'static MyEvent {
 }
 
 //~v NOTE: `Event` implemented here
-impl Event for &'static &'static &'static MyEvent {}
+impl Event for &'static &'static &'static MyEvent {
+    type Traversal = ();
+}

bevy_lint/tests/ui/missing_reflect/impl_ref.rs

@@ -7,8 +7,10 @@ error: defined an event without a `Reflect` implementation
 note: `Event` implemented here
   --> tests/ui/missing_reflect/impl_ref.rs:45:1
    |
-45 | impl Event for &'static &'static &'static MyEvent {}
-   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+45 | / impl Event for &'static &'static &'static MyEvent {
+46 | |     type Traversal = ();
+47 | | }
+   | |_^
 note: the lint level is defined here
   --> tests/ui/missing_reflect/impl_ref.rs:13:9
    |

bevy_lint/tests/ui/missing_reflect/impl_ref.stderr

@@ -28,10 +28,12 @@ fn main() {
     //~^ ERROR: called a `World` method that can panic when a non-panicking alternative exists
     //~| HELP: use `world.get_entity_mut(bob)`
 
+    #[expect(deprecated, reason = "While this method is deprecated, we should still check for it while it exists.")]
     world.many_entities([bob]);
     //~^ ERROR: called a `World` method that can panic when a non-panicking alternative exists
     //~| HELP: use `world.get_many_entities([bob])`
 
+    #[expect(deprecated, reason = "While this method is deprecated, we should still check for it while it exists.")]
     world.many_entities_mut([bob]);
     //~^ ERROR: called a `World` method that can panic when a non-panicking alternative exists
     //~| HELP: use `world.get_many_entities_mut([bob])`