Merge pull request lightningdevkit#3339 from arik-so/lint-script-file

TheBlueMatt · web-flow · commit 43e28fe3a415 · 2024-10-09T14:09:13.000Z
Create script file for easy local linting
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -246,96 +246,7 @@ jobs:
           rustup component add clippy
       - name: Run default clippy linting
         run: |
-          RUSTFLAGS='-D warnings' cargo clippy -- \
-                `# Errors` \
-                -A clippy::erasing_op \
-                -A clippy::never_loop \
-                `# Warnings` \
-                -A renamed_and_removed_lints \
-                -A clippy::blocks_in_conditions \
-                -A clippy::borrow_deref_ref \
-                -A clippy::clone_on_copy \
-                -A clippy::collapsible_else_if \
-                -A clippy::collapsible_if \
-                -A clippy::collapsible_match \
-                -A clippy::comparison_chain \
-                -A clippy::doc_lazy_continuation \
-                -A clippy::drain_collect \
-                -A clippy::drop_non_drop \
-                -A clippy::enum_variant_names \
-                -A clippy::explicit_auto_deref \
-                -A clippy::extra_unused_lifetimes \
-                -A clippy::for_kv_map \
-                -A clippy::from_over_into \
-                -A clippy::get_first \
-                -A clippy::identity_op \
-                -A clippy::if_same_then_else \
-                -A clippy::inconsistent_digit_grouping \
-                -A clippy::iter_kv_map \
-                -A clippy::iter_skip_next \
-                -A clippy::large_enum_variant \
-                -A clippy::legacy_numeric_constants \
-                -A clippy::len_without_is_empty \
-                -A clippy::len_zero \
-                -A clippy::let_and_return \
-                -A clippy::manual_filter \
-                -A clippy::manual_map \
-                -A clippy::manual_memcpy \
-                -A clippy::manual_inspect \
-                -A clippy::manual_range_contains \
-                -A clippy::manual_range_patterns \
-                -A clippy::manual_saturating_arithmetic \
-                -A clippy::manual_strip \
-                -A clippy::map_clone \
-                -A clippy::map_flatten \
-                -A clippy::match_like_matches_macro \
-                -A clippy::match_ref_pats \
-                -A clippy::multiple_bound_locations \
-                -A clippy::mut_mutex_lock \
-                -A clippy::needless_bool \
-                -A clippy::needless_borrow \
-                -A clippy::needless_borrowed_reference \
-                -A clippy::needless_borrows_for_generic_args \
-                -A clippy::needless_lifetimes \
-                -A clippy::needless_question_mark \
-                -A clippy::needless_range_loop \
-                -A clippy::needless_return \
-                -A clippy::new_without_default \
-                -A clippy::non_minimal_cfg \
-                -A clippy::op_ref \
-                -A clippy::option_as_ref_deref \
-                -A clippy::option_map_or_none \
-                -A clippy::option_map_unit_fn \
-                -A clippy::precedence \
-                -A clippy::ptr_arg \
-                -A clippy::question_mark \
-                -A clippy::readonly_write_lock \
-                -A clippy::redundant_closure \
-                -A clippy::redundant_field_names \
-                -A clippy::redundant_guards \
-                -A clippy::redundant_pattern_matching \
-                -A clippy::redundant_slicing \
-                -A clippy::redundant_static_lifetimes \
-                -A clippy::result_large_err \
-                -A clippy::result_unit_err \
-                -A clippy::search_is_some \
-                -A clippy::single_char_pattern \
-                -A clippy::single_match \
-                -A clippy::slow_vector_initialization \
-                -A clippy::tabs_in_doc_comments \
-                -A clippy::to_string_in_format_args \
-                -A clippy::too_many_arguments \
-                -A clippy::toplevel_ref_arg \
-                -A clippy::type_complexity \
-                -A clippy::unnecessary_cast \
-                -A clippy::unnecessary_get_then_check \
-                -A clippy::unnecessary_lazy_evaluations \
-                -A clippy::unnecessary_mut_passed \
-                -A clippy::unnecessary_sort_by \
-                -A clippy::unnecessary_to_owned \
-                -A clippy::unnecessary_unwrap \
-                -A clippy::unused_unit \
-                -A clippy::useless_conversion
+          ./ci/check-lint.sh
 
   rustfmt:
     runs-on: ubuntu-latest
diff --git a/ci/check-lint.sh b/ci/check-lint.sh
@@ -0,0 +1,93 @@
+#!/bin/sh
+set -e
+set -x
+RUSTFLAGS='-D warnings' cargo clippy -- \
+	`# Errors` \
+	-A clippy::erasing_op \
+	-A clippy::never_loop \
+	`# Warnings` \
+	-A renamed_and_removed_lints \
+	-A clippy::blocks_in_conditions \
+	-A clippy::borrow_deref_ref \
+	-A clippy::clone_on_copy \
+	-A clippy::collapsible_else_if \
+	-A clippy::collapsible_if \
+	-A clippy::collapsible_match \
+	-A clippy::comparison_chain \
+	-A clippy::doc_lazy_continuation \
+	-A clippy::drain_collect \
+	-A clippy::drop_non_drop \
+	-A clippy::enum_variant_names \
+	-A clippy::explicit_auto_deref \
+	-A clippy::extra_unused_lifetimes \
+	-A clippy::for_kv_map \
+	-A clippy::from_over_into \
+	-A clippy::get_first \
+	-A clippy::identity_op \
+	-A clippy::if_same_then_else \
+	-A clippy::inconsistent_digit_grouping \
+	-A clippy::iter_kv_map \
+	-A clippy::iter_skip_next \
+	-A clippy::large_enum_variant \
+	-A clippy::legacy_numeric_constants \
+	-A clippy::len_without_is_empty \
+	-A clippy::len_zero \
+	-A clippy::let_and_return \
+	-A clippy::manual_filter \
+	-A clippy::manual_map \
+	-A clippy::manual_memcpy \
+	-A clippy::manual_inspect \
+	-A clippy::manual_range_contains \
+	-A clippy::manual_range_patterns \
+	-A clippy::manual_saturating_arithmetic \
+	-A clippy::manual_strip \
+	-A clippy::map_clone \
+	-A clippy::map_flatten \
+	-A clippy::match_like_matches_macro \
+	-A clippy::match_ref_pats \
+	-A clippy::multiple_bound_locations \
+	-A clippy::mut_mutex_lock \
+	-A clippy::needless_bool \
+	-A clippy::needless_borrow \
+	-A clippy::needless_borrowed_reference \
+	-A clippy::needless_borrows_for_generic_args \
+	-A clippy::needless_lifetimes \
+	-A clippy::needless_question_mark \
+	-A clippy::needless_range_loop \
+	-A clippy::needless_return \
+	-A clippy::new_without_default \
+	-A clippy::non_minimal_cfg \
+	-A clippy::op_ref \
+	-A clippy::option_as_ref_deref \
+	-A clippy::option_map_or_none \
+	-A clippy::option_map_unit_fn \
+	-A clippy::precedence \
+	-A clippy::ptr_arg \
+	-A clippy::question_mark \
+	-A clippy::readonly_write_lock \
+	-A clippy::redundant_closure \
+	-A clippy::redundant_field_names \
+	-A clippy::redundant_guards \
+	-A clippy::redundant_pattern_matching \
+	-A clippy::redundant_slicing \
+	-A clippy::redundant_static_lifetimes \
+	-A clippy::result_large_err \
+	-A clippy::result_unit_err \
+	-A clippy::search_is_some \
+	-A clippy::single_char_pattern \
+	-A clippy::single_match \
+	-A clippy::slow_vector_initialization \
+	-A clippy::tabs_in_doc_comments \
+	-A clippy::to_string_in_format_args \
+	-A clippy::too_many_arguments \
+	-A clippy::toplevel_ref_arg \
+	-A clippy::type_complexity \
+	-A clippy::unnecessary_cast \
+	-A clippy::unnecessary_get_then_check \
+	-A clippy::unnecessary_lazy_evaluations \
+	-A clippy::unnecessary_mut_passed \
+	-A clippy::unnecessary_sort_by \
+	-A clippy::unnecessary_to_owned \
+	-A clippy::unnecessary_unwrap \
+	-A clippy::unused_unit \
+	-A clippy::useless_conversion
