WIP

- Tweak some logging around "maybe cptv files"

Author: hardiesoft

api/api/V1/Recording.ts

@@ -59,7 +59,7 @@ import type { Application, NextFunction, Request, Response } from "express";
 import { body, param, query } from "express-validator";
 import type { JwtPayload } from "jsonwebtoken";
 import jwt from "jsonwebtoken";
-import Sequelize, { Op } from "sequelize";
+import { Op } from "sequelize";
 import LabelPaths from "../../classifications/label_paths.json" with { type: "json" };
 
 import {
@@ -125,7 +125,6 @@ import { TrackTagUserData } from "@models/TrackTagUserData.js";
 import { Device } from "@models/Device.js";
 import { Station } from "@models/Station.js";
 import { Visit } from "@models/Visit.js";
-import logger from "@log";
 
 const sequelize = await initSequelize();
 
@@ -1846,7 +1845,7 @@ export default (app: Application, baseUrl: string) => {
           // FIXME - should probably not be success
           return successResponse(response, "Tag already exists.");
         }
-      } catch (e) {
+      } catch (_e) {
         return next(new FatalError("Server error replacing tag."));
       }
     },
@@ -2773,7 +2772,7 @@ export default (app: Application, baseUrl: string) => {
               ),
             );
         }
-      } catch (e) {
+      } catch (_e) {
         return successResponse(response, "Got recordings", {
           recordings: [],
         });

api/api/fileUploaders/uploadGenericRecording.ts

@@ -343,8 +343,11 @@ const processFilePart = async (
           // TODO: The file could be corrupt, but we could still get a valid CPTV header out.
           //  test this case.
           const header = await decoder.getHeader();
-          if (header) {
-            console.log("Header found in corrupt CPTV file", header);
+          if (header && typeof header !== "string") {
+            log.info(
+              "Header found in corrupt CPTV file: %s",
+              JSON.stringify(header),
+            );
             embeddedMetadata = header;
           }
         }