Squashed 'libbitcoinkernel-sys/bitcoin/' changes from f1b3ab751bf..fc67047b7e1

fc67047b7e1 kernel: Add pure kernel bitcoin-chainstate
e2116031253 kernel: Add functions to get the block hash from a block
2ae6547941f kernel: Add block index utility functions to C header
f09d42fff2b kernel: Add function to read block undo data from disk to C header
52aedd024b0 kernel: Add functions to read block from disk to C header
6d2bdce9923 kernel: Add function for copying  block data to C header
e3b16b2677a kernel: Add functions for the block validation state to C header
8de0bd040f4 kernel: Add validation interface to C header
84abd35f72a kernel: Add interrupt function to C header
260fb3e0584 kernel: Add import blocks function to C header
971bb20e9c8 kernel: Add chainstate load options for in-memory dbs in C header
1af8c906fc7 kernel: Add options for reindexing in C header
055d2ed419e kernel: Add block validation to C header
39850656a04 Kernel: Add chainstate loading to kernel C header
06d26f0bfa6 kernel: Add chainstate manager option for setting worker threads
a3d46f4bf64 kernel: Add chainstate manager object to C header
d2e2da933b7 kernel: Add notifications context option to C header
1337539a0b3 kerenl: Add chain params context option to C header
778330c21f0 kernel: Add kernel library context object
a54b59d8100 kernel: Add logging to kernel library C header
4fe7162698d kernel: Introduce initial kernel C header API
REVERT: f1b3ab751bf kernel: Add pure kernel bitcoin-chainstate
REVERT: 47c0497f899 kernel: Add functions to get the block hash from a block
REVERT: bf051407293 kernel: Add block index utility functions to C header
REVERT: 0dc1261a394 kernel: Add function to read block undo data from disk to C header
REVERT: 8ae118d85d9 kernel: Add functions to read block from disk to C header
REVERT: d757da1e777 kernel: Add function for copying  block data to C header
REVERT: c7625645ffa kernel: Add functions for the block validation state to C header
REVERT: 085ab7e71c2 kernel: Add validation interface to C header
REVERT: d8b7cf099d3 kernel: Add interrupt function to C header
REVERT: 018613752ad kernel: Add import blocks function to C header
REVERT: 8fc00b9fcac kernel: Add chainstate load options for in-memory dbs in C header
REVERT: a9bb48476ed kernel: Add options for reindexing in C header
REVERT: 94bd5138dac kernel: Add block validation to C header
REVERT: c399b61f226 Kernel: Add chainstate loading to kernel C header
REVERT: feede0a425b kernel: Add chainstate manager option for setting worker threads
REVERT: 583820c4487 kernel: Add chainstate manager object to C header
REVERT: ec137a086a0 kernel: Add notifications context option to C header
REVERT: 62a89689266 kerenl: Add chain params context option to C header
REVERT: bb482dcbd30 kernel: Add kernel library context object
REVERT: d114ccfdf8a kernel: Add logging to kernel library C header
REVERT: 44c65c46c43 kernel: Introduce initial kernel C header API

git-subtree-dir: libbitcoinkernel-sys/bitcoin
git-subtree-split: fc67047b7e1fb7031285f790ea3a7ea349474f31

Author: TheCharlatan

src/kernel/bitcoin-chainstate.cpp

@@ -91,7 +91,7 @@ class TestValidationInterface : public ValidationInterface<TestValidationInterfa
 class TestKernelNotifications : public KernelNotifications<TestKernelNotifications>
 {
 public:
-    void BlockTipHandler(kernel_SynchronizationState state, kernel_BlockIndex* index) override
+    void BlockTipHandler(kernel_SynchronizationState state, const kernel_BlockIndex* index) override
     {
         std::cout << "Block tip changed" << std::endl;
     }

src/kernel/bitcoinkernel.cpp

@@ -167,28 +167,28 @@ class KernelNotifications : public kernel::Notifications
 
     kernel::InterruptResult blockTip(SynchronizationState state, CBlockIndex& index) override
     {
-        if (m_cbs.block_tip) m_cbs.block_tip(m_cbs.user_data, cast_state(state), reinterpret_cast<kernel_BlockIndex*>(&index));
+        if (m_cbs.block_tip) m_cbs.block_tip((void*) m_cbs.user_data, cast_state(state), reinterpret_cast<const kernel_BlockIndex*>(&index));
         return {};
     }
     void headerTip(SynchronizationState state, int64_t height, int64_t timestamp, bool presync) override
     {
-        if (m_cbs.header_tip) m_cbs.header_tip(m_cbs.user_data, cast_state(state), height, timestamp, presync);
+        if (m_cbs.header_tip) m_cbs.header_tip((void*) m_cbs.user_data, cast_state(state), height, timestamp, presync);
     }
     void warningSet(kernel::Warning id, const bilingual_str& message) override
     {
-        if (m_cbs.warning_set) m_cbs.warning_set(m_cbs.user_data, cast_kernel_warning(id), message.original.c_str());
+        if (m_cbs.warning_set) m_cbs.warning_set((void*) m_cbs.user_data, cast_kernel_warning(id), message.original.c_str());
     }
     void warningUnset(kernel::Warning id) override
     {
-        if (m_cbs.warning_unset) m_cbs.warning_unset(m_cbs.user_data, cast_kernel_warning(id));
+        if (m_cbs.warning_unset) m_cbs.warning_unset((void*) m_cbs.user_data, cast_kernel_warning(id));
     }
     void flushError(const bilingual_str& message) override
     {
-        if (m_cbs.flush_error) m_cbs.flush_error(m_cbs.user_data, message.original.c_str());
+        if (m_cbs.flush_error) m_cbs.flush_error((void*) m_cbs.user_data, message.original.c_str());
     }
     void fatalError(const bilingual_str& message) override
     {
-        if (m_cbs.fatal_error) m_cbs.fatal_error(m_cbs.user_data, message.original.c_str());
+        if (m_cbs.fatal_error) m_cbs.fatal_error((void*) m_cbs.user_data, message.original.c_str());
     }
 };
 
@@ -245,7 +245,7 @@ class KernelValidationInterface final : public CValidationInterface
     void BlockChecked(const CBlock& block, const BlockValidationState& stateIn) override
     {
         if (m_cbs.block_checked) {
-            m_cbs.block_checked(m_cbs.user_data,
+            m_cbs.block_checked((void*) m_cbs.user_data,
                                 reinterpret_cast<const kernel_BlockPointer*>(&block),
                                 reinterpret_cast<const kernel_BlockValidationState*>(&stateIn));
         }
@@ -511,7 +511,7 @@ void kernel_disable_logging()
 }
 
 kernel_LoggingConnection* kernel_logging_connection_create(kernel_LogCallback callback,
-                                                           void* user_data,
+                                                           const void* user_data,
                                                            const kernel_LoggingOptions options)
 {
     LogInstance().m_log_timestamps = options.log_timestamps;
@@ -520,7 +520,7 @@ kernel_LoggingConnection* kernel_logging_connection_create(kernel_LogCallback ca
     LogInstance().m_log_sourcelocations = options.log_sourcelocations;
     LogInstance().m_always_print_category_level = options.always_print_category_levels;
 
-    auto connection{LogInstance().PushBackCallback([callback, user_data](const std::string& str) { callback(user_data, str.c_str()); })};
+    auto connection{LogInstance().PushBackCallback([callback, user_data](const std::string& str) { callback((void*) user_data, str.c_str()); })};
 
     try {
         // Only start logging if we just added the connection.
@@ -783,9 +783,9 @@ void kernel_block_manager_options_destroy(kernel_BlockManagerOptions* options)
 }
 
 kernel_ChainstateManager* kernel_chainstate_manager_create(
+    const kernel_Context* context_,
     kernel_ChainstateManagerOptions* chainman_opts_,
-    kernel_BlockManagerOptions* blockman_opts_,
-    const kernel_Context* context_)
+    kernel_BlockManagerOptions* blockman_opts_)
 {
     auto chainman_opts{cast_chainstate_manager_options(chainman_opts_)};
     auto blockman_opts{cast_block_manager_options(blockman_opts_)};

src/kernel/bitcoinkernel.h

@@ -31,7 +31,7 @@
 #define BITCOINKERNEL_WARN_UNUSED_RESULT
 #endif
 #if !defined(BITCOINKERNEL_BUILD) && defined(__GNUC__) && BITCOINKERNEL_GNUC_PREREQ(3, 4)
-#define BITCOINKERNEL_ARG_NONNULL(_x) __attribute__((__nonnull__(_x)))
+#define BITCOINKERNEL_ARG_NONNULL(...) __attribute__((__nonnull__(__VA_ARGS__)))
 #else
 #define BITCOINKERNEL_ARG_NONNULL(_x)
 #endif
@@ -43,13 +43,14 @@ extern "C" {
 /**
  * ------ Context ------
  *
- * The library provides a built-in static constant kernel context. This context
- * offers only limited functionality. It detects and self-checks the correct
- * sha256 implementation, initializes the random number generator and
- * self-checks the secp256k1 static context. It is used internally for otherwise
- * "context-free" operations.
+ * The library provides a built-in static constant kernel context. This static
+ * context offers only limited functionality. It detects and self-checks the
+ * correct sha256 implementation, initializes the random number generator and
+ * self-checks the secp256k1 static context. It is used internally for
+ * otherwise "context-free" operations. This means that the user is not
+ * required to initialize their own context before using the library.
  *
- * The user can create their own context for passing it to state-rich validation
+ * The user should create their own context for passing it to state-rich validation
  * functions and holding callbacks for kernel events.
  *
  * ------ Error handling ------
@@ -73,11 +74,13 @@ extern "C" {
  * returned by functions. Typically pointers returned by *_create(...) functions
  * can be de-allocated by corresponding *_destroy(...) functions.
  *
- * Pointer arguments make no assumptions on their lifetime. Once the function
- * returns the user can safely de-allocate the passed in arguments.
+ * A function that takes pointer arguments makes no assumptions on their
+ * lifetime. Once the function returns the user can safely de-allocate the
+ * passed in arguments.
  *
- * Pointers passed by callbacks are not owned by the user and are only valid for
- * the duration of it. They should not be de-allocated by the user.
+ * Pointers passed by callbacks are not owned by the user and are only valid
+ * for the duration of the callback. They are always marked as `const` and must
+ * not be de-allocated by the user.
  *
  * Array lengths follow the pointer argument they describe.
  */
@@ -128,8 +131,9 @@ typedef struct kernel_Notifications kernel_Notifications;
  *
  * Once a kernel context has been created from these options, they may be
  * destroyed. The options hold the notification callbacks as well as the
- * selected chain type until they are passed to the context. Their content and
- * scope can be expanded over time.
+ * selected chain type until they are passed to the context. If no options are
+ * configured, the context will be instantiated with no callbacks and for
+ * mainnet. Their content and scope can be expanded over time.
  */
 typedef struct kernel_ContextOptions kernel_ContextOptions;
 
@@ -266,7 +270,7 @@ typedef void (*kernel_LogCallback)(void* user_data, const char* message);
 /**
  * Function signatures for the kernel notifications.
  */
-typedef void (*kernel_NotifyBlockTip)(void* user_data, kernel_SynchronizationState state, kernel_BlockIndex* index);
+typedef void (*kernel_NotifyBlockTip)(void* user_data, kernel_SynchronizationState state, const kernel_BlockIndex* index);
 typedef void (*kernel_NotifyHeaderTip)(void* user_data, kernel_SynchronizationState state, int64_t height, int64_t timestamp, bool presync);
 typedef void (*kernel_NotifyProgress)(void* user_data, const char* title, int progress_percent, bool resume_possible);
 typedef void (*kernel_NotifyWarningSet)(void* user_data, kernel_Warning warning, const char* message);
@@ -311,7 +315,7 @@ typedef enum {
  * callbacks easier.
  */
 typedef struct {
-    void* user_data;                                      //!< Holds a user-defined opaque structure that is passed to the validation
+    const void* user_data;                                //!< Holds a user-defined opaque structure that is passed to the validation
                                                           //!< interface callbacks.
     kernel_ValidationInterfaceBlockChecked block_checked; //!< Called when a new block has been checked. Contains the
                                                           //!< result of its validation.
@@ -326,7 +330,7 @@ typedef struct {
  * safe unwinding.
  */
 typedef struct {
-    void* user_data;                         //!< Holds a user-defined opaque structure that is passed to the notification callbacks.
+    const void* user_data;                   //!< Holds a user-defined opaque structure that is passed to the notification callbacks.
     kernel_NotifyBlockTip block_tip;         //!< The chain's tip was updated to the provided block index.
     kernel_NotifyHeaderTip header_tip;       //!< A new best block header was added.
     kernel_NotifyProgress progress;          //!< Reports on current block synchronization progress.
@@ -493,7 +497,8 @@ void kernel_transaction_output_destroy(kernel_TransactionOutput* transaction_out
 
 /**
  * @brief Verify if the input at input_index of tx_to spends the script pubkey
- * under the constraints specified by flags. If the witness flag is set the
+ * under the constraints specified by flags. If the
+ * `kernel_SCRIPT_FLAGS_VERIFY_WITNESS` flag is set in the flags bitfield, the
  * amount parameter is used. If the taproot flag is set, the spent outputs
  * parameter is used to validate taproot transactions.
  *
@@ -518,7 +523,7 @@ bool BITCOINKERNEL_WARN_UNUSED_RESULT kernel_verify_script(
     unsigned int input_index,
     unsigned int flags,
     kernel_ScriptVerifyStatus* status
-) BITCOINKERNEL_ARG_NONNULL(1) BITCOINKERNEL_ARG_NONNULL(3);
+) BITCOINKERNEL_ARG_NONNULL(1, 3);
 
 /**
  * @brief This disables the global internal logger. No log messages will be
@@ -570,7 +575,7 @@ bool BITCOINKERNEL_WARN_UNUSED_RESULT kernel_disable_log_category(const kernel_L
  */
 kernel_LoggingConnection* BITCOINKERNEL_WARN_UNUSED_RESULT kernel_logging_connection_create(
     kernel_LogCallback callback,
-    void* user_data,
+    const void* user_data,
     const kernel_LoggingOptions options
 ) BITCOINKERNEL_ARG_NONNULL(1);
 
@@ -622,7 +627,7 @@ kernel_ContextOptions* BITCOINKERNEL_WARN_UNUSED_RESULT kernel_context_options_c
 void kernel_context_options_set_chainparams(
     kernel_ContextOptions* context_options,
     const kernel_ChainParameters* chain_parameters
-) BITCOINKERNEL_ARG_NONNULL(1) BITCOINKERNEL_ARG_NONNULL(2);
+) BITCOINKERNEL_ARG_NONNULL(1, 2);
 
 /**
  * @brief Set the kernel notifications for the context options. The context
@@ -634,7 +639,7 @@ void kernel_context_options_set_chainparams(
 void kernel_context_options_set_notifications(
     kernel_ContextOptions* context_options,
     const kernel_Notifications* notifications
-) BITCOINKERNEL_ARG_NONNULL(1) BITCOINKERNEL_ARG_NONNULL(2);
+) BITCOINKERNEL_ARG_NONNULL(1, 2);
 
 /**
  * Destroy the context options.
@@ -682,7 +687,7 @@ void kernel_context_destroy(kernel_Context* context);
 kernel_ChainstateManagerOptions* BITCOINKERNEL_WARN_UNUSED_RESULT kernel_chainstate_manager_options_create(
     const kernel_Context* context,
     const char* data_directory
-) BITCOINKERNEL_ARG_NONNULL(1) BITCOINKERNEL_ARG_NONNULL(2);
+) BITCOINKERNEL_ARG_NONNULL(1, 2);
 
 /**
  * Destroy the chainstate manager options.
@@ -703,7 +708,7 @@ void kernel_chainstate_manager_options_destroy(kernel_ChainstateManagerOptions*
 kernel_BlockManagerOptions* BITCOINKERNEL_WARN_UNUSED_RESULT kernel_block_manager_options_create(
     const kernel_Context* context,
     const char* blocks_directory
-) BITCOINKERNEL_ARG_NONNULL(1) BITCOINKERNEL_ARG_NONNULL(2);
+) BITCOINKERNEL_ARG_NONNULL(1, 2);
 
 /**
  * @brief Set the number of available worker threads used during validation.
@@ -735,10 +740,10 @@ void kernel_block_manager_options_destroy(kernel_BlockManagerOptions* block_mana
  * @return                               The allocated chainstate manager, or null on error.
  */
 kernel_ChainstateManager* BITCOINKERNEL_WARN_UNUSED_RESULT kernel_chainstate_manager_create(
+    const kernel_Context* context,
     kernel_ChainstateManagerOptions* chainstate_manager_options,
-    kernel_BlockManagerOptions* block_manager_options,
-    const kernel_Context* context
-) BITCOINKERNEL_ARG_NONNULL(1) BITCOINKERNEL_ARG_NONNULL(2) BITCOINKERNEL_ARG_NONNULL(3);
+    kernel_BlockManagerOptions* block_manager_options
+) BITCOINKERNEL_ARG_NONNULL(1, 2, 3);
 
 /**
  * Destroy the chainstate manager.
@@ -770,7 +775,7 @@ kernel_ValidationInterface* BITCOINKERNEL_WARN_UNUSED_RESULT kernel_validation_i
 bool BITCOINKERNEL_WARN_UNUSED_RESULT kernel_validation_interface_register(
     kernel_Context* context,
     kernel_ValidationInterface* validation_interface
-) BITCOINKERNEL_ARG_NONNULL(1) BITCOINKERNEL_ARG_NONNULL(2);
+) BITCOINKERNEL_ARG_NONNULL(1, 2);
 
 /**
  * @brief Unregister a validation interface from the internal task runner
@@ -784,7 +789,7 @@ bool BITCOINKERNEL_WARN_UNUSED_RESULT kernel_validation_interface_register(
 bool BITCOINKERNEL_WARN_UNUSED_RESULT kernel_validation_interface_unregister(
     kernel_Context* context,
     kernel_ValidationInterface* validation_interface
-) BITCOINKERNEL_ARG_NONNULL(1) BITCOINKERNEL_ARG_NONNULL(2);
+) BITCOINKERNEL_ARG_NONNULL(1, 2);
 
 /**
  * Destroy the validation interface. This should be done after unregistering it
@@ -860,7 +865,7 @@ bool BITCOINKERNEL_WARN_UNUSED_RESULT kernel_chainstate_manager_load_chainstate(
     const kernel_Context* context,
     kernel_ChainstateLoadOptions* chainstate_load_options,
     kernel_ChainstateManager* chainstate_manager
-) BITCOINKERNEL_ARG_NONNULL(1) BITCOINKERNEL_ARG_NONNULL(2) BITCOINKERNEL_ARG_NONNULL(3);
+) BITCOINKERNEL_ARG_NONNULL(1, 2, 3);
 
 /**
  * @brief May be called after kernel_chainstate_manager_load_chainstate to
@@ -877,7 +882,7 @@ bool BITCOINKERNEL_WARN_UNUSED_RESULT kernel_chainstate_manager_load_chainstate(
 bool kernel_import_blocks(const kernel_Context* context,
                           kernel_ChainstateManager* chainstate_manager,
                           const char** block_file_paths, size_t block_file_paths_len
-) BITCOINKERNEL_ARG_NONNULL(1) BITCOINKERNEL_ARG_NONNULL(2);
+) BITCOINKERNEL_ARG_NONNULL(1, 2);
 
 /**
  * @brief Process and validate the passed in block with the chainstate
@@ -897,7 +902,7 @@ bool BITCOINKERNEL_WARN_UNUSED_RESULT kernel_chainstate_manager_process_block(
     kernel_ChainstateManager* chainstate_manager,
     kernel_Block* block,
     bool* new_block
-) BITCOINKERNEL_ARG_NONNULL(1) BITCOINKERNEL_ARG_NONNULL(2) BITCOINKERNEL_ARG_NONNULL(3);
+) BITCOINKERNEL_ARG_NONNULL(1, 2, 3);
 
 /**
  * @brief Parse a serialized raw block into a new block object.
@@ -985,7 +990,7 @@ kernel_BlockValidationResult kernel_get_block_validation_result_from_block_valid
 kernel_BlockIndex* BITCOINKERNEL_WARN_UNUSED_RESULT kernel_get_block_index_from_tip(
     const kernel_Context* context,
     kernel_ChainstateManager* chainstate_manager
-) BITCOINKERNEL_ARG_NONNULL(1) BITCOINKERNEL_ARG_NONNULL(2);
+) BITCOINKERNEL_ARG_NONNULL(1, 2);
 
 /**
  * @brief Get the block index entry of the genesis block.
@@ -997,7 +1002,7 @@ kernel_BlockIndex* BITCOINKERNEL_WARN_UNUSED_RESULT kernel_get_block_index_from_
 kernel_BlockIndex* BITCOINKERNEL_WARN_UNUSED_RESULT kernel_get_block_index_from_genesis(
     const kernel_Context* context,
     kernel_ChainstateManager* chainstate_manager
-) BITCOINKERNEL_ARG_NONNULL(1) BITCOINKERNEL_ARG_NONNULL(2);
+) BITCOINKERNEL_ARG_NONNULL(1, 2);
 
 /**
  * @brief Retrieve a block index by its block hash.
@@ -1011,7 +1016,7 @@ kernel_BlockIndex* BITCOINKERNEL_WARN_UNUSED_RESULT kernel_get_block_index_by_ha
     const kernel_Context* context,
     kernel_ChainstateManager* chainstate_manager,
     kernel_BlockHash* block_hash
-) BITCOINKERNEL_ARG_NONNULL(1) BITCOINKERNEL_ARG_NONNULL(2) BITCOINKERNEL_ARG_NONNULL(3);
+) BITCOINKERNEL_ARG_NONNULL(1, 2, 3);
 
 /**
  * @brief Retrieve a block index by its height in the currently active chain.
@@ -1026,7 +1031,7 @@ kernel_BlockIndex* BITCOINKERNEL_WARN_UNUSED_RESULT kernel_get_block_index_by_he
     const kernel_Context* context,
     kernel_ChainstateManager* chainstate_manager,
     int block_height
-) BITCOINKERNEL_ARG_NONNULL(1) BITCOINKERNEL_ARG_NONNULL(2);
+) BITCOINKERNEL_ARG_NONNULL(1, 2);
 
 /**
  * @brief Return the next block index in the currently active chain, or null if
@@ -1042,7 +1047,7 @@ kernel_BlockIndex* BITCOINKERNEL_WARN_UNUSED_RESULT kernel_get_next_block_index(
     const kernel_Context* context,
     kernel_BlockIndex* block_index,
     kernel_ChainstateManager* chainstate_manager
-) BITCOINKERNEL_ARG_NONNULL(1) BITCOINKERNEL_ARG_NONNULL(2) BITCOINKERNEL_ARG_NONNULL(3);
+) BITCOINKERNEL_ARG_NONNULL(1, 2, 3);
 
 /**
  * @brief Returns the previous block index in the chain, or null if the current
@@ -1068,7 +1073,7 @@ kernel_Block* BITCOINKERNEL_WARN_UNUSED_RESULT kernel_read_block_from_disk(
     const kernel_Context* context,
     kernel_ChainstateManager* chainstate_manager,
     kernel_BlockIndex* block_index
-) BITCOINKERNEL_ARG_NONNULL(1) BITCOINKERNEL_ARG_NONNULL(2) BITCOINKERNEL_ARG_NONNULL(3);
+) BITCOINKERNEL_ARG_NONNULL(1, 2, 3);
 
 /**
  * @brief Reads the block undo data the passed in block index points to from
@@ -1083,7 +1088,7 @@ kernel_BlockUndo* BITCOINKERNEL_WARN_UNUSED_RESULT kernel_read_block_undo_from_d
     const kernel_Context* context,
     kernel_ChainstateManager* chainstate_manager,
     kernel_BlockIndex* block_index
-) BITCOINKERNEL_ARG_NONNULL(1) BITCOINKERNEL_ARG_NONNULL(2) BITCOINKERNEL_ARG_NONNULL(3);
+) BITCOINKERNEL_ARG_NONNULL(1, 2, 3);
 
 /**
  * @brief Destroy the block index.

src/kernel/bitcoinkernel_wrapper.h

@@ -183,7 +183,7 @@ class KernelNotifications
     {
         return kernel_NotificationInterfaceCallbacks{
             .user_data = this,
-            .block_tip = [](void* user_data, kernel_SynchronizationState state, kernel_BlockIndex* index) {
+            .block_tip = [](void* user_data, kernel_SynchronizationState state, const kernel_BlockIndex* index) {
                 static_cast<T*>(user_data)->BlockTipHandler(state, index);
             },
             .header_tip = [](void* user_data, kernel_SynchronizationState state, int64_t height, int64_t timestamp, bool presync) {
@@ -208,7 +208,7 @@ class KernelNotifications
 
     virtual ~KernelNotifications() = default;
 
-    virtual void BlockTipHandler(kernel_SynchronizationState state, kernel_BlockIndex* index) {}
+    virtual void BlockTipHandler(kernel_SynchronizationState state, const kernel_BlockIndex* index) {}
 
     virtual void HeaderTipHandler(kernel_SynchronizationState state, int64_t height, int64_t timestamp, bool presync) {}
 
@@ -622,7 +622,7 @@ class ChainMan
 
 public:
     ChainMan(const Context& context, const ChainstateManagerOptions& chainman_opts, const BlockManagerOptions& blockman_opts) noexcept
-        : m_chainman{kernel_chainstate_manager_create(chainman_opts.m_options.get(), blockman_opts.m_options.get(), context.m_context.get())},
+        : m_chainman{kernel_chainstate_manager_create(context.m_context.get(), chainman_opts.m_options.get(), blockman_opts.m_options.get())},
           m_context{context}
     {
     }

src/test/kernel/test_kernel.cpp

@@ -76,7 +76,7 @@ struct TestDirectory {
 class TestKernelNotifications : public KernelNotifications<TestKernelNotifications>
 {
 public:
-    void BlockTipHandler(kernel_SynchronizationState state, kernel_BlockIndex* index) override
+    void BlockTipHandler(kernel_SynchronizationState state, const kernel_BlockIndex* index) override
     {
         std::cout << "Block tip changed" << std::endl;
     }