Skip to content

Commit 616dc2b

Browse files
feat(eslint): Add more exceptions for id-length rule
1 parent 00c25e8 commit 616dc2b

File tree

2 files changed

+18
-3
lines changed

2 files changed

+18
-3
lines changed

packages/eslint/eslint-config/src/__tests__/rules/id-length.test.ts

Lines changed: 17 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@ const ruleId: CustomRule = 'id-length';
1010
describe(`${ruleId} rule`, () => {
1111
it('should FAIL when identifier is too short', async () => {
1212
const code = `
13-
const x = 1;
14-
const y = 2;
13+
const a = 1;
14+
const b = 2;
1515
`;
1616
const messages = await getLintMessagesForRule(baseConfig, code, ruleId);
1717

@@ -27,4 +27,19 @@ describe(`${ruleId} rule`, () => {
2727

2828
expect(messages).toHaveLength(0);
2929
});
30+
31+
it('should PASS when identifiers are on exceptions list', async () => {
32+
const code = `
33+
const i = 1;
34+
const e = 2;
35+
const _ = 3;
36+
const x = 4;
37+
const y = 5;
38+
const z = 6;
39+
const q = 7;
40+
`;
41+
const messages = await getLintMessagesForRule(baseConfig, code, ruleId);
42+
43+
expect(messages).toHaveLength(0);
44+
});
3045
});

packages/eslint/eslint-config/src/base.rules.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ export const baseRules = {
4646
'grouped-accessor-pairs': ['error', 'getBeforeSet'],
4747
'id-length': [
4848
'error',
49-
{ exceptions: ['i', 'e', '_'] },
49+
{ exceptions: ['i', 'e', '_', 'x', 'y', 'z', 'q'] },
5050
] satisfies ESLintRules['id-length'],
5151
'max-classes-per-file': ['error'],
5252
'max-depth': ['error'],

0 commit comments

Comments
 (0)