Expand ESLint support for TypeScript and add max-warnings CLI option (#36)

Author: TheCodeDestroyer

.changeset/cruel-breads-read.md

@@ -0,0 +1,5 @@
+---
+'@tcd-devkit/eslint-config-ts': patch
+---
+
+Fix ESLint errors

.changeset/khaki-pigs-wink.md

@@ -0,0 +1,5 @@
+---
+'@tcd-devkit/eslint-preset-node': patch
+---
+
+Properly configure Node ENV

.changeset/salty-pianos-write.md

@@ -0,0 +1,5 @@
+---
+'@tcd-devkit/scripts': patch
+---
+
+Add max-warnings arg for ESLint

.changeset/solid-lands-tickle.md

@@ -0,0 +1,6 @@
+---
+'@tcd-devkit/eslint-config-import': patch
+'@tcd-devkit/eslint-config': patch
+---
+
+Add missing TypeScript file extensions

commitlint.config.js

@@ -1,6 +1,4 @@
-/**
- * @type {import('@commitlint/types').UserConfig}
- */
+/** @type {import('@commitlint/types').UserConfig} */
 export default {
   extends: ['@tcd-devkit'],
 };

package.json

@@ -24,6 +24,7 @@
     "@changesets/changelog-github": "0.5.1",
     "@changesets/cli": "2.29.4",
     "@commitlint/cli": "19.8.1",
+    "@commitlint/types": "19.8.1",
     "@tcd-devkit/commitlint-config": "workspace:*",
     "@tcd-devkit/eslint-preset-node": "workspace:*",
     "@tcd-devkit/prettier-config": "workspace:*",

packages/eslint-presets/eslint-preset-node/package.json

@@ -59,7 +59,8 @@
     "@tcd-devkit/eslint-config": "workspace:*",
     "@tcd-devkit/eslint-config-import-ts": "workspace:*",
     "@tcd-devkit/eslint-config-ts": "workspace:*",
-    "eslint-config-prettier": "10.1.5"
+    "eslint-config-prettier": "10.1.5",
+    "globals": "16.2.0"
   },
   "devDependencies": {
     "@tcd-devkit/scripts": "workspace:*",

packages/eslint-presets/eslint-preset-node/src/node-preset.linter.ts

@@ -1,6 +1,7 @@
 import type { Linter } from 'eslint';
 import prettierConfig from 'eslint-config-prettier/flat';
 import { defineConfig, globalIgnores } from 'eslint/config';
+import globals from 'globals';
 
 import { baseConfig } from '@tcd-devkit/eslint-config';
 import { importTsConfig } from '@tcd-devkit/eslint-config-import-ts';
@@ -14,6 +15,11 @@ const ignoresConfig = globalIgnores(
 export const nodePreset: Linter.Config[] = defineConfig([
   {
     name: '@tcd-devkit/eslint-preset-node',
+    languageOptions: {
+      globals: {
+        ...globals.node,
+      },
+    },
     extends: [baseConfig, tsConfig, importTsConfig],
   },
   prettierConfig,

packages/eslint/eslint-config-import/src/import.linter.ts

@@ -9,7 +9,7 @@ const importRecommended = importPluginConfigs.recommended as Linter.Config;
 export const importConfig = defineConfig({
   name: '@tcd-devkit/eslint-config-import',
   extends: [importRecommended],
-  files: ['**/*.{js,jsx,mjs,cjs}'],
+  files: ['**/*.{js,jsx,ts,tsx,mjs,cjs}'],
   rules: importRules,
 });
 

packages/eslint/eslint-config-ts/src/__tests__/rules/unbound-method.test.ts

@@ -9,10 +9,6 @@ describe(`${ruleId} rule`, () => {
   it('should have a disabled rule', () => {
     const ruleValue = tsRules[ruleId];
 
-    console.log('tsRules:', tsRules);
-    console.log('ruleId:', ruleId);
-    console.log('ruleValue:', ruleValue);
-
     expect(ruleValue).toEqual(['off']);
   });
 });