Skip to content

Commit 3f9577f

Browse files
Use Collection Expressions
1 parent 1ea173e commit 3f9577f

File tree

5 files changed

+9
-8
lines changed

5 files changed

+9
-8
lines changed

.editorconfig

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,7 @@ dotnet_style_require_accessibility_modifiers = omit_if_default:warning
5555
# Suggest more modern language features when available
5656
dotnet_style_object_initializer = true:suggestion
5757
dotnet_style_collection_initializer = true:suggestion
58+
dotnet_style_prefer_collection_expression = when_types_loosely_match:suggestion
5859
dotnet_style_coalesce_expression = true:suggestion
5960
dotnet_style_null_propagation = true:suggestion
6061
dotnet_style_explicit_tuple_names = true:suggestion

sample/ViewModels/BaseViewModel.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ protected BaseViewModel(IDispatcher dispatcher)
1212
BindingBase.EnableCollectionSynchronization(TopStoryCollection, null, ObservableCollectionCallback);
1313
}
1414

15-
public ObservableCollection<StoryModel> TopStoryCollection { get; } = new();
15+
public ObservableCollection<StoryModel> TopStoryCollection { get; } = [];
1616

1717
protected IDispatcher Dispatcher { get; }
1818

sample/ViewModels/NewsViewModel_BadAsyncAwaitPractices.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ async Task Refresh(CancellationToken token)
6262
// ToDo Refactor
6363
async Task<FrozenSet<StoryModel>> GetTopStories(CancellationToken token, int storyCount = int.MaxValue)
6464
{
65-
List<StoryModel> topStoryList = new();
65+
List<StoryModel> topStoryList = [];
6666

6767
var topStoryIds = await GetTopStoryIDs(token).ConfigureAwait(false);
6868

src/AsyncAwaitBestPractices.UnitTests/WeakEventManagerTests/Tests_WeakEventManager_Delegate.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@ public void WeakEventManagerDelegate_HandleEvent_InvalidHandleEventEventName()
143143
public void WeakEventManagerDelegate_HandleEvent_DynamicMethod_ValidImplementation()
144144
{
145145
//Arrange
146-
var dynamicMethod = new System.Reflection.Emit.DynamicMethod(string.Empty, typeof(void), new[] { typeof(object), typeof(PropertyChangedEventArgs) });
146+
var dynamicMethod = new System.Reflection.Emit.DynamicMethod(string.Empty, typeof(void), [typeof(object), typeof(PropertyChangedEventArgs)]);
147147
var ilGenerator = dynamicMethod.GetILGenerator();
148148
ilGenerator.Emit(System.Reflection.Emit.OpCodes.Ret);
149149

src/AsyncAwaitBestPractices/WeakEventManager/EventManagerService.shared.cs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ internal static void AddEventHandler(in string eventName, in object? handlerTarg
1717
var doesContainSubscriptions = eventHandlers.TryGetValue(eventName, out var targets);
1818
if (!doesContainSubscriptions || targets is null)
1919
{
20-
targets = new List<Subscription>();
20+
targets = [];
2121
eventHandlers.Add(eventName, targets);
2222
}
2323

@@ -64,11 +64,11 @@ internal static void HandleEvent(in string eventName, in object? sender, in obje
6464
if (eventHandler.IsLightweightMethod())
6565
{
6666
var method = TryGetDynamicMethod(eventHandler);
67-
method?.Invoke(instance, new[] { sender, eventArgs });
67+
method?.Invoke(instance, [sender, eventArgs]);
6868
}
6969
else
7070
{
71-
eventHandler.Invoke(instance, new[] { sender, eventArgs });
71+
eventHandler.Invoke(instance, [sender, eventArgs]);
7272
}
7373
}
7474
catch (TargetParameterCountException e)
@@ -90,11 +90,11 @@ internal static void HandleEvent(in string eventName, in object? actionEventArgs
9090
if (eventHandler.IsLightweightMethod())
9191
{
9292
var method = TryGetDynamicMethod(eventHandler);
93-
method?.Invoke(instance, new[] { actionEventArgs });
93+
method?.Invoke(instance, [actionEventArgs]);
9494
}
9595
else
9696
{
97-
eventHandler.Invoke(instance, new[] { actionEventArgs });
97+
eventHandler.Invoke(instance, [actionEventArgs]);
9898
}
9999
}
100100
catch (TargetParameterCountException e)

0 commit comments

Comments
 (0)